Re: Regression after jpackage+1-49 update

On 7/10/2019 4:43 pm, Alan Bateman wrote: On 07/10/2019 04:35, David Holmes wrote: Nothing to do with jpackage but a fix to Class.forName to ensure classes are linked as per the specification of forName. You can temporarily workaround with -XX:+ClassForNameDeferLinking, but your code needs t

Re: Regression after jpackage+1-49 update

On 07/10/2019 08:00, David Holmes wrote: On 7/10/2019 4:43 pm, Alan Bateman wrote: On 07/10/2019 04:35, David Holmes wrote: Nothing to do with jpackage but a fix to Class.forName to ensure classes are linked as per the specification of forName. You can temporarily workaround with -XX:+ClassF

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

This is a nice addition. LGTM. -Chris. On 05/10/2019 00:46, Stuart Marks wrote: On 10/3/19 8:32 AM, Joe Darcy wrote: In response to the recent and on-going review of serializable types in the base module and elsewhere, I thought it would be helpful if the collections specs discussed how col

Re: RFR: JDK-8226585: Improve javac messages for using a preview API

Hi Joe, Thanks for the suggestion, but I don't think we can do it using Taglets - as far as I know, Taglets cannot add tabs to the method listing. We would either need to modify javadoc, or (maybe) have a special doclet for JDK documentation. Jan On 04. 10. 19 7:08, Joe Darcy wrote: Hi Jan

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

On 04/10/2019 20:55, Roger Riggs wrote: Hi Andrew, That does seem more straightforward. The name ALWAYSCOMPACTABLE doesn't really match the rest of the nomenclature used in the compact string code. Can you change the name to LATIN1COMPATIBLE? Its similar to the ASCIICOMPATIBLE case and tied in

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

On 2019-10-04 21:55, Roger Riggs wrote: Can you change the name to LATIN1COMPATIBLE? Its similar to the ASCIICOMPATIBLE case and tied in to the Latin1 coding for used in StringCoding. To me, compatible has a specific meaning that's not really the case here. Perhaps isLatin1Decodable/LATIN1DECO

Re: RFR: JDK-8227715: GPLv2 files missing Classpath Exception

Good idea Joe. :) I've added Sergey, Lana, Magnus, and Alan, all of whom seem to have at least a passing connection to these files in terms of commits. Sergey, Lana, Magnus, and Alan: Four of the files in jdk8u appear to have a GPLv2 header without the usual Classpath Exception. -- jdk/make/s

Re: RFR: JDK-8227715: GPLv2 files missing Classpath Exception

On 07/10/2019 13:51, Adam Farley8 wrote: : -- jdk/src/macosx/native/jobjc/JObjC.xcodeproj/default.pbxuser It might be simpler to just get rid of the JObjC bits. If you dig through the JDK 8 history then you should see that JObjC.jar was dropped from the boot class path (it should never have bee

Re: RFR: 8230043: Lazily load libverify

On 25/08/2019 20:35, Claes Redestad wrote: Both functions abort similarly if UTF-8 sequences can't be decoded. The fix- version just gets rid of logic to check for slashes, which is redundant at all existing call sites except the Class.forName one. The fact we return JNI_FALSE when verifyFixC

Re: RFR: 8230043: Lazily load libverify

On 2019-10-07 15:28, Alan Bateman wrote: What you have is okay, I was mostly interesting in seeing if we could rename verifyFixClassname to fixClassname that returns JNI_TRUE if it succeeds and JNI_FALSE if fails due to a slash. We can look at that another time, I don't want to delay this imp

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

Thanks for the feedback, so we just need to decide on the variable name.. I am leaning towards isLatin1Decodable since it is closer to implying the charset is decodable to Latin1 via the decodeToLatin1() method, whereas isLatin1Compatible sort of implies it is "compatible" and decodable in certa

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

Hi Andrew, I'm fine with isLatin1Decodable/LATIN1DECODABLE. To avoid confusion with "Latin-1", aka ISO-8859-1 the character set, in prose, there may be an opportunity to reinforce that it refers to the compact LATIN1 String coding.  Perhaps in ArrayDecoder. I don't need to see another webrev.

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

Thanks Roger, Yes, agree some comment to be explicit about it being the LATIN1 String coding would be good. Are you ok to sponsor please? since Claes and Alan have reviewed. Cheers Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd internet email: andrew_m_leon..

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

ok, I'll sponsor, update the webrev and I'll pick up the changeset from there. Roger On 10/7/19 11:52 AM, Andrew Leonard wrote: Thanks Roger, Yes, agree some comment to be explicit about it being the LATIN1 String coding would be good. Are you ok to sponsor please? since Claes and Alan have

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

Thanks Roger, much appreciated Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd internet email: andrew_m_leon...@uk.ibm.com From: Roger Riggs To: Andrew Leonard Cc: Alan Bateman , Claes Redestad , core-libs-dev@openjdk.java.net Date: 07/10/2019 17:11

RFR: 8231355: Remove unused utility methods in libjava

Hi, please review this patch which removes unused methods and redundant aliases from jni_util and friends in libjava. There's one affected call site in the hotspot runtime code, otherwise this is mainly a java.base-internal cleanup. Bug:https://bugs.openjdk.java.net/browse/JDK-8231355 Webre

RFR: JDK-8231856: pkg installer dialog contains background image which does not look correct

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by using correct icon for pkg. - Added icon for dark theme and it will be called appName-background-darkAqua.png, for separate customization be

Re: RFR: JDK-8231856: pkg installer dialog contains background image which does not look correct

Looks good. - Alexey On 10/7/2019 5:33 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by using correct icon for pkg. - Added icon for dark theme and it will be

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

On 10/5/19 12:09 AM, Peter Levart wrote: Hi Stuart, I also prefer your wording. There's just a nit... + * whether instances the element type are actually serializable. For example, consider ... whether instances *of* the element type(s) are actually ... (there are two element types in the

Re: RFR: 8231355: Remove unused utility methods in libjava

Hi Claes, This all looks good to me! Thanks, David On 8/10/2019 4:38 am, Claes Redestad wrote: Hi, please review this patch which removes unused methods and redundant aliases from jni_util and friends in libjava. There's one affected call site in the hotspot runtime code, otherwise this is m

Re: RFR: 8231584: Deadlock with ClassLoader.findLibrary and System.loadLibrary call

On 10/6/19 9:23 AM, Anton Kozlov wrote: Hi Mandy, On 02.10.2019 01:08, Anton Kozlov wrote:> On 30.09.2019 21:18, Mandy Chung wrote: Skimming through the implementation, it seems to me that the Runtime::loadLibrary0 does not need to be synchronized. ClassLoader::loadLibrary0 should ensure th

Re: RFR: JDK-8231856: pkg installer dialog contains background image which does not look correct

OK - looks fine. /Andy On 10/7/2019 5:33 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by using correct icon for pkg. - Added icon for dark theme and it will

Re: RFR: 8226297: Dual-pivot quicksort improvements

Hi, Vladimir I've read through the changes[1]. I have the following comments: --- src/java.base/share/classes/java/util/Arrays.java * Regarding the indentation changes in the equals() methods: - * {@code new Double(d1).equals(new Double(d2))} + * {@code new Double(d1).equals(new D

Re: RFR: 8231355: Remove unused utility methods in libjava

On Oct 7, 2019, at 11:38 AM, Claes Redestad wrote: > > Bug:https://bugs.openjdk.java.net/browse/JDK-8231355 > > Webrev: http://cr.openjdk.java.net/~redestad/8231355/open.00/ > > > Tes

Re: JDK 14 RFR JDK-8231913: add section on "conditionally serializable" collections

Hi, Per discussion earlier in this thread, Joe had filed https://bugs.openjdk.java.net/browse/JDK-8231913 as an RFE to add this text to the Collection interface spec. Please review the corresponding CSR, which contains the updated, proposed specification text: https://bugs.openjdk.ja