RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux

Ping ... are you fine with the latest version ? Best Regards, Matthias > > Hi Alexey , I like your idea to do the handling in > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java . > > New webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.1/ > > > > Best r

RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux

Hi Matthias, you could improve the patch a bit by starting TKit:: isUbuntu() with if (!isLinux()) { return false; } And then, in PackageType, you could simply do: private final static Set DISABLED_PACKAGERS = Optional.ofNullable( TKit.tokenizeConfigProperty("disabledPackager

Re: [8u] PING: RFR: 8213734: SAXParser.parse(File, ..) does not close resources when Exception occurs.

On 11/10/2019 15:54, Severin Gehwolf wrote: > On Fri, 2019-10-11 at 16:47 +0200, Mario Torre wrote: >> Hi Severin, >> >> The patch looks good to me. > > Thanks for the review, Mario! > > Cheers, > Severin > >> On Fri, Sep 27, 2019 at 10:38 AM Severin Gehwolf wrote: >>> Hi! >>> >>> I'd appreciat

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi Mandy, Thanks again for the review! Updated webrev: incremental (only review changes): http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webrev/ full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/webrev/ More below. On Fri, 2020-02-14 at 18:16 -0800, Man

Re: RFR: 8238953: tools/jpackage tests do not work on Ubuntu Linux

looks good /Andy On 2/14/2020 9:45 AM, Baesken, Matthias wrote: Hi Alexey , I like your idea to do the handling in test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.1/ Best regards, Matthias Date: T

RFR: 8239351: Give more meaningful InternalError messages in Deflater.c

Hello, please review this change to Deflater.c . When running the jtreg test java/util/zip/DeInflate.java , we currently have errors on SLES 15.1 s390x when using the system zlib (1.2.11), while the bundled zlib (of OpenJDK) seems to be okay. What's worse, the error messages are not very meanin

RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux

Ok why not, new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.2/ Thanks, Matthias > > Hi Matthias, > > you could improve the patch a bit by starting TKit:: isUbuntu() with > > if (!isLinux()) { > return false; > } > > And then, in PackageType, you could simply do: > >

RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux

Hi Matthias, Looks good to me now. Cheers Christoph > -Original Message- > From: Baesken, Matthias > Sent: Dienstag, 18. Februar 2020 16:55 > To: Langer, Christoph ; core-libs- > d...@openjdk.java.net; Alexey Semenyuk > Subject: RE: 8238953: tools/jpackage tests do not work on Ubuntu L

Re: JEP 370 - text example leads to exception

On 18/02/2020 03:52, Chris T wrote: Maurizio, thank you for your suggestion! One of my coworkers suggested also using padding instead of keeping a compact/packed memory layout. The reason my example worked was because Java char is 2 bytes and int is 4... So using 16-bit alignment for "creditSc

Re: RFR: 8239351: Give more meaningful InternalError messages in Deflater.c

Thanks for doing this. Looks good to me. I would probably create a tiny helper function to encapsulate the error throw. On Tue, Feb 18, 2020 at 7:03 AM Baesken, Matthias wrote: > Hello, please review this change to Deflater.c . > > When running the jtreg test java/util/zip/DeInflate.java , we c

jpackage runtime binaries

I was wondering if there is any way to include java executable binaries like bin/java. They do not appear to be default included. Looking at help I am not seeing a specific parameter for that purpose. I do see… --runtime-image Path of the predefined runtime image that will be copie

Re: jpackage runtime binaries

I’m using jlink to build my own runtime for exactly this reason. My app needs to launch Java sub-processes, so it needs to be able to find the java executable. Scott > On Feb 18, 2020, at 1:10 PM, Michael Hall wrote: > > I was wondering if there is any way to include java executable binaries

Re: jpackage runtime binaries

With the current options, the only solution for this is to run jlink  separately and used --runtime-image option. I had proposed the enhancement JDK-8219536 to add an option for user defined jlink options. this could also make --bind-serv

Re: jpackage runtime binaries

> On Feb 18, 2020, at 12:53 PM, Andy Herrick wrote: > > > With the current options, the only solution for this is to run jlink > separately and used --runtime-image option. > > I had proposed the enhancement JDK-8219536 > to add an option

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

On 2/18/20 4:50 AM, Severin Gehwolf wrote: Hi Mandy, Thanks again for the review! Updated webrev: incremental (only review changes): http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webrev/ full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/webrev/ Th

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

> On Feb 18, 2020, at 2:00 PM, Mandy Chung wrote: > > > > On 2/18/20 4:50 AM, Severin Gehwolf wrote: >> Hi Mandy, >> >> Thanks again for the review! >> >> Updated webrev: >> incremental (only review changes): >> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webre

RFR: JDK-8238692: MacOS runtime Installer issue

Please review the jpackage fix at [1] for the related issues [2], [3], and [4]. This will basically make pkg type runtime installers work on macosx, while we wait for JDK-8237971 to either fix or disable dmg type runtime installers. /Andy [1] http://cr.openjdk.java.net/~herrick/8238692/webr

Re: RFR: 8239351: Give more meaningful InternalError messages in Deflater.c

I think this looks OK also > On Feb 18, 2020, at 12:50 PM, Martin Buchholz wrote: > > Thanks for doing this. Looks good to me. > I would probably create a tiny helper function to encapsulate the error > throw. > > On Tue, Feb 18, 2020 at 7:03 AM Baesken, Matthias > wrote: > >> Hello, please

Re: RFR: 8239351: Give more meaningful InternalError messages in Deflater.c

I like this too. +1 for factoring out throwing the error. ..Thomas On Tue, Feb 18, 2020 at 6:51 PM Martin Buchholz wrote: > Thanks for doing this. Looks good to me. > I would probably create a tiny helper function to encapsulate the error > throw. > > On Tue, Feb 18, 2020 at 7:03 AM Baesken, M

Re: jpackage runtime binaries

> On Feb 18, 2020, at 12:53 PM, Andy Herrick wrote: > > this could also make --bind-services option obsolete, and allow arbitrary > jlink option to replace the default set we currently use. Curious. I have a java shell application that makes limited use of saving some default settings or ot

Re: RFR: 8235834 IBM-943 charset encoder needs updating

Hi Takiguchi-san, Can you please elaborate the rationale for the change? It looks like IBM943 chaset hasn't changed for a long time, at least from JDK8. Has the mapping definition recently changed? Naoto On 2/17/20 10:23 AM, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug: 

Re: 8238953: tools/jpackage tests do not work on Ubuntu Linux

+1 - Alexey On 2/18/2020 10:56 AM, Langer, Christoph wrote: Hi Matthias, Looks good to me now. Cheers Christoph -Original Message- From: Baesken, Matthias Sent: Dienstag, 18. Februar 2020 16:55 To: Langer, Christoph ; core-libs- d...@openjdk.java.net; Alexey Semenyuk Subject: RE:

RFR (backport CSR): 8239395: Accounting currency format support

Please review the CSR https://bugs.openjdk.java.net/browse/JDK-8239395 for a backport of JDK-8215181 to jdk11u. It’s identical to the original CSR. Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8215181 Original CSR: https://bugs.openjdk.java.net/browse/JDK-8218770 Backport JBS issu

Re: RFR (backport CSR): 8239395: Accounting currency format support

Hi Paul, This looks like a spec change to a Java SE API so would be out of bounds for 11u without a maintenance update of Java SE 11. Naoto, do you agree with that analysis? Thanks, -Joe On 2/18/2020 5:44 PM, Hohensee, Paul wrote: Please review the CSR https://bugs.openjdk.java.net/browse/