[11u] RFR: 8232854: URLClassLoader.close() doesn't close cached JAR file on Windows when load() fails

Hi, Please review the fix to JDK-8232854 for 11u: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8232854 Webrev: http://cr.openjdk.java.net/~akasko/jdk11u/8232854/webrev.00/ Patch is implemented based on a test code included with the Jira issue. It fixes the case, when URLClassLoader is

Re: [11u] RFR: 8232854: URLClassLoader.close() doesn't close cached JAR file on Windows when load() fails

On 01/03/2020 12:03, Alex Kashchenko wrote: Hi, Please review the fix to JDK-8232854 for 11u: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8232854 This issue has not been fixed in the main line (jdk/jdk) yet. It may be that the eventual fix will be in the URL protocol handler. Several

Inconsistencies when creating a Reader from a Path

[Note: I originally sent the below mail to jdk-dev but Alan Bateman suggested to re-post it here] The following 2 ways to construct a `Reader` for a `Path` look very similar (with a slight edge for the first one because it is shorter): ```java Reader reader1 = Files.newBufferedReader(path, Stand

Re: RFR: 8196334: Optimize UUID#fromString

On 2020-02-29 00:58, Ivan Gerasimov wrote: Sounds reasonable. I think the current proposal is clearly a progress, so it looks good. Ok! After discussing it a bit offline, Andriy and I would like to simplify the dash-checking code a bit to make it more clear, as there seems to be no obvious

Re: RFR: 8196334: Optimize UUID#fromString

On 01/03/2020 18:19, Claes Redestad wrote: : After discussing it a bit offline, Andriy and I would like to simplify the dash-checking code a bit to make it more clear, as there seems to be no obvious performance drawback of simplifying to (ch1 == '-' && ...). New webrev: http://cr.openjdk.java.

RE: RFR: removing dead code from jar tool

Hi Adam, Lance, as you've already figured out, attachments sent out to the mailing list will be removed. So it's important to generate webrevs and link to it or, for smaller patches, inline it. 😊 Also, the RFR subject is missing a bug ID. From the URL to the webrev I take the bug ID is JDK-823

Re: RFR: 8196334: Optimize UUID#fromString

On 2020-03-01 20:41, Alan Bateman wrote: On 01/03/2020 18:19, Claes Redestad wrote: : After discussing it a bit offline, Andriy and I would like to simplify the dash-checking code a bit to make it more clear, as there seems to be no obvious performance drawback of simplifying to (ch1 == '-'

Re: RFR: removing dead code from jar tool

Hi Christoph, Let me sort this out and once I do I will push the change for Adam. Best lance > On Mar 1, 2020, at 3:16 PM, Langer, Christoph > wrote: > > Hi Adam, Lance, > > as you've already figured out, attachments sent out to the mailing list will > be removed. So it's important to gener

Re: RFR(S): 8232081: Try to link all classes during dynamic CDS dump

Hi Calvin, On 28/02/2020 4:12 pm, Calvin Cheung wrote: Hi David, On 2/27/20 5:40 PM, David Holmes wrote: Hi Calvin, Ioi, Looking good - comments below. A meta-question: normal application classes are rarely loaded but not linked so I'm a little surprised this is an issue. What is the main

Re: RFR: 8196334: Optimize UUID#fromString

On 01/03/2020 21:05, Claes Redestad wrote: : Filed https://bugs.openjdk.java.net/browse/JDK-8240266 to investigate if we can improve the branch elimination in Character.digit and removed the comment. Also moved parse4Nibbles up before fromString and fixed the redundant FQDN for Array: http://c

Re: RFR: 8196334: Optimize UUID#fromString

On 2020-03-02 08:14, Alan Bateman wrote: http://cr.openjdk.java.net/~redestad/8196334/open.02/ Looks good. Thanks - pushed! /Claes