Re: [15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

Thanks for reviewing, Daniel, Vyom. Hi, Daniel I modified the test as you suggested to cover the potential issue with URIBuilder, many thanks. Updated webrev as below: http://cr.openjdk.java.net/~xyin/8202117/webrev.01/ Regards, Chris > On 13 Mar 2020, at 7:51 PM, Daniel Fuchs wrote: > >

Re: [15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

looks good to me. Vyom On Mon, Mar 16, 2020 at 12:59 PM Chris Yin wrote: > Thanks for reviewing, Daniel, Vyom. > > > Hi, Daniel > > I modified the test as you suggested to cover the potential issue with > URIBuilder, many thanks. Updated webrev as below: > > http://cr.openjdk.java.net/~xyin/8202

Re: Review Request JDK-8240975: Extend NativeLibraries to support explicit unloading

On 13/03/2020 18:16, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240975/webrev.00/ This is a follow-up task for Panama to allow explicit unloading of native library after JDK-8228336.  `NativeLibraries` associated with a class loader has the capability to auto

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

Hi Alex, (and redirecting the thread to net-dev) It looks like a straight forward solution and perhaps the compatibility test could be challenged on the basis of reliance on implementation behavior rather than the spec. But, more important I think is the behavior change of the fix itself and

RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Please review adding pre-generated RMI stub classes to the jdk repo and the removal of make files supporting the specific APIs. It removes a dependency on build time generation invoking RMIC. RMIC was  deprecated in JDK 13 [1]. The source files have been edited to remove or suppress compilation

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hello Roger, There is more to be removed in the makefiles. This file should also be removed: make/CompileInterimRmic.gmk In make/Main.gmk, all the targets concerning rmic needs to be removed as well as any dependencies declared that involves them. Searching for "rmic" should find all relevan

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Erik, I was thinking that was a separate step, but can pull it in. (And there's something in spec.gmk.in.) Roger On 3/16/20 12:22 PM, Erik Joelsson wrote: Hello Roger, There is more to be removed in the makefiles. This file should also be removed: make/CompileInterimRmic.gmk In make/Mai

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

On 16/03/2020 16:02, Roger Riggs wrote: Please review adding pre-generated RMI stub classes to the jdk repo and the removal of make files supporting the specific APIs. It removes a dependency on build time generation invoking RMIC. RMIC was  deprecated in JDK 13 [1]. The source files have been

Re: 8202469 / 8202473: Correct type annotation resolution for class type variables

Looks good to me! I'll see if I can find a sponsor for this. cheers /Joel On Sat, Mar 7, 2020 at 2:15 AM Rafael Winterhalter wrote: > I finally found the time to look at this again, sorry for the delay. > > Thank you for your comments. I had the chance to better look into the > problem and sim

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Alan, Removal of rmic itself is assigned to Stuart with a fixVersion of 15: 8225319 Remove rmic from the set of supported tools I'll see how to test the build-cycle. Thanks, Roger On 3/16/20 1:39 PM, Alan Bateman wrote: On 16/03/2020 16

Re: RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming

Hi Erik, Please review a new webrev that adds the change to remove the interim build parts. (Passes Tier 1-3 of CI testing) http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-1/ Thanks, Roger On 3/16/20 12:22 PM, Erik Joelsson wrote: Hello Roger, There is more to be removed i