Re: JDK-8226810: An other case and a small change suggestion

2020-05-10 Thread Johannes Kuhn
On 09-May-20 1:27, Brent Christian wrote: On 5/7/20 5:50 AM, Alan Bateman wrote: On 07/05/2020 12:37, Johannes Kuhn wrote: : In the end, I don't know what causes the bug, or how I can replicate it. I think I did find a likely suspect. > Good sleuthing. I don't what the conditions are for Ge

Re: RFR: 8244624: Improve handling of JarFile META-INF resources

2020-05-10 Thread Martin Buchholz
Thanks for improving the jar/zip code. I wish I had more time to do the same. My own superficial review only adds one small suggestion: add a comment as to why isSignatureRelated never hits a negative index exception. I still like my ancient "ASCII trick" comment. On Thu, May 7, 2020 at 2:34 PM Cl

Re: RFR: 8244624: Improve handling of JarFile META-INF resources

2020-05-10 Thread Claes Redestad
Hi Martin, On 2020-05-10 21:53, Martin Buchholz wrote: Thanks for improving the jar/zip code. thanks! I wish I had more time to do the same. My own superficial review only adds one small suggestion: add a comment as to why isSignatureRelated never hits a negative index exception. Yes, it's

Re: RFR: 8244624: Improve handling of JarFile META-INF resources

2020-05-10 Thread Martin Buchholz
Looks good to me! On Sun, May 10, 2020 at 2:07 PM Claes Redestad wrote: > Hi Martin, > > On 2020-05-10 21:53, Martin Buchholz wrote: > > Thanks for improving the jar/zip code. > > thanks! > > > I wish I had more time to do the same. > > My own superficial review only adds one small suggestion: >