Hi Yu,
diff -r 216c6baa0564 -r 09736e9e4c38
src/java.base/share/classes/java/util/Properties.java
--- a/src/java.base/share/classes/java/util/Properties.java Sat Jun 20
15:11:19 2020 +0800
+++ b/src/java.base/share/classes/java/util/Properties.java Sat Jun 20
22:27:57 2020 +0800
@@ -1,5 +1,5
Thanks Lance.
I've updated the patch with some extra offline feedback from yourself
and Max.
A new warning is printed with use of the new flag. A warning is also
printed when file posix permissions are detected on resources being
signed. Test updated for that also.
https://cr.openjdk.java.ne
Peter,
Thank you for taking the suggestion for additional test scenarios, improving
coverage, and finding-and-fixing the issues in my hurried test builder (was
only meant as a rough guide/idea).
I agree with Claes, it would be good to include the microbenchmark in
test/micro/..
I think this v
Hi Julia,
Sorry 'bout the rookie mistake. Thanks a lot for the clarification!
Just to confirm, for src/java.base/share/classes/java/util/Properties.java
the copyright should be updated as :
+ * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights
Because 1995 was the year when the
Hi Yu,
Just to confirm, for
src/java.base/share/classes/java/util/Properties.java the copyright
should be updated as :
+ * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights
Because 1995 was the year when the file was added, while 2020 when
this change is made. Correct me if
Hi,
this is a patch fix address several javadoc issues in the foreign memory
API, following some internal reviews (mostly from Brian, thanks!).
The changes are aimed at reordering sections in the doc so that more
advanced concepts are exposed last, and also to fix various issues in
code sampl
Certain users of my software run into problems with HttpClient.newHttpClient()
on JDK 14.0.1 and I don't feel like I can handle it properly without catching
Errors.
Calling said method fails when encountering Selector.open(), which in its
Windows-specific implementation relies on loopback-TCP c
On 22/06/2020 16:39, Sebastian Stenzel wrote:
Certain users of my software run into problems with HttpClient.newHttpClient()
on JDK 14.0.1 and I don't feel like I can handle it properly without catching
Errors.
Calling said method fails when encountering Selector.open(), which in its
Windows-
Hi,
Yes, that report probably should not have been closed as it is
definitely an issue.
I will re-open it.
Michael
On 22/06/2020 16:39, Sebastian Stenzel wrote:
Certain users of my software run into problems with HttpClient.newHttpClient()
on JDK 14.0.1 and I don't feel like I can handle i
HI Sean,
Looks OK based on our exchanges. Thank you for your time on this one!
Best
Lance
> On Jun 22, 2020, at 7:22 AM, Seán Coffey wrote:
>
> Thanks Lance.
>
> I've updated the patch with some extra offline feedback from yourself and Max.
> A new warning is printed with use of the new flag
Great, thanks Julia!
Best regards,
Yu L.
On Mon, Jun 22, 2020 at 9:56 PM Julia Boes wrote:
> Hi Yu,
>
> Just to confirm, for src/java.base/share/classes/java/util/Properties.java
> the copyright should be updated as :
>
> + * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights
>
Looks good.
- Alexey
On 6/19/2020 10:05 PM, alexander.matv...@oracle.com wrote:
http://cr.openjdk.java.net/~almatvee/8225251/webrev.01/
- Expended "import static org.junit.Assert.*" and "import static
jdk.incubator.jpackage.internal.StandardBundlerParam.*".
- Fixed inconsistency between impor
Paul pointed out an issue, off list, where subsequent subranges
could still result in a call to the intrinsic. That is now fixed in-place
and the test amended to cover the scenario.
https://cr.openjdk.java.net/~chegar/8247696/webrev.01/
-Chris.
> On 19 Jun 2020, at 11:56, Chris Hegarty wrote:
>
+1
Paul.
> On Jun 22, 2020, at 10:36 AM, Chris Hegarty wrote:
>
> Paul pointed out an issue, off list, where subsequent subranges
> could still result in a call to the intrinsic. That is now fixed in-place
> and the test amended to cover the scenario.
>
> https://cr.openjdk.java.net/~chegar/82
Certain users of my software run into problems with HttpClient.newHttpClient()
on JDK 14.0.1 and I don't feel like I can handle it properly without catching
Errors.
Calling said method fails when encountering Selector.open(), which in its
Windows-specific implementation relies on loopback-TCP c
On 19/06/2020 10:00, Rahul Yadav wrote:
Thank you Alan, updated webrev.
webrev :
http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html
You've addressed the issues that I pointed out, I don't think I have any
other comments.
-Alan
Looks good, some very minor comment (no need for another round).
MemoryLayout.java
—
146 * That is, the above declaration is identical to the following, more
verbose one:
147 * {@code
148 MemoryLayout taggedValuesWithHole = MemoryLayout.ofSequence(5,
149 MemoryLayout.ofStruct(
150
On 22/06/2020 19:22, Paul Sandoz wrote:
Looks good, some very minor comment (no need for another round).
MemoryLayout.java
—
146 * That is, the above declaration is identical to the following, more
verbose one:
147 * {@code
148 MemoryLayout taggedValuesWithHole = MemoryLayout.ofSeque
Hi Rahul,
Looks good to me as well.
Reviewed.
best regards,
-- daniel
On 19/06/2020 10:00, Rahul Yadav wrote:
Thank you Alan, updated webrev.
webrev :
http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html
- rahul
On 19/06/2020 08:43, Alan Bateman wrote:
On 18/06/2020 2
Please review a couple of trivial fixes for a couple of issues in
java.xml, reported by doclint.
I realize we typically don't touch upstream code, but I'm hoping this is
small enough to
be reasonable.
In the first case, there is an unnecessary `` before a ``.
In the second case, there's a ba
The makefile changes look good to me!
Cheers,
Mikael
> On Jun 16, 2020, at 12:22 PM, Erik Joelsson wrote:
>
> (re-sending this as it doesn't look like it was delivered)
>
> There are a lot of jtreg tests that use temporary files. These temporary
> files add up over time and fill up the glob
21 matches
Mail list logo
