RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

Hi, Bug: https://bugs.openjdk.java.net/browse/JDK-8252204 Webrev: http://cr.openjdk.java.net/~fyang/8252204/webrev.00/ This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. Reference implementation for core SHA-3 transform using ARMv8.2 Crypto Extensions:

Re: RFR: 8252552: DecimalFormat javadoc contains HTML tags in example code

+1 Or, maybe is not needed for code comments -Joe On 8/31/20 10:14 AM, Lance Andersen wrote: Hi Naoto, Looks OK to me. Best Lance On Aug 31, 2020, at 12:22 PM, Naoto Sato wrote: Hello, Please review this simple javadoc fix to: https://bugs.openjdk.java.net/browse/JDK-8252552 The

Re: jpackage: support for environment variables in --java-options

> On Aug 29, 2020, at 3:37 AM, Serban Iordache > wrote: > > Hi, > > Is there a way to pass values from environment variables when using > --java-options? > > It would be nice to be able to write something like this: > --java-options "-DmyAppData=$HOME/.myData” For this couldn’t you just

Re: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

On 8/29/20 1:19 PM, Corey Ashford wrote: Hi Roger, Thanks for your reply and thoughts!  Comments interspersed below: On 8/28/20 10:54 AM, Roger Riggs wrote: ... Comparing with the way that the Base64 encoder was intrinsified, the method that is intrinsified should have a method body that

Re: jpackage: support for environment variables in --java-options

> On Aug 31, 2020, at 3:07 PM, Michael Hall wrote: > > > >> On Aug 29, 2020, at 3:37 AM, Serban Iordache >> wrote: >> >> Hi, >> >> Is there a way to pass values from environment variables when using >> --java-options? >> >> It would be nice to be able to write something like this: >>

Re: RFR: 8252552: DecimalFormat javadoc contains HTML tags in example code

Thanks, Joe! On 8/31/20 12:55 PM, Joe Wang wrote: +1 Or, maybe is not needed for code comments Yes. I just kept it as is, as it seems the comment summarizes what the examples do. Naoto -Joe On 8/31/20 10:14 AM, Lance Andersen wrote: Hi Naoto, Looks OK to me. Best Lance On Aug

jpackage environment variables - OS X

Is there a way on OS X to set these in the Info.plist?

Re: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

On 8/27/20 8:07 AM, Doerr, Martin wrote: I will use __attribute__ ((align(16))) instead of __vector, and make them arrays of 16 unsigned char. Maybe __vectors works as expected, too, now. Whatever we use, I'd appreciate to double-check the alignment e.g. by using gdb. I don't remember what we

Re: [aarch64-port-dev ] RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

On 31/08/2020 07:50, Yangfei (Felix) wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8252204 > Webrev: http://cr.openjdk.java.net/~fyang/8252204/webrev.00/ > > This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto > Extensions. > Reference implementation for

RE: [aarch64-port-dev ] RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

> -Original Message- > From: Andrew Haley [mailto:a...@redhat.com] > Sent: Monday, August 31, 2020 4:41 PM > To: Yangfei (Felix) ; hotspot-compiler- > d...@openjdk.java.net; core-libs-dev@openjdk.java.net > Cc: aarch64-port-...@openjdk.java.net > Subject: Re: [aarch64-port-dev ] RFR:

Re: RFR(L) 8244778 Archive full module graph in CDS

Hi Lois, Thanks for the review. Your comments has led me to discover a couple of pretty serious issues, which hopefully I have fixed. Also the code is cleaner now, with much fewer control-flow changes than the last webrev.

Re: RFR: 8252552: DecimalFormat javadoc contains HTML tags in example code

Hi Naoto, Looks OK to me. Best Lance > On Aug 31, 2020, at 12:22 PM, Naoto Sato wrote: > > Hello, > > Please review this simple javadoc fix to: > > https://bugs.openjdk.java.net/browse/JDK-8252552 > > The proposed diff is inserted here: > > --- > ---

jpackage: support for environment variables in --java-options

Hi, Is there a way to pass values from environment variables when using --java-options? It would be nice to be able to write something like this: --java-options "-DmyAppData=$HOME/.myData" (Instead of using the $ sign, another notation may be more appropriate, in order to not conflict with

RFR: 8252552: DecimalFormat javadoc contains HTML tags in example code

Hello, Please review this simple javadoc fix to: https://bugs.openjdk.java.net/browse/JDK-8252552 The proposed diff is inserted here: --- --- old/src/java.base/share/classes/java/text/DecimalFormat.java 2020-08-31 09:07:22.0 -0700 +++

Re: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

On 8/27/20 8:07 AM, Doerr, Martin wrote: Hi Corey, If I make a requirement, I feel decode0 should check that the requirement is met, and raise some kind of internal error if it isn't. That actually was my first implementation, but I received some comments during an internal review suggesting

Re: [PATCH] Docfix for Unsafe regarding fence methods

Hans, You raise a good point! I was attempting to re-adapt the existing language with the changes I made. I’m going to update this post to an RFR after the Skara update next week and repost (got mixed up on my process). There will be some simplified language that hopefully addresses your