Hi Erik, Magnus, Mikael, Nick, David, and Alan,
thank you for looking into it. I grouped together all the comments in
one response to avoid polluting the mailing lists. Here is an updated
version of the patch which addresses the comments:
http://cr.openjdk.java.net/~avoitylov/webrev.8247589.06/
It would be nice to compare documentation HTML files generated before and after
that patch: there's a possibility of non-local consequences, see JDK-6509045.
-Pavel
> On 3 Sep 2020, at 20:33, Vipin Sharma wrote:
>
> Hi,
>
> Please review and sponsor the fix for replacing @exception with @thro
Oops, wrong issue number. Here's the correct one: JDK-8157682.
> On 4 Sep 2020, at 09:52, Pavel Rappo wrote:
>
> It would be nice to compare documentation HTML files generated before and
> after that patch: there's a possibility of non-local consequences, see
> JDK-6509045.
>
> -Pavel
>
>> O
On 04/09/2020 08:55, Aleksei Voitylov wrote:
:
Tests tools/launcher/Test7029048.java and
tools/launcher/ExecutionEnvironment.java need to change behavior on
systems that alter LD_LIBRARY_PATH (AIX and musl). The alternative we
first considered was to detect the libc of the OS with ldd in the test
On 04/09/2020 10:00, Alan Bateman wrote:
On 04/09/2020 08:55, Aleksei Voitylov wrote:
:
Tests tools/launcher/Test7029048.java and
tools/launcher/ExecutionEnvironment.java need to change behavior on
systems that alter LD_LIBRARY_PATH (AIX and musl). The alternative we
first considered was to dete
On 04/09/2020 05:37, Yumin Qi wrote:
HI, Sundar
Thanks for review.
On 9/3/20 6:34 PM, sundararajan.athijegannat...@oracle.com wrote:
Looks good to me.
Few minor comment:
* traceFileStream (and even the preexisting mainArgument) is accessed
only inside GenerateJLIClassesPlugin. Could be pr
* Daniel Fuchs:
> Hi,
>
> On 02/09/2020 08:19, Florian Weimer wrote:
>> At least one of the bugs was in theory user-visible: the network
>> interface code would return data for an interface that does not actually
>> exist on the system.
>
> WRT NetworkInterface.c, I might support using `strnlen` t
Alan,
in this case I'm leaning towards a new class jdk.test.lib.LibcHelper
with a native implementation which calls (*env)->NewStringUTF(env,
libc), which will be used by the tests which require it. Otherwise we'd
have to specify nativepath for all tests which use
jdk.test.lib.Platform. What do yo
Hello,
currently jdk.internal.misc.Unsafe declares method
allocateUninitializedArray(Class, int) returning uninitialized array of given
type and length.
Allocation of uninitialized arrays is faster especially for larger ones, so we
could use them for cases
when we are sure that created array w
Hi Corey,
The idea I had in mind is refactoring the fast path into the method you
call decodeBlock.
Base64: lines 751-768.
It leaves all the unknown/illegal character handling to the Java code.
And yes, it does not need to handle MIME, except to return on illegal
characters.
The patch is at
Hi, Alan
Thanks. Pushed before saw your email, could not credit you on reviewers.
Thanks
Yumin
On 9/4/20 2:10 AM, Alan Bateman wrote:
On 04/09/2020 05:37, Yumin Qi wrote:
HI, Sundar
Thanks for review.
On 9/3/20 6:34 PM, sundararajan.athijegannat...@oracle.com wrote:
Looks good to me.
Hi Martin,
> On Sep 4, 2020, at 1:14 AM, Martin Buchholz wrote:
>
> Thanks for doing this!
>
> 15 years ago I considered taking on this task, eventually backing away
> because it was too much work (!). But I made sure most of the classes
> I maintained were using @throws.
>
> When considerin
Hi Pavel,
> On Sep 4, 2020, at 2:27 PM, Pavel Rappo wrote:
>
> Oops, wrong issue number. Here's the correct one: JDK-8157682.
>
>> On 4 Sep 2020, at 09:52, Pavel Rappo wrote:
>>
>> It would be nice to compare documentation HTML files generated before and
>> after that patch: there's a possi
Hi,
I have generated Javadoc for all updated packages and compared html files,
before and after changes.
All looks good, only generation time is different in html files.
Regards,
Vipin
> On Sep 5, 2020, at 12:47 AM, Vipin Sharma wrote:
>
> Hi Pavel,
>
>
>> On Sep 4, 2020, at 2:27 PM, Pavel
Alan,
here is a simpler version which, for the two tests in question, refers
to a local helper class with a native method:
http://cr.openjdk.java.net/~avoitylov/webrev.8247589.07/
If there is a preference to avoid JNI, there is yet another alternative:
split the two launcher tests in question in
15 matches
Mail list logo
