Re: JDK 15 hidden classes & stack trace visibility

2020-09-06 Thread Uwe Schindler
Hi Remy, Those classes would get a strong relationship to class loader. So I would like to have the anonymous class features in combination with make them visible in stack traces. The current approach using separate classloader works fine for that as it unloads perfectly (exactly what's discus

Re: RFC: 8229469 JEP 386: Alpine Linux/x64 Port

2020-09-06 Thread Alan Bateman
On 04/09/2020 21:55, Aleksei Voitylov wrote: Alan, here is a simpler version which, for the two tests in question, refers to a local helper class with a native method: http://cr.openjdk.java.net/~avoitylov/webrev.8247589.07/ If there is a preference to avoid JNI, there is yet another alternati

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Kim Barrett
> On Sep 4, 2020, at 7:50 AM, Florian Weimer wrote: > > * Daniel Fuchs: > >> Hi, >> >> On 02/09/2020 08:19, Florian Weimer wrote: >>> At least one of the bugs was in theory user-visible: the network >>> interface code would return data for an interface that does not actually >>> exist on the sy

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Kim Barrett
> On Sep 1, 2020, at 9:59 AM, Eric Liu wrote: > I just tested this patch by GCC (10.1.0) and it would really re-trigger those > warnings :( > I have not noticed the history before, but it's really hard to imagine that > GCC would > have different behaviors. Can you be (very) specific about thi

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)

2020-09-06 Thread Raffaello Giulietti
Hello, FYI I just opened a PR on GitHub for this RFR. Greetings Raffaello On 2020-09-03 00:44, Brian Burkhalter wrote: Good move. ;-) Brian On Sep 2, 2020, at 2:26 PM, Raffaello Giulietti mailto:raffaello.giulie...@gmail.com>> wrote: will do in the next days, hopefully before the trans

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Florian Weimer
* Kim Barrett: >> On Sep 4, 2020, at 7:50 AM, Florian Weimer wrote: >> >> * Daniel Fuchs: >> >>> Hi, >>> >>> On 02/09/2020 08:19, Florian Weimer wrote: At least one of the bugs was in theory user-visible: the network interface code would return data for an interface that does not act

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

2020-09-06 Thread Seán Coffey
Thanks for the review Hai-May. I've implemented all your suggestions. The CSR was approved late on Friday so I'll now submit this via PR on github infra. regards, Sean. On 28/08/2020 21:08, Hai-May Chao wrote: JarSigner.java #953: The output debug message can be removed from the code. JavaU

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Kim Barrett
> On Sep 6, 2020, at 7:35 AM, Kim Barrett wrote: > src/hotspot/share/compiler/compileBroker.hpp > 64 PRAGMA_DIAG_PUSH > 65 PRAGMA_STRINGOP_TRUNCATION_IGNORED > 66 // This code can incorrectly cause a "stringop-truncation" warning > with gcc > 67 strncpy(_current_method, method, (size_

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Kim Barrett
> On Sep 6, 2020, at 7:35 AM, Kim Barrett wrote: > src/java.base/unix/native/libnet/NetworkInterface.c > 1298 memset((char *)&if2, 0, sizeof(if2)); > 1299 strncpy(if2.ifr_name, name, sizeof(if2.ifr_name) - 1); > 1300 if2.ifr_name[sizeof(if2.ifr_name) - 1] = 0; > > (in getIndex) > > S

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Kim Barrett
> On Sep 6, 2020, at 1:03 PM, Florian Weimer wrote: > There is no reason to use strncpy. At least on Linux, the struct field > needs to be null-terminated, and you need to compute the length for the > length check. So you might as well use memcpy with the length plus one > (to copy the null term

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

2020-09-06 Thread Kim Barrett
> On Sep 6, 2020, at 9:51 PM, Kim Barrett wrote: > Oh, good grief! This file contains 3 identical copies of getMTU and > getFlags, one each for linux, AIX, and BSD. And getIndex is kind of a > mess. If changing any of these for linux, probably similar changes > ought to be applied to the other