Re: RFR: 8247781: Day periods support [v9]

On Thu, 5 Nov 2020 23:24:19 GMT, Stephen Colebourne wrote: >> I implemented what you suggested here in the latest PR, but that would be a >> behavioral change which requires a CSR, as "AM" would be resolved to 06:00 >> which was not before. Do you think it would be acceptable? If so, I will

Re: RFR: 8255964: Add all details to jstack log in jtreg timeout handler [v2]

On Fri, 6 Nov 2020 20:25:13 GMT, Nils Eliasson wrote: >> This patch adds jcmd Thread.print to the jtreg timeout handler. >> >> Please review. > > Nils Eliasson has updated the pull request incrementally with one additional > commit since the last revision: > > add extended printing to

Re: RFR: 8180352: Add Stream.toList() method

- Mail original - > De: "Simon Roberts" > À: "core-libs-dev" > Envoyé: Jeudi 5 Novembre 2020 18:40:44 > Objet: Re: RFR: 8180352: Add Stream.toList() method > At the risk of a can of worms, or at least of raising something that has > long since been discussed and rejected... > > This

Re: RFR: 8247781: Day periods support [v7]

On Fri, 6 Nov 2020 03:00:52 GMT, Naoto Sato wrote: >> test/jdk/java/time/tck/java/time/format/TCKDateTimeParseResolver.java line >> 858: >> >>> 856: return new Object[][]{ >>> 857: {STRICT, 0, LocalTime.of(6, 0), 0}, >>> 858: {STRICT, 1, LocalTime.of(18,

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

On Thu, 5 Nov 2020 23:59:43 GMT, Dean Long wrote: > C2 changes look good, except for new code block in > inline_preconditions_checkIndex could use a comment. Thanks for the review. I added a comment for this block and some other comments for the rest of this method. - PR:

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v3]

> This change add 3 new methods in Objects: > > public static long checkIndex(long index, long length) > public static long checkFromToIndex(long fromIndex, long toIndex, long length) > public static long checkFromIndexSize(long fromIndex, long size, long length) > > This mirrors the int utility

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod…

On Fri, 6 Nov 2020 00:24:14 GMT, Hui Shi wrote: >> If we are changing NativeMethodAccessorImpl.invoke then we should probably >> do NativeConstructorAccessorImpl.newInstance at the same time. Also >> wondering if we should, while in the area, add "return acc.invoke(obj, >> args)" after

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v2]

On Fri, 6 Nov 2020 04:25:40 GMT, Dean Long wrote: >> src/hotspot/share/opto/library_call.cpp line 1015: >> >>> 1013: Deoptimization::Action_make_not_entrant); >>> 1014: } >>> 1015: >> >> A comment here explaining what the code below is doing would be helpful. > > This code

RFR: 8255982: Extend BasicJMapTest to test with different GC Heap

The implementation of jmap tool depends on the implementation of object iteration by different GC heap. This patch extend the BasicJMapTest to cover differet GC Heap. - Commit messages: - 8255982: Extend BasicJMapTest to test with different GC Heap Changes:

Re: RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler

On Thu, 5 Nov 2020 17:09:58 GMT, Nils Eliasson wrote: > This patch adds jcmd Thread.print to the jtreg timeout handler. > > Please review. Hi Nils, It looks alright, but could you please elaborate on why we need it when there is already `jstack` action? — Igor - PR:

Integrated: JDK-8254920: Application launched with jpackage produced .exe crashes JVM

On Thu, 29 Oct 2020 17:32:24 GMT, Andy Herrick wrote: > JVM This pull request has now been integrated. Changeset: 952abea4 Author:Andy Herrick URL: https://git.openjdk.java.net/jdk/commit/952abea4 Stats: 115 lines in 4 files changed: 110 ins; 0 del; 5 mod 8254920: Application

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]

> On 5 Nov 2020, at 18:11, Alex Buckley wrote: > > On 11/5/2020 4:45 AM, Jan Lahoda wrote: >> FWIW, a javadoc generated with the current version of the patch: >> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.01/api/index.html > > Allow me to draw people's attention to the PREVIEW

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]

On Thu, 5 Nov 2020 12:43:03 GMT, Jan Lahoda wrote: >> Thanks @jonathan-gibbons for your comments! I've tried to update the code >> based on them, mostly in >> https://github.com/lahodaj/jdk/commit/743f516c660b577035cdda4510a0bb97937fd9b2 >> and >>

Integrated: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags

On Thu, 5 Nov 2020 19:50:14 GMT, Brian Burkhalter wrote: > Please review this change which would replace the use of a system property > and a child process with updated jtreg tags. This pull request has now been integrated. Changeset: 727a69f5 Author:Brian Burkhalter URL:

Re: RFR: 8254354: Add a withInvokeExactBehavior() VarHandle combinator [v9]

On Fri, 30 Oct 2020 15:23:28 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits

Re: RFR: 8180352: Add Stream.toList() method [v2]

> This change introduces a new terminal operation on Stream. This looks like a > convenience method for Stream.collect(Collectors.toList()) or > Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this > method directly on Stream enables it to do what can't easily by done by a

Re: RFR: 8254354: Add a withInvokeExactBehavior() VarHandle combinator [v13]

> Hi, > > This patch adds an asExact() combinator to VarHandle, that will return a new > VarHandle that performs exact type checks, similar to > MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, > which can lead to performance degradation. > > This is implemented

Re: RFR: 8180352: Add Stream.toList() method

>> This discussion of unmodifiable lists brings me back to the thought that >> there would be good client-side reasons for inserting an UnmodifiableList >> interface as a parent of LIst > On Nov 6, 2020, at 1:14 AM, Remi Forax > wrote: > > > This question is asked at

Re: RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler

On Fri, 6 Nov 2020 15:53:35 GMT, Igor Ignatyev wrote: >> This patch adds jcmd Thread.print to the jtreg timeout handler. >> >> Please review. > > Hi Nils, > > It looks alright, but could you please elaborate on why we need it when there > is already `jstack` action? > > — Igor They have the

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]

On Fri, 6 Nov 2020 15:32:16 GMT, Jonathan Gibbons wrote: >> FWIW, a javadoc generated with the current version of the patch: >> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.01/api/index.html >> >> And a specdiff comparing it to the javadoc built from the corresponding >> master: >>

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v11]

> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files

On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters Marked as reviewed by iris

RFR: 8255989: Remove explicitly unascribed authorship from Java source files

This PR proposes to remove 1. JavaDoc `@author` tags with unclear semantics: `@author unascribed|unattributed|unknown` 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters - Commit messages: - Initial commit Changes:

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files

On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters A removed @author tag is a good

Re: RFR: 8247781: Day periods support [v7]

On Thu, 5 Nov 2020 23:49:25 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed typo/grammatical error. > > src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java >

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: 8180352: Add Stream.toList() method

Le 06/11/2020 à 19:00, Alan Snyder a écrit : (…snip…) But a question that deserves ongoing review is whether Java should support immutable collections using a separate type hierarchy (…snip…). Maybe an alternative way (admittedly more difficult) to have immutable collections without

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

On Fri, 6 Nov 2020 21:47:42 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files

On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters Marked as reviewed by mr (Lead).

Re: RFR: 8255989: Remove explicitly unascribed authorship from Java source files

On Fri, 6 Nov 2020 20:11:24 GMT, Pavel Rappo wrote: > This PR proposes to remove > 1. JavaDoc `@author` tags with unclear semantics: `@author > unascribed|unattributed|unknown` > 2. A couple of astray Form Feed (a.k.a. FF, `\f`, `0xC`, or `^L`) characters Marked as reviewed by mchung

Re: RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler [v2]

> This patch adds jcmd Thread.print to the jtreg timeout handler. > > Please review. Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision: add extended printing to jstack - Changes: - all:

Re: RFR: 8247781: Day periods support [v7]

On Fri, 6 Nov 2020 09:12:38 GMT, Stephen Colebourne wrote: >> Did you mean in STRICT mode, HOUR_OF_AMPM should default to 0, and to 6 in >> SMART/LENIENT modes? > > No. I mean that when resolving AMPM/dayPeriod in strict mode, and there is no > HOUR_OF_DAY or HOUR_OF_AMPM, then do not resolve

Re: RFR: 8247781: Day periods support [v8]

> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

RFR: 8233332: Need to create exploded tests covering all forms of modules

822: Need to create exploded tests covering all forms of modules - Commit messages: - 822: Need to create exploded tests covering all forms of modules - 822: Need to create exploded tests covering all forms of modules Changes:

Re: RFR: 8247781: Day periods support [v9]

> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >