Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v6]

2020-11-14 Thread Hui Shi
On Fri, 13 Nov 2020 16:02:42 GMT, Jorn Vernee wrote: >> Thanks all! May this test-request get approved? > > Notice that the `/test` command is currently un-available (some > implementation concerns are still under consideration). As an alternative, > GitHub actions can be used to do basic autom

Re: RFR: 8255883: Avoid multiple GeneratedMethodAccessor for same NativeMethod… [v6]

2020-11-14 Thread Jorn Vernee
On Sat, 14 Nov 2020 07:55:35 GMT, Hui Shi wrote: >> Notice that the `/test` command is currently un-available (some >> implementation concerns are still under consideration). As an alternative, >> GitHub actions can be used to do basic automatic testing when pushes occur. >> >> However, pushes

Re: RFR: 8255883: Avoid duplicated GeneratedMethodAccessor when reflect method invoked from different threads [v6]

2020-11-14 Thread Hui Shi
On Sat, 14 Nov 2020 12:11:52 GMT, Jorn Vernee wrote: >> @JornVernee How can "ready" label be added to this PR? This PR has been >> reviewed. Would you help on this? > > @huishi-hs See the "Integration blocker" section in the PR body; you have a > JBS issue and PR title mismatch. After review P

Re: RFR: 8255883: Avoid duplicated GeneratedMethodAccessor when reflect method invoked from different threads [v7]

2020-11-14 Thread Hui Shi
> …AccessorImpl object > > We met real problem when using protobuf with option optimized for code size, > detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883 > > Optimize solution is adding a new boolean field to detect concurrent method > accessor generation in same NativeMethodAcce

Re: RFR: 8255883: Avoid duplicated GeneratedMethodAccessor when reflect method invoked from different threads

2020-11-14 Thread Hui Shi
On Sat, 14 Nov 2020 07:40:07 GMT, Hui Shi wrote: >> @huishi-hs Testing should start automatically, and will appear here when you >> push to any branch in your fork that is not `master`: >> https://github.com/huishi-hs/jdk/actions (unless you disabled this in the >> repo settings). >> >> As I

Withdrawn: 8255883: Avoid duplicated GeneratedMethodAccessor when reflect method invoked from different threads

2020-11-14 Thread Hui Shi
On Fri, 13 Nov 2020 23:37:46 GMT, Hui Shi wrote: > …ructorAccessorImpl object > > duplicate with https://github.com/openjdk/jdk/pull/1070, try trigger test > with new PR This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1213

RFR: 8253280: Use class name as class loading lock

2020-11-14 Thread Robert LU
When many thread try to load same class, the thread will stuck on `ClassLoader.loadClass`. At current jdk, the stacktrace by example program is: "Thread-1" prio=5 Id=13 BLOCKED on java.lang.String@724af044 owned by "Thread-0" Id=12 at java.base/jdk.internal.loader.BuiltinClassLoader.load

Re: RFR: 8253280: Use class name as class loading lock

2020-11-14 Thread Mandy Chung
On Thu, 10 Sep 2020 05:25:43 GMT, Robert LU wrote: > When many thread try to load same class, the thread will stuck on > `ClassLoader.loadClass`. > At current jdk, the stacktrace by example program is: > "Thread-1" prio=5 Id=13 BLOCKED on java.lang.String@724af044 owned by > "Thread-0" Id=12 >

Re: RFR: 8255947: [macos] Signed macOS jpackage app doesn't filter spurious '-psn' argument

2020-11-14 Thread Guillaume Rischard
On Wed, 11 Nov 2020 04:28:02 GMT, Alexander Matveev wrote: > This is regression from JDK-8242302 and for some reason removing -psn > argument code was removed during refactoring. Fixed be adding removing -psn > argument back. Also, test was added to test this functionality. For bug reproducti

RFR: 8253280: Use class name as class loading lock

2020-11-14 Thread Robert Lu
When many thread try to load same class, the thread will stuck on ClassLoader.loadClass. At current jdk, the stacktrace by example program is: "Thread-1" prio=5 Id=12 BLOCKED on java.lang.Object@2e817b38 owned by "Thread-0" Id=11 at java.base@15/jdk.internal.loader.BuiltinClassLoader.loa

Re: RFR: 8255883: Avoid duplicated GeneratedMethodAccessor when reflect method invoked from different threads [v6]

2020-11-14 Thread Alan Bateman
On Sat, 14 Nov 2020 12:53:26 GMT, Hui Shi wrote: >> @huishi-hs See the "Integration blocker" section in the PR body; you have a >> JBS issue and PR title mismatch. > > After review PR/commit title is changed to align with JBS title to add ready > label Can you sync up your branch (the bot is s

Re: RFR: 8253280: Use class name as class loading lock

2020-11-14 Thread Alan Bateman
Robert, I think you need to start a discussion on serviceability-dev about the diagnostic challenges in this area before proposing API changes to java.lang.management that have wider implications and potential interop issues. It might be that your starting point is the thread dump instead. -