Re: [jdk16] RFR: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition [v3]

2021-01-06 Thread Maurizio Cimadamore
> Hi, > this patch fixes an oversight where the address() method in > FileChannelImpl.Unmapper does not take into account the value of > `pagePosition` - this leads to a situation in which, effectively, the > specified offset when mapping the segment is ignored by the runtime (because > base

Re: Monitoring wrapped ThreadPoolExecutor returned from Executors

2021-01-06 Thread Pavel Rappo
Questions related to the contents of java.util.concurrent.** should generally be asked on the "Concurrency-interest" mailing list: http://altair.cs.oswego.edu/mailman/listinfo/concurrency-interest -Pavel > On 6 Jan 2021, at 03:11, Tommy Ludwig wrote: > > Hello, > > In the Micrometer

Re: [jdk16] RFR: 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes [v2]

2021-01-06 Thread Joel Borggrén-Franck
On Tue, 5 Jan 2021 12:51:17 GMT, Rafael Winterhalter wrote: >> This change avoid that owner types of static nested classes are returned as >> parameterized types. > > Rafael Winterhalter has refreshed the contents of this pull request, and > previous commits have been removed. The incremental

[jdk16] Integrated: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition

2021-01-06 Thread Maurizio Cimadamore
On Tue, 5 Jan 2021 15:33:54 GMT, Maurizio Cimadamore wrote: > Hi, > this patch fixes an oversight where the address() method in > FileChannelImpl.Unmapper does not take into account the value of > `pagePosition` - this leads to a situation in which, effectively, the > specified offset when

Re: [jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl [v2]

2021-01-06 Thread Maurizio Cimadamore
> This patch tweaks `MemorySegment::mapFile` so that it will throw > `IllegalArgumentException` whenever the path to be mapped is associated with > a custom file system provider. > > The check in the implementation is heavily borrowed by what > `UnixDomainSocketAddress::of(Path)` does (thanks

Re: [jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl [v2]

2021-01-06 Thread Chris Hegarty
On Wed, 6 Jan 2021 16:32:17 GMT, Maurizio Cimadamore wrote: >> This patch tweaks `MemorySegment::mapFile` so that it will throw >> `IllegalArgumentException` whenever the path to be mapped is associated with >> a custom file system provider. >> >> The check in the implementation is heavily

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v9]

2021-01-06 Thread Brett Okken
On Mon, 4 Jan 2021 19:52:18 GMT, Jim Laskey wrote: >> This PR is to introduce a new random number API for the JDK. The primary API >> is found in RandomGenerator and RandomGeneratorFactory. Further description >> can be found in the JEP https://openjdk.java.net/jeps/356 . >> >> javadoc can be

Re: [jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl

2021-01-06 Thread Maurizio Cimadamore
On Wed, 6 Jan 2021 16:10:12 GMT, Maurizio Cimadamore wrote: > This patch tweaks `MemorySegment::mapFile` so that it will throw > `IllegalArgumentException` whenever the path to be mapped is associated with > a custom file system provider. > > The check in the implementation is heavily

[jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl

2021-01-06 Thread Maurizio Cimadamore
This patch tweaks `MemorySegment::mapFile` so that it will throw `IllegalArgumentException` whenever the path to be mapped is associated with a custom file system provider. The check in the implementation is heavily borrowed by what `UnixDomainSocketAddress::of(Path)` does (thanks Alan for the

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v12]

2021-01-06 Thread Jim Laskey
On Wed, 6 Jan 2021 16:09:25 GMT, Brett Okken wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct range used by nextBytes > > src/java.base/share/classes/java/util/random/RandomGenerator.java line 147: > >>

Re: [jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl [v2]

2021-01-06 Thread Alan Bateman
On Wed, 6 Jan 2021 16:32:17 GMT, Maurizio Cimadamore wrote: >> This patch tweaks `MemorySegment::mapFile` so that it will throw >> `IllegalArgumentException` whenever the path to be mapped is associated with >> a custom file system provider. >> >> The check in the implementation is heavily

Re: [jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl [v2]

2021-01-06 Thread Maurizio Cimadamore
On Wed, 6 Jan 2021 17:51:20 GMT, Uwe Schindler wrote: > Another option would have been to just check the class with instanceof. If > the FileChannel returned by the path's filesystem has wrong type, it won't > work. If we have some custom filesystem that just returns the original >

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2021-01-06 Thread Jim Laskey
On Thu, 26 Nov 2020 15:41:16 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java >> line 46: >> >>> 44: import java.util.stream.Stream; >>> 45: import jdk.internal.util.random.RandomSupport.RandomGeneratorProperty; >>> 46: >> >> Instead of

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v9]

2021-01-06 Thread Jim Laskey
On Tue, 5 Jan 2021 02:43:08 GMT, Brett Okken wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 34 commits: >> >> - Merge branch 'master' into 8248862 >> - 8248862: Implement Enhanced Pseudo-Random Number

[jdk16] Integrated: 8259075: Update the copyright notice in the files generated by CLDR Converter tool

2021-01-06 Thread Naoto Sato
On Tue, 5 Jan 2021 17:59:01 GMT, Naoto Sato wrote: > Please review this copyright notice update in the CLDR Converter tool. It is > now synched with src/java.base/share/legal/cldr.md file. This pull request has now been integrated. Changeset: 4a5786b5 Author:Naoto Sato URL:

Re: [jdk16] RFR: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl [v2]

2021-01-06 Thread Uwe Schindler
On Wed, 6 Jan 2021 16:32:17 GMT, Maurizio Cimadamore wrote: >> This patch tweaks `MemorySegment::mapFile` so that it will throw >> `IllegalArgumentException` whenever the path to be mapped is associated with >> a custom file system provider. >> >> The check in the implementation is heavily

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v11]

2021-01-06 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2021-01-06 Thread Jim Laskey
On Wed, 6 Jan 2021 15:31:32 GMT, Jim Laskey wrote: >> I kind of like the idea - not sure how expressive a BigInteger string is >> though. I might be able to express as >> BigInteger.ONE.shiftLeft(i).subtract(j).shiftLeft(k). Will ponder. > > Done Also added getDefault and getDefaultFactory

RFR: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

2021-01-06 Thread Martin Balao
As described in JDK-8259319 [1], this fix proposal is to set proper access permissions so the SunPKCS11 provider can create instances of SunJCE classes when a Security Manager is installed and the fallback scheme is used. No regressions found in jdk/sun/security/pkcs11 tests category. -- [1] -

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v12]

2021-01-06 Thread Brett Okken
On Wed, 6 Jan 2021 15:36:21 GMT, Jim Laskey wrote: >> This PR is to introduce a new random number API for the JDK. The primary API >> is found in RandomGenerator and RandomGeneratorFactory. Further description >> can be found in the JEP https://openjdk.java.net/jeps/356 . >> >> javadoc can be

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v6]

2021-01-06 Thread Mahendra Chhipa
> jaxp.library.SimpleHttpServer > https://bugs.openjdk.java.net/browse/JDK-8212035 Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Implemented the review comments - Merge branch 'master' into

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v12]

2021-01-06 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2021-01-06 Thread Brett Okken
On Wed, 25 Nov 2020 14:07:04 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8248862: Implement Enhanced Pseudo-Random Number Generators >> >> Changes to RandomGeneratorFactory requested by

[jdk16] Integrated: 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes

2021-01-06 Thread Rafael Winterhalter
On Tue, 5 Jan 2021 12:03:43 GMT, Rafael Winterhalter wrote: > This change avoid that owner types of static nested classes are returned as > parameterized types. This pull request has now been integrated. Changeset: d25a1bed Author:Rafael Winterhalter Committer: Joel Borggrén-Franck