On Mon, 1 Feb 2021 20:26:54 GMT, Andrew John Hughes wrote:
>> Anybody willing to review this?
>
>> Anybody willing to review this?
>
> I can have a go.
>
> I have two main concerns:
>
> 1. There seems to be little documentation on the new additions. I'm
> particularly concerned about things l
On Wed, 10 Feb 2021 07:46:02 GMT, Michael McMahon wrote:
>> Could I get the following change reviewed please? It fixes a problem (in
>> JEP380) on Windows where some file operations on Unix domain sockets were
>> not working and led to the feature being disabled on Windows 2019 Server in
>> JD
On Thu, 7 Jan 2021 17:09:14 GMT, Claes Redestad wrote:
>> Hi Claes,
>> Would flattening the state of MD5 bring any further improvements?
>> https://github.com/plevart/jdk/commit/92bf48ff58f0ce9648e49466dbf1befebbf49083
>
>> Hi Claes,
>> Would flattening the state of MD5 bring any further improvem
On Mon, 8 Feb 2021 08:49:17 GMT, Aleksey Shipilev wrote:
> SonarCloud instance reports as new warning after JDK-8254702:
>
> This branch can not be reached because the condition duplicates a previous
> condition in the same sequence of "if/else if" statements.
>
> char* getJvmLauncherLibPath(v
On Wed, 10 Feb 2021 14:08:22 GMT, PROgrm_JARvis
wrote:
>>> Hi Claes,
>>> Would flattening the state of MD5 bring any further improvements?
>>> [plevart@92bf48f](https://github.com/plevart/jdk/commit/92bf48ff58f0ce9648e49466dbf1befebbf49083)
>>
>> I think it might, marginally, but it seemed to m
On Mon, 8 Feb 2021 08:49:17 GMT, Aleksey Shipilev wrote:
> SonarCloud instance reports as new warning after JDK-8254702:
>
> This branch can not be reached because the condition duplicates a previous
> condition in the same sequence of "if/else if" statements.
>
> char* getJvmLauncherLibPath(v
On Wed, 10 Feb 2021 07:34:59 GMT, Aleksey Shipilev wrote:
>> `JVM_LatestUserDefinedLoader` is called normally from
>> `ObjectInputStream.resolveClass` -> `VM.latestUserDefinedLoader0`. And it
>> takes a measurable time to walk the stack. There is JDK-8173368 that wants
>> to replace it with `S
This issue adds a new event to improve diagnostic information of Java
deserialization. The event captures the details of deserialization activity
from ObjectInputStream. The event details are similar to that of the serial
filter, but is agnostic of whether a filter is installed or not. The event
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Tue, 9 Feb 2021 14:08:10 GMT, Philippe Marschall
wrote:
>> src/java.base/share/classes/java/io/Reader.java line 198:
>>
>>> 196: } else {
>>> 197: int remaining = target.remaining();
>>> 198: char cbuf[] = new char[Math.min(remaining,
>>> TRANSFER_BUFFER_SIZE
> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB,
> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than
> per-instance auxiliary decoders. Doing so reduce overheads of calling
> `charset.newDecoder()`. This reduce or eliminate regressions on `new
> Stri
On Wed, 10 Feb 2021 23:35:54 GMT, Claes Redestad wrote:
>> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB,
>> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than
>> per-instance auxiliary decoders. Doing so reduce overheads of calling
>> `charset.newDe
8261482: Adjust jmap -histo to accept noparallel option to inspect heap serially
-
Commit messages:
- 8261482: Adjust jmap -histo to accept noparallel option to inspect heap
serially
Changes: https://git.openjdk.java.net/jdk/pull/2519/files
Webrev: https://webrevs.openjdk.java.net
On Thu, 11 Feb 2021 02:36:01 GMT, Lin Zang wrote:
> 8261482: Adjust jmap histo command to accept noparallel option to inspect
> heap serially
Dear All,
Stories and discussions related with this PR could be found at #2379 and
#2261. Just FYI.
BRs,
Lin
-
PR: https://git.openj
On Wed, 10 Feb 2021 02:55:14 GMT, Brian Burkhalter wrote:
>> This is the exact text recommended in java.lang.Comparable when a type's
>> natural ordering is inconsistent with equals. The statement to that effect
>> at the top of BigDecimal didn't use that exact wording
>
> Okay, I see.
The not
On Wed, 10 Feb 2021 01:49:55 GMT, Joe Darcy wrote:
>> A follow-up of sorts to JDK-8257086, this change aims to improve the
>> discussion of the relationship between Object.equals and compareTo and
>> compare methods. The not-consistent-with-equals natural ordering of
>> BigDecimal get more exp
On Thu, 11 Feb 2021 04:24:40 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos in javadoc tags found during review.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 97:
>
>> 95
On Thu, 11 Feb 2021 04:29:11 GMT, Stuart Marks wrote:
>> Okay, I see.
>
> The note itself should be here, but it's demarcated with an `@apiNote` tag.
> This introduces a subhead "API Note:" in the rendered javadoc. Thus, it's not
> necessary to start the text with "Note:".
My thinking here was
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Wed, 10 Feb 2021 15:26:50 GMT, Thomas Stuefe wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added a comment
>
> Looks good. I find it simpler too.
>
> You could run the tests with sun.reflect.inflationThre
23 matches
Mail list logo
