On Fri, 12 Feb 2021 12:49:19 GMT, Severin Gehwolf wrote:
>> Setting reviewers to 2 since I want @gnu-andrew to be OK with it too.
>
> Hi Harold,
>
>> Thanks for doing this! Sorry for taking so long to review this change. The
>> change looks good.
>
> Thanks for the review!
>
>> Before
On Wed, 17 Feb 2021 16:38:03 GMT, Сергей Цыпанов
wrote:
>> Non-static classes hold a link to their parent classes, which in many cases
>> can be avoided.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8261880: Remove
On Fri, 12 Feb 2021 20:27:00 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
>> documentation to use type test pattern instead of instanceof once JEP 375
>> exits preview' ?
>>
>> This change updates the example code
On Fri, 12 Feb 2021 12:49:01 GMT, Severin Gehwolf wrote:
>> This is an enhancement which solves two issues:
>>
>> 1. Multiple reads of relevant cgroup interface files. Now interface files
>> are only read once per file (just like Hotspot).
>> 2. Proxies creation of the impl specific subsystem
On Fri, 12 Feb 2021 20:27:00 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
>> documentation to use type test pattern instead of instanceof once JEP 375
>> exits preview' ?
>>
>> This change updates the example code
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via `determineType()` as
> before, but now reads all relevant
On Wed, 24 Feb 2021 16:24:32 GMT, Andrew John Hughes wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comment to parsing logic of /proc/self/cgroup
>
> Marked as reviewed by andrew (Reviewer).
@gnu-andrew
On Tue, 23 Feb 2021 02:09:01 GMT, Naoto Sato wrote:
> Please review the fix to this test case failure that occurs with the usage
> tracker enabled JRE.
This pull request has now been integrated.
Changeset: 9d9ad969
Author:Naoto Sato
URL:
On Sat, 20 Feb 2021 02:16:49 GMT, Daniel D. Daugherty
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit the exclustion to linux-x64
>
> Changes requested by dcubed (Reviewer).
As the original issue was
On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato wrote:
> The subject test case is failing under the JMS-enabled environment.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/2657
On Mon, 23 Nov 2020 15:46:56 GMT, Severin Gehwolf wrote:
> This is an enhancement which solves two issues:
>
> 1. Multiple reads of relevant cgroup interface files. Now interface files are
> only read once per file (just like Hotspot).
> 2. Proxies creation of the impl specific subsystem via
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java
> test.
Ivan Šipka has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 11 commits:
- 8166026: Refactor java/lang shell tests to java
- 8166026: Refactor
On Wed, 24 Feb 2021 17:37:13 GMT, Severin Gehwolf wrote:
>> Marked as reviewed by andrew (Reviewer).
>
> @gnu-andrew Thanks for the review! I'll retest and then integrate.
Tests look good on my end. Also this check passed all Linux tests (it's a no-op
everywhere else):
Hi Johannes,
Changing Class::arrayType to throw ISA makes sense to me. I think
`TypeDescriptor.ofField::arrayType` spec should also be updated to throw
ISA to follow what JVM checks for array dimension because it's a static
constraint check [1] (rather than a resolution error) for
On Thu, 25 Feb 2021 03:54:35 GMT, Chris Plummer wrote:
> This a new test that runs jstack on a process that is busy doing things. It
> runs jstack 4 times as the process is starting up.
> Sorry but I don't see how this ensures it runs jstack as the jshell is
> starting up, the startup could be
Hi Chris,
On 25/02/2021 1:59 pm, Chris Plummer wrote:
This a new test that runs jstack on a process that is busy doing things. It
runs jstack 4 times as the process is starting up.
Sorry but I don't see how this ensures it runs jstack as the jshell is
starting up, the startup could be
The javadoc of InputStream#readAllBytes() states[1] that it reads all
the remaining bytes of the stream. The java.util.zip.ZipInputStream
doesn't override this method and thus "inherits" this javadoc. The
implementation of InputStream#readAllBytes() ultimately ends up calling
This a new test that runs jstack on a process that is busy doing things. It
runs jstack 4 times as the process is starting up.
-
Commit messages:
- Fix @bug
- Add JStackStressTest
Changes: https://git.openjdk.java.net/jdk/pull/2720/files
Webrev:
18 matches
Mail list logo