Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v4]

2021-02-24 Thread Andrew John Hughes
On Fri, 12 Feb 2021 12:49:19 GMT, Severin Gehwolf wrote: >> Setting reviewers to 2 since I want @gnu-andrew to be OK with it too. > > Hi Harold, > >> Thanks for doing this! Sorry for taking so long to review this change. The >> change looks good. > > Thanks for the review! > >> Before

Re: RFR: 8261880: Change nested classes in java.base to static nested classes where possible [v2]

2021-02-24 Thread Alan Bateman
On Wed, 17 Feb 2021 16:38:03 GMT, Сергей Цыпанов wrote: >> Non-static classes hold a link to their parent classes, which in many cases >> can be avoided. > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8261880: Remove

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v7]

2021-02-24 Thread Stuart Marks
On Fri, 12 Feb 2021 20:27:00 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my changeset for JDK-8252399: 'Update mapMulti >> documentation to use type test pattern instead of instanceof once JEP 375 >> exits preview' ? >> >> This change updates the example code

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-24 Thread Andrew John Hughes
On Fri, 12 Feb 2021 12:49:01 GMT, Severin Gehwolf wrote: >> This is an enhancement which solves two issues: >> >> 1. Multiple reads of relevant cgroup interface files. Now interface files >> are only read once per file (just like Hotspot). >> 2. Proxies creation of the impl specific subsystem

Re: RFR: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview [v7]

2021-02-24 Thread Paul Sandoz
On Fri, 12 Feb 2021 20:27:00 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my changeset for JDK-8252399: 'Update mapMulti >> documentation to use type test pattern instead of instanceof once JEP 375 >> exits preview' ? >> >> This change updates the example code

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v6]

2021-02-24 Thread Severin Gehwolf
> This is an enhancement which solves two issues: > > 1. Multiple reads of relevant cgroup interface files. Now interface files are > only read once per file (just like Hotspot). > 2. Proxies creation of the impl specific subsystem via `determineType()` as > before, but now reads all relevant

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-24 Thread Severin Gehwolf
On Wed, 24 Feb 2021 16:24:32 GMT, Andrew John Hughes wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment to parsing logic of /proc/self/cgroup > > Marked as reviewed by andrew (Reviewer). @gnu-andrew

Integrated: 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null"

2021-02-24 Thread Naoto Sato
On Tue, 23 Feb 2021 02:09:01 GMT, Naoto Sato wrote: > Please review the fix to this test case failure that occurs with the usage > tracker enabled JRE. This pull request has now been integrated. Changeset: 9d9ad969 Author:Naoto Sato URL:

Re: RFR: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java [v2]

2021-02-24 Thread Naoto Sato
On Sat, 20 Feb 2021 02:16:49 GMT, Daniel D. Daugherty wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Limit the exclustion to linux-x64 > > Changes requested by dcubed (Reviewer). As the original issue was

Withdrawn: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java

2021-02-24 Thread Naoto Sato
On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato wrote: > The subject test case is failing under the JMS-enabled environment. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2657

Integrated: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2021-02-24 Thread Severin Gehwolf
On Mon, 23 Nov 2020 15:46:56 GMT, Severin Gehwolf wrote: > This is an enhancement which solves two issues: > > 1. Multiple reads of relevant cgroup interface files. Now interface files are > only read once per file (just like Hotspot). > 2. Proxies creation of the impl specific subsystem via

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v12]

2021-02-24 Thread Ivan Šipka
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java > test. Ivan Šipka has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - 8166026: Refactor java/lang shell tests to java - 8166026: Refactor

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-24 Thread Severin Gehwolf
On Wed, 24 Feb 2021 17:37:13 GMT, Severin Gehwolf wrote: >> Marked as reviewed by andrew (Reviewer). > > @gnu-andrew Thanks for the review! I'll retest and then integrate. Tests look good on my end. Also this check passed all Linux tests (it's a no-op everywhere else):

Re: JDK-8262003: Class.arrayType should not throw IllegalArgumentException

2021-02-24 Thread Mandy Chung
Hi Johannes, Changing Class::arrayType to throw ISA makes sense to me.   I think `TypeDescriptor.ofField::arrayType` spec should also be updated to throw ISA to follow what JVM checks for array dimension because it's a static constraint check [1] (rather than a resolution error) for

Re: RFR: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread

2021-02-24 Thread Chris Plummer
On Thu, 25 Feb 2021 03:54:35 GMT, Chris Plummer wrote: > This a new test that runs jstack on a process that is busy doing things. It > runs jstack 4 times as the process is starting up. > Sorry but I don't see how this ensures it runs jstack as the jshell is > starting up, the startup could be

Re: RFR: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread

2021-02-24 Thread David Holmes
Hi Chris, On 25/02/2021 1:59 pm, Chris Plummer wrote: This a new test that runs jstack on a process that is busy doing things. It runs jstack 4 times as the process is starting up. Sorry but I don't see how this ensures it runs jstack as the jshell is starting up, the startup could be

ZipInputStream#readAllBytes should clarify it doesn't read the whole stream?

2021-02-24 Thread Jaikiran Pai
The javadoc of InputStream#readAllBytes() states[1] that it reads all the remaining bytes of the stream. The java.util.zip.ZipInputStream doesn't override this method and thus "inherits" this javadoc. The implementation of InputStream#readAllBytes() ultimately ends up calling

RFR: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread

2021-02-24 Thread Chris Plummer
This a new test that runs jstack on a process that is busy doing things. It runs jstack 4 times as the process is starting up. - Commit messages: - Fix @bug - Add JStackStressTest Changes: https://git.openjdk.java.net/jdk/pull/2720/files Webrev: