Re: RFR: 8260265: UTF-8 by Default [v6]

On Wed, 21 Jul 2021 17:34:15 GMT, Naoto Sato wrote: >> This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of >> the changes is `Charset.defaultCharset()` returning `UTF-8` and >> `file.encoding` system property being added in the spec, but another notable >> modification i

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v5]

On Fri, 16 Jul 2021 06:14:07 GMT, Matthias Baesken wrote: >> Hello, please review this PR; it extend the OSContainer API in order to also >> support the pids controller of cgroups. >> >> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", >> "memory" on some older Linux di

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v6]

> Hello, please review this PR; it extend the OSContainer API in order to also > support the pids controller of cgroups. > > I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", > "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids > controller might not be t

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v8]

On Wed, 21 Jul 2021 04:09:23 GMT, Jaikiran Pai wrote: > > > For some context - the new `FileRolloverOutputStream` extends > > > `ByteArrayOutputStream` and hence cannot have a `throws IOException` in > > > its overridden `write` methods. > > > > > > Have you tried wrapping a BAOS rather than

jpackage OS/X JDK-8263157 fix regressed out

JDK-8263157 [macos]: java.library.path is being set incorrectly The fix for this seems to be gone in both current jdk17 and jdk18 releases. There is no ‘app’ directory included in java.library.path. outputdir/HalfPipe.app/Contents/runtime/Conte

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v8]

Hello, > So although you can transfer the contents to the file without requiring the > access > to the byte array, you end up creating a new copy of that array (through the > use > of `baos.toByteArray()`) You can avoid the copy and the additional buffer with baos.writeTo() I think. try (Outpu

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v5]

On Thu, 22 Jul 2021 12:15:03 GMT, Matthias Baesken wrote: >> Matthias Baesken has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v8]

Hello Bernd, On 22/07/21 8:54 pm, Bernd Eckenfels wrote: Hello, So although you can transfer the contents to the file without requiring the access to the byte array, you end up creating a new copy of that array (through the use of `baos.toByteArray()`) You can avoid the copy and the addition

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v9]

> Can I please get a review for this proposed fix for the issue reported in > https://bugs.openjdk.java.net/browse/JDK-8190753? > > The commit here checks for the size of the zip entry before trying to create > a `ByteArrayOutputStream` for that entry's content. A new jtreg test has been > incl

Re: JNI WeakGlobalRefs

You might also consider bringing this to panama-dev, since that will eventually be the recommended replacement for most uses of JNI. On 7/21/2021 6:25 PM, David Holmes wrote: Hi Hans, On 22/07/2021 7:54 am, Hans Boehm wrote: Is this an appropriate list to discuss JNI? No - hotspot-dev (to g

Re: jpackage OS/X JDK-8263157 fix regressed out

The fix for JDK-8263157 cleared the default value of `java.library.path` system property and resulted in JDK-8267598 regression. So the fix for JDK-8263157 was reworked: jpackage doesn't set `java.library.path` system property, but it adds `app` directory to `DYLD_LIBRARY_PATH` env variable on

Re: jpackage OS/X JDK-8263157 fix regressed out

> On Jul 22, 2021, at 12:29 PM, Alexey Semenyuk > wrote: > > The fix for JDK-8263157 cleared the default value of `java.library.path` > system property and resulted in JDK-8267598 regression. So the fix for > JDK-8263157 was reworked: jpackage doesn't set `java.library.path` system > prope

Re: jpackage OS/X JDK-8263157 fix regressed out

Why is a directory named “app” used for dynamic libraries instead of the conventional directory “Frameworks”? Alan > On Jul 22, 2021, at 11:04 AM, Michael Hall wrote: > > > >> On Jul 22, 2021, at 12:29 PM, Alexey Semenyuk >> wrote: >> >> The fix for JDK-8263157 cleared the default val

Re: [External] : Re: jpackage OS/X JDK-8263157 fix regressed out

Oh, inconsistent path separators indeed. Good catch! This is the reason it doesn't work as it should. Filed https://bugs.openjdk.java.net/browse/JDK-8271155 to track it. - Alexey On 7/22/2021 2:04 PM, Michael Hall wrote: On Jul 22, 2021, at 12:29 PM, Alexey Semenyuk wrote: The fix for JD

Re: [External] : Re: jpackage OS/X JDK-8263157 fix regressed out

> On Jul 22, 2021, at 1:46 PM, Alexey Semenyuk > wrote: > > Oh, inconsistent path separators indeed. Good catch! This is the reason it > doesn't work as it should. > Filed https://bugs.openjdk.java.net/browse/JDK-8271155 to track it. > > - Alexey > > Thank you.

Re: [External] : Re: jpackage OS/X JDK-8263157 fix regressed out

There is no corresponding folder on other platforms, so to simplify packaging "app" directory is used on all platforms. - Alexey On 7/22/2021 2:42 PM, Alan Snyder wrote: Why is a directory named “app” used for dynamic libraries instead of the conventional directory “Frameworks”? Alan

Integrated: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used

On Fri, 18 Jun 2021 22:46:24 GMT, Alexey Semenyuk wrote: > GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin" > component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath() > looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so" > string

Re: RFR: 8075806: divideExact is missing in java.lang.Math [v5]

> Please consider this proposal to add `divideExact()` methods for integral > data types to `java.lang.Math` thereby rounding out "exact" support to all > four basic arithmetic operations. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values [v2]

On Wed, 14 Jul 2021 16:43:48 GMT, Brian Burkhalter wrote: >> Please consider this proposal to add some test coverage comparing `Math` and >> `StrictMath` results of `pow()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: >

Re: [jdk17] RFR: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

On Mon, 19 Jul 2021 21:18:42 GMT, Joe Darcy wrote: > Given changes in JLS 9.6.4.1, JDK-8261610 in Java SE 17, the statements about > annotation applicability made in java.lang.annotation.Target need to be > updated to match. > > Please also review the corresponding CSR: > https://bugs.openjdk

[jdk17] RFR: 8271155: Wrong path separator in env variable

Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' dir to env variable in jpackage app launcher. - Commit messages: - 8271155: Wrong path separator in env variable Changes: https://git.openjdk.java.net/jdk17/pull/271/files Webrev: https://webrevs.openjdk.

Re: [jdk17] RFR: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

On Mon, 19 Jul 2021 21:18:42 GMT, Joe Darcy wrote: > Given changes in JLS 9.6.4.1, JDK-8261610 in Java SE 17, the statements about > annotation applicability made in java.lang.annotation.Target need to be > updated to match. > > Please also review the corresponding CSR: > https://bugs.openjdk

Re: [jdk17] RFR: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

On Mon, 19 Jul 2021 21:18:42 GMT, Joe Darcy wrote: > Given changes in JLS 9.6.4.1, JDK-8261610 in Java SE 17, the statements about > annotation applicability made in java.lang.annotation.Target need to be > updated to match. > > Please also review the corresponding CSR: > https://bugs.openjdk

[jdk17] Integrated: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

On Mon, 19 Jul 2021 21:18:42 GMT, Joe Darcy wrote: > Given changes in JLS 9.6.4.1, JDK-8261610 in Java SE 17, the statements about > annotation applicability made in java.lang.annotation.Target need to be > updated to match. > > Please also review the corresponding CSR: > https://bugs.openjdk

Re: [jdk17] RFR: 8271155: Wrong path separator in env variable

On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote: > Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' > dir to env variable in jpackage app launcher. Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/271

Re: RFR: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values [v2]

On Wed, 14 Jul 2021 16:43:48 GMT, Brian Burkhalter wrote: >> Please consider this proposal to add some test coverage comparing `Math` and >> `StrictMath` results of `pow()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: >

Re: [jdk17] RFR: 8271155: Wrong path separator in env variable

On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote: > Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' > dir to env variable in jpackage app launcher. Looks good. Is there a unit test associated with this? If not, do you think one would be useful?

Integrated: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values

On Mon, 12 Jul 2021 19:39:13 GMT, Brian Burkhalter wrote: > Please consider this proposal to add some test coverage comparing `Math` and > `StrictMath` results of `pow()`. This pull request has now been integrated. Changeset: 1362e094 Author:Brian Burkhalter URL: https://git.openjd

Re: RFR: 8075806: divideExact is missing in java.lang.Math [v5]

On Thu, 22 Jul 2021 19:40:46 GMT, Brian Burkhalter wrote: >> Please consider this proposal to add `divideExact()` methods for integral >> data types to `java.lang.Math` thereby rounding out "exact" support to all >> four basic arithmetic operations. > > Brian Burkhalter has updated the pull req

Re: [jdk17] RFR: 8271155: Wrong path separator in env variable

On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote: > Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' > dir to env variable in jpackage app launcher. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/271

Re: RFR: 8075806: divideExact is missing in java.lang.Math [v6]

> Please consider this proposal to add `divideExact()` methods for integral > data types to `java.lang.Math` thereby rounding out "exact" support to all > four basic arithmetic operations. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8214761: Bug in parallel Kahan summation implementation [v2]

On Wed, 21 Jul 2021 20:19:31 GMT, Ian Graves wrote: >> 8214761: Bug in parallel Kahan summation implementation > > Ian Graves has updated the pull request incrementally with three additional > commits since the last revision: > > - Updates with more test coverage > - stashing > - Stashing C

Re: [jdk17] RFR: 8271155: Wrong path separator in env variable

On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote: > Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' > dir to env variable in jpackage app launcher. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/271

[jdk17] Integrated: 8271155: Wrong path separator in env variable

On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote: > Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' > dir to env variable in jpackage app launcher. This pull request has now been integrated. Changeset: 7165b3f1 Author:Alexey Semenyuk URL: https:/

Re: [jdk17] RFR: 8271155: Wrong path separator in env variable

On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote: > Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app' > dir to env variable in jpackage app launcher. There is no unit test covering this area. I'll file follow up CR to add one in JDK18. - PR: http

RFR: Merge jdk17

Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode - 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code - 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java

Integrated: Merge jdk17

On Fri, 23 Jul 2021 00:28:53 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 9935440e Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/9935440eded25b041ea3e73cfa8ac0d95bbd66c6 Stats: 268 l

RFR: 8271147: java/nio/file/Path.java javadoc typo

Can I please get a review for this change which fixes the typo noted in https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked fine and the generated javadoc looks fine. - Commit messages: - 8271147: java/nio/file/Path.java javadoc typo Changes: https://git.ope

Re: RFR: 8271147: java/nio/file/Path.java javadoc typo

On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes the typo noted in > https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked > fine and the generated javadoc looks fine. Marked as reviewed by iris (Reviewer).

Integrated: 8271147: java/nio/file/Path.java javadoc typo

On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes the typo noted in > https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked > fine and the generated javadoc looks fine. This pull request has now been integrated.

Re: RFR: 8271147: java/nio/file/Path.java javadoc typo

On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes the typo noted in > https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked > fine and the generated javadoc looks fine. Thank you for the review, Iris. ---

jpackage - override postinstall script (Mac OS PKG)

Is it possible to replace the postinstall (pre too, if needed) script created by jpackage for the PKG installer on Mac OS ?

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v6]

On Thu, 22 Jul 2021 12:18:20 GMT, Matthias Baesken wrote: >> Hello, please review this PR; it extend the OSContainer API in order to also >> support the pids controller of cgroups. >> >> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", >> "memory" on some older Linux di