Re: RFR: JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable

2021-09-25 Thread Iris Clark
On Fri, 24 Sep 2021 23:07:33 GMT, Mandy Chung wrote: > GenGraphs tool generates the module graph. It currently supports the > configuration via javadoc-graphs.properties. However, > `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only > documents two properties. It should b

Re: RFR: 8274293: [macos] Build failure with Xcode 13.0 due to vfork is deprecated [v2]

2021-09-25 Thread Alan Bateman
On Sat, 25 Sep 2021 01:48:29 GMT, xpbob wrote: >> remove vfork() on Darwin > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Drop drop "Solaris" from the comment I think this looks okay but would be good for @RogerRiggs to also re

Re: RFR: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated [v2]

2021-09-25 Thread Thomas Stuefe
On Sat, 25 Sep 2021 01:48:29 GMT, xpbob wrote: >> remove vfork() on Darwin > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Drop drop "Solaris" from the comment The JDK change is fine. AFAICS we have used posix_spawn by default o

RFR: 8274299: Make Method/Constructor/Field accessors @Stable

2021-09-25 Thread Peter Levart
This patch improves reflective access speed as shown by the included benchmarks: https://jmh.morethan.io/?gists=902f4b43519c4f96c7abcd14cdc2d27d,ac490481e3001c710d75d6071c10b23a ... and is also a prerequisite to make JEP 416 (Reimplement Core Reflection with Method Handle) perform better in some

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v2]

2021-09-25 Thread Lance Andersen
On Sep 23, 2021, at 2:28 AM, Jaikiran Pai mailto:j...@openjdk.java.net>> wrote: On Fri, 17 Sep 2021 12:54:07 GMT, Jaikiran Pai mailto:j...@openjdk.org>> wrote: The commit here is a potential fix for the issue noted in https://bugs.openjdk.java.net/browse/JDK-8258117. The change here repurp

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v2]

2021-09-25 Thread Jaikiran Pai
On 25/09/21 4:17 pm, Lance Andersen wrote: Hi Jaikiran This is on my todo list, sorry for the delay. Hoping we can get a couple additional eyes on this as well. Thank you Lance. Please take your time. -Jaikiran

Re: RFR: 8266936: Add a finalization JFR event [v13]

2021-09-25 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and mit

Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-09-25 Thread Markus Grönlund
On Fri, 24 Sep 2021 22:31:18 GMT, Mandy Chung wrote: > > > Hi Markus, > > It's a little surprised to see Finalizer.c to depend JMM interface which is > used by `java.management` and `jdk.management` modules only. It's more > appropriate for it to be a JVM_* entry point for Finalizer to repor

Re: RFR: 8266936: Add a finalization JFR event [v14]

2021-09-25 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and mit

Re: RFR: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated [v2]

2021-09-25 Thread Thomas Stuefe
On Sat, 25 Sep 2021 01:48:29 GMT, xpbob wrote: >> remove vfork() on Darwin > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Drop drop "Solaris" from the comment .. I opened https://bugs.openjdk.java.net/browse/JDK-8274320 to trac

Re: RFR: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated [v2]

2021-09-25 Thread Roger Riggs
On Sat, 25 Sep 2021 01:48:29 GMT, xpbob wrote: >> remove vfork() on Darwin > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Drop drop "Solaris" from the comment Looks good, vfork is not/was not being used on Mac OS.