This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
which caused some unknown failures in Oracle's CI.
-
Commit messages:
- 8275262: Backout JDK-8269559
Changes: https://git.openjdk.java.net/jdk/pull/5941/files
Webrev:
On Thu, 14 Oct 2021 06:37:19 GMT, Nick Gasson wrote:
> This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
> which caused some unknown failures in Oracle's CI.
Thanks for attending to this so quickly @nick-arm !
The issue is only on (some of) our macOS Aarch64 systems.
On 14/10/2021 4:55 pm, Nick Gasson wrote:
On Thu, 14 Oct 2021 06:48:18 GMT, David Holmes wrote:
This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
which caused some unknown failures in Oracle's CI.
Thanks for attending to this so quickly @nick-arm !
The issue is
On Thu, 14 Oct 2021 06:37:19 GMT, Nick Gasson wrote:
> This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
> which caused some unknown failures in Oracle's CI.
Lgtm.
-
Marked as reviewed by tschatzl (Reviewer).
PR:
On 14/10/2021 4:28 pm, Nick Gasson wrote:
On Thu, 14 Oct 2021 01:17:17 GMT, TatWai Chong wrote:
This patch implements string_compare intrinsic in SVE.
It supports all LL, LU, UL and UU comparisons.
As we haven't found an existing benchmark to measure performance impact,
we created a
On Thu, 14 Oct 2021 01:17:17 GMT, TatWai Chong wrote:
>> This patch implements string_compare intrinsic in SVE.
>> It supports all LL, LU, UL and UU comparisons.
>>
>> As we haven't found an existing benchmark to measure performance impact,
>> we created a benchmark derived from the test [1]
On Thu, 14 Oct 2021 00:54:57 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/jdk/internal/reflect/MethodHandleAccessorFactory.java
>> line 151:
>>
>>> 149: var setter = isReadOnly ? null :
>>> JLIA.unreflectField(field, true);
>>> 150: Class type =
We are seeing a large number of Aarch64 test failures in our CI after
this push. Somewhat bizarre failure modes:
- truncated classfiles
- unexpected EOF encountered
- illegal state reading a stream
I think we will need to back this change out while this is investigated
further.
David
-
On Thu, 14 Oct 2021 06:48:18 GMT, David Holmes wrote:
>> This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
>> which caused some unknown failures in Oracle's CI.
>
> Thanks for attending to this so quickly @nick-arm !
>
> The issue is only on (some of) our macOS Aarch64
On Thu, 14 Oct 2021 08:24:41 GMT, Andrew Haley wrote:
> > The issue is only on (some of) our macOS Aarch64 systems. Let me know if I
> > can provide more info on hardware etc.
>
> Any info about what failed? A reproducer would be nice.
I just ran tier1 on an M1 Mac with no failures - perhaps
On Thu, 14 Oct 2021 01:46:31 GMT, Mitsuru Kariya wrote:
> Sorry for my very slow response.
No problem at all. I was delayed in getting the CSR created and finalized.
> These `{@code bytes}` point to the `bytes` argument, but should I change it
> to `{@code byte}s`?
Yes please make that minor
On Thu, 14 Oct 2021 06:37:19 GMT, Nick Gasson wrote:
> This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
> which caused some unknown failures in Oracle's CI.
It might be a spurious failure, then. I guess we need to see the test logs.
-
PR:
On Thu, 14 Oct 2021 09:31:11 GMT, Andrew Haley wrote:
> It might be a spurious failure, then. I guess we need to see the test logs.
I'll revert it for in now in case we missed something.
-
PR: https://git.openjdk.java.net/jdk/pull/5941
On Thu, 14 Oct 2021 06:37:19 GMT, Nick Gasson wrote:
> This reverts "8269559: AArch64: Implement string_compare intrinsic in SVE"
> which caused some unknown failures in Oracle's CI.
This pull request has now been integrated.
Changeset: 333c4692
Author:Nick Gasson
URL:
On 14/10/2021 07:05, Rémi Forax wrote:
On Thu, 14 Oct 2021 00:54:57 GMT, Mandy Chung wrote:
src/java.base/share/classes/jdk/internal/reflect/MethodHandleAccessorFactory.java
line 151:
149: var setter = isReadOnly ? null : JLIA.unreflectField(field,
true);
150:
On Thu, 14 Oct 2021 10:21:20 GMT, David Holmes wrote:
> See https://bugs.openjdk.java.net/browse/JDK-8275263 for some info on the
> failures. It seems really bizarre.
I would understand this a lot better if the affected machines actually used
SVE, but they don't have the hardware.
That does
On 14/10/2021 6:27 pm, Andrew Haley wrote:
On Thu, 14 Oct 2021 07:08:20 GMT, David Holmes wrote:
The issue is only on (some of) our macOS Aarch64 systems. Let me know if I can
provide more info on hardware etc.
Any info about what failed? A reproducer would be nice.
See
On Thu, 14 Oct 2021 07:08:20 GMT, David Holmes wrote:
> The issue is only on (some of) our macOS Aarch64 systems. Let me know if I
> can provide more info on hardware etc.
Any info about what failed? A reproducer would be nice.
-
PR: https://git.openjdk.java.net/jdk/pull/5941
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Marked as reviewed by iris (Reviewer).
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote:
> Remove 3 unused HashMap's.
> Reported here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html
> I did the similar PR to treetenbp and it was merged
> https://github.com/ThreeTen/threetenbp/pull/155
On Wed, 13 Oct 2021 23:53:17 GMT, Maurizio Cimadamore
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup. Improve javadoc in CallerSensitiveAdapter
>
>
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Marked as reviewed by mchung (Reviewer).
On Sun, 10 Oct 2021 20:25:43 GMT, Joe Darcy wrote:
> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
> of the serialization feature. These classes contain brief descriptions of
> some of the methods serializable classes can define to interact with the
>
On Thu, 14 Oct 2021 15:04:23 GMT, Daniel Fuchs wrote:
> The update on the throws declaration in the test is a bit of a distraction.
Right, should have mentioned that the only relevant change _in the test_ is on
line 253, the rest is cleanup.
-
PR:
Fixing a regression in which `file.encoding` was initialized by
`sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
platforms. tier1-3 tests passed on all platforms.
-
Commit messages:
- 8275145: file.encoding system property has an incorrect value on Windows
It'd be useful to have a -version option for keytool and jarsigner. Many other
JDK tools already have a -version option. This is to add -version option to
keytool and jarsigner like jar command does.
-
Commit messages:
- 8272163: Add -version option to keytool and jarsigner
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote:
> Remove 3 unused HashMap's.
> Reported here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html
> I did the similar PR to treetenbp and it was merged
> https://github.com/ThreeTen/threetenbp/pull/155
On Thu, 14 Oct 2021 14:47:28 GMT, Roger Riggs wrote:
>> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
>> of the serialization feature. These classes contain brief descriptions of
>> some of the methods serializable classes can define to interact with the
>>
On Thu, 14 Oct 2021 14:44:34 GMT, Julia Boes wrote:
> sun.reflect.ReflectionFactory provides MethodHandles for the various
> serialization methods, it is a critical internal API in the jdk.unsupported
> module (see JEP 260 [1]) that may be used by 3rd party serialization
> libraries.
>
>
sun.reflect.ReflectionFactory provides MethodHandles for the various
serialization methods, it is a critical internal API in the jdk.unsupported
module (see JEP 260 [1]) that may be used by 3rd party serialization libraries.
One of these serialization methods is readObjectNoData [2]:
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Marked as reviewed by alanb (Reviewer).
On Thu, 14 Oct 2021 17:21:25 GMT, Paul Sandoz wrote:
>> This PR improves the performance of vector operations that accept masks on
>> architectures that support masking in hardware, specifically Intel AVX512
>> and ARM SVE.
>>
>> On architectures that do not support masking in hardware the
On Wed, 13 Oct 2021 18:53:22 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For
On Thu, 14 Oct 2021 19:36:02 GMT, Mandy Chung wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor cleanup. Improve javadoc in CallerSensitiveAdapter
>
> The static Const/Poly/Var is doing better than the
On 10/14/2021 10:23 AM, Michael Bien wrote:
is this the right mailing list for javax.lang.model.* discussions?
The compiler-dev list would be appropriate as well, but core-libs will work.
First, I understand the desire for a method like this. One of the
potential issues is SourceVersion
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Please file a CSR for the change in behavior.
On Fri, 16 Apr 2021 11:30:32 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
is this the right mailing list for javax.lang.model.* discussions?
if yes:
instead of adding
/**
* Returns the version as int representing the feature release.
* @see Runtime.Version#feature()
*/
public int feature() {
return this.ordinal();
}
to
> This PR improves the performance of vector operations that accept masks on
> architectures that support masking in hardware, specifically Intel AVX512 and
> ARM SVE.
>
> On architectures that do not support masking in hardware the same technique
> as before is applied to most operations,
On Wed, 13 Oct 2021 18:53:22 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For
On Thu, 14 Oct 2021 00:23:29 GMT, Maurizio Cimadamore
wrote:
> I noted that in the static case, Poly does regress for fields - do we know
> why instance Poly is better than static Poly? That seems surprising.
I think you're asking why the regression of instance Poly is smaller than that
of
On Thu, 14 Oct 2021 19:53:46 GMT, Claes Redestad wrote:
> In my runs the relative regression for `instanceFieldPoly` is roughly the
> same as `staticFieldPoly` (0.61x vs 0.62x).
I was looking at this:
https://github.com/openjdk/jdk/pull/5027#issuecomment-939185418
(e.g. I didn't run
JDK-8263155: Allow additional contents for DMG
-
Commit messages:
- JDK-8263155: Allow additional contents for DMG
- JDK-8263155: Allow additional contents for DMG
- JDK-8263155: Allow additional contents for DMG
Changes: https://git.openjdk.java.net/jdk/pull/5912/files
Webrev:
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Marked as reviewed by rriggs (Reviewer).
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Filed a CSR:
> On Oct 14, 2021, at 5:12 PM, Andy Herrick wrote:
>
> On Tue, 12 Oct 2021 16:47:04 GMT, Andy Herrick wrote:
>
>> JDK-8263155: Allow additional contents for DMG
>
> This enhancement adds a command line option "--mac-dmg-content" that can be
> used to add any other content to a dmg image.
On Mon, 4 Oct 2021 10:24:01 GMT, Jan Lahoda wrote:
>> Helllo @naotoj .
>> I used `System.console()` and `Console.charset()`.
>>
>> The following executables had same issue, I fixed them.
>>> jar.exe, javac.exe, javadoc.exe, javap.exe, jdeps.exe, jlink.exe, jmod.exe,
>>> jpackage.exe
>>
>> I
On Sun, 10 Oct 2021 20:25:43 GMT, Joe Darcy wrote:
> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
> of the serialization feature. These classes contain brief descriptions of
> some of the methods serializable classes can define to interact with the
>
On Mon, 13 Sep 2021 10:54:18 GMT, Markus Grönlund wrote:
>> src/hotspot/share/services/finalizerService.cpp line 44:
>>
>>> 42: _ik(ik),
>>> 43: _objects_on_heap(0),
>>> 44: _total_finalizers_run(0) {}
>>
>> Is this hashtable for every InstanceKlass that defines a finalizer? How
On Thu, 14 Oct 2021 21:58:42 GMT, Coleen Phillimore wrote:
>> "Since you remove entries on unloading, I don't see any reason to have any
>> concurrent cleanup."
>> Thank you, that is true. The only concurrent work required will be to grow
>> the table.
>>
>> "You do however need in the lookup
On Wed, 13 Oct 2021 18:03:25 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more
On Thu, 14 Oct 2021 22:02:43 GMT, Coleen Phillimore wrote:
>> Ok, I see - grow the table.
>>
>> I'm not sure if you need to ask ik->is_loader_alive() or not, but I think
>> you do. The InstanceKlass is removed from your table during class unloading
>> but before that during concurrent class
On Thu, 14 Oct 2021 17:21:25 GMT, Paul Sandoz wrote:
>> This PR improves the performance of vector operations that accept masks on
>> architectures that support masking in hardware, specifically Intel AVX512
>> and ARM SVE.
>>
>> On architectures that do not support masking in hardware the
On Thu, 14 Oct 2021 21:46:36 GMT, Coleen Phillimore wrote:
>> Markus Grönlund has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
>
On Tue, 12 Oct 2021 16:47:04 GMT, Andy Herrick wrote:
> JDK-8263155: Allow additional contents for DMG
This enhancement adds a command line option "--mac-dmg-content" that can be
used to add any other content to a dmg image. The default DMGsetup.scpt is
modified to show all the additional
55 matches
Mail list logo
