On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three sect
On Thu, 21 Oct 2021 06:50:41 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/Console.java line 587:
>>
>>> 585: try {
>>> 586: cs = Charset.forName(csname, null);
>>> 587: } catch (Exception ignored) { }
>>
>> The comment which
Hello Alan,
On 19/10/21 7:40 pm, Alan Bateman wrote:
On 19/10/2021 14:49, Jaikiran Pai wrote:
Ah! So this exact same investigation had already happened a few weeks
back then. I haven't subscribed to that list, so missed it. I see in
one of those messages this part:
"Off hand I can't think
On 21/10/2021 10:49, Jaikiran Pai wrote:
:
Digging into it, it appears that since the ModuleDescriptor#equals()
calls equals() on enum types (in this specific case on
ModuleDescriptor.Requires.Modifier) and since enum type equality is
implemented as identity checks, those identity checks are
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote:
> Another serialization warnings cleanup; this time in java.rmi.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6055
On Thu, 21 Oct 2021 04:40:25 GMT, Joe Darcy wrote:
> This should be the last core libraries cleanup of non-serializable
> non-transient instance fields ahead of the upcoming javac lint warnings:
> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-October/006166.html
Marked as reviewed by r
On Fri, 20 Aug 2021 22:44:34 GMT, Weijun Wang wrote:
> This change modifies the default value of the `java.security.manager` system
> property from "allow" to "disallow". This means unless it's explicitly set to
> "allow", any call to `System.setSecurityManager()` would throw an UOE.
>
> This
On Thu, 21 Oct 2021 01:31:31 GMT, Sergey Bylokhov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved the null sentence into @param tag.
>
> src/java.base/share/classes/java/io/Console.java line 594:
>
>> 592:
> This should be the last core libraries cleanup of non-serializable
> non-transient instance fields ahead of the upcoming javac lint warnings:
> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-October/006166.html
Joe Darcy has updated the pull request incrementally with one additional com
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote:
> Another serialization warnings cleanup; this time in java.rmi.
This pull request has now been integrated.
Changeset: 3cb241a9
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/3cb241a91fd2cc6b0b3b333288028694e60f723f
S
On Thu, 21 Oct 2021 04:40:25 GMT, Joe Darcy wrote:
> This should be the last core libraries cleanup of non-serializable
> non-transient instance fields ahead of the upcoming javac lint warnings:
> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-October/006166.html
This pull request has n
> JDK-8263155: Allow additional contents for DMG
Andy Herrick has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains five commits:
- Merge branch 'master' into JDK-8263155
- Merge branch 'master' into JDK-8263155
- JDK-8263155: Allow
On Thu, 21 Oct 2021 09:33:30 GMT, Daniel Fuchs wrote:
>> Right, I think both try-catch usages will be removed.
>
> Apparently `IllegalCharsetNameException` or `IllegalArgumentException` could
> still be thrown - so removing the `try-catch` would be a change of behaviour
> in those cases. It all
On Thu, 21 Oct 2021 15:00:03 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/Console.java line 594:
>>
>>> 592: cs = Charset.forName(StaticProperty.nativeEncoding(),
>>> Charset.defaultCharset());
>>> 593: } catch (Exception ignored) {
>>> 594:
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Tue, 19 Oct 2021 01:26:35 GMT, Jonathan Gibbons wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274544: Langtools command's usage were garbled on Japanese Windows
>
> This is pretty ugly code to be replica
On 10/21/21 5:25 AM, Alan Bateman wrote:
On 21/10/2021 10:49, Jaikiran Pai wrote:
:
Digging into it, it appears that since the ModuleDescriptor#equals()
calls equals() on enum types (in this specific case on
ModuleDescriptor.Requires.Modifier) and since enum type equality is
implemented a
On Thu, 21 Oct 2021 16:06:31 GMT, Ichiroh Takiguchi
wrote:
> I'd like to write down following code without `try-catch`.
You don't *have to* try-catch those exceptions if you are not interested, as
they are subclasses of `RuntimeException`.
> ```
> var cs = Charset.forName(charsetName, null);
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The following API classes are added to `java.net.spi` package to facilitate
> this:
> -
On Wed, 20 Oct 2021 18:47:32 GMT, Alan Bateman wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change InetAddressResolver method names
>
> src/java.base/share/classes/java/net/InetAddress.java line 244:
>
>> 242
On Thu, 21 Oct 2021 15:36:36 GMT, Andy Herrick wrote:
>> JDK-8263155: Allow additional contents for DMG
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into JDK-826315
On Thu, 21 Oct 2021 18:21:50 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Thu, 21 Oct 2021 15:36:36 GMT, Andy Herrick wrote:
>> JDK-8263155: Allow additional contents for DMG
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into JDK-826315
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has changed,
On Thu, 21 Oct 2021 18:00:46 GMT, Naoto Sato wrote:
>> I'm not reviewer.
>>
>> I'd like to write down following code without `try-catch`.
>>
>> var cs = Charset.forName(charsetName, null);
>> if (cs == null) cs = StandardCharsets.UTF_8;
>>
>> or please find out more easy way.
>
>> I'd like to
On Wed, 1 Sep 2021 13:39:46 GMT, Naoto Sato wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the value
On Wed, 20 Oct 2021 00:04:08 GMT, Ivan Šipka wrote:
> cc @ctornqvi
as it has been discussed internally, jtreg doesn’t recognize $os-$arch-$version
pattern in problem list (but understands $os-$version) so for the test to be
excluded only on windows 11, you should use `windows-11`
---
On Thu, 21 Oct 2021 16:03:29 GMT, Naoto Sato wrote:
>> Apparently `IllegalCharsetNameException` or `IllegalArgumentException` could
>> still be thrown - so removing the `try-catch` would be a change of behaviour
>> in those cases. It all depends on whether there is a chance that these
>> excep
Currently, the java.lang.invoke.CallSite has a package-private
constructor, and in its Javadoc it already mentions all the three
subclasses: ConstantCallSite, MutableCallSite and VolatileCallSite.
I guess that now that Java has support for sealed classes, the CallSite
could be a candidate for it t
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
Hello Ioi,
On 21/10/21 9:59 pm, Ioi Lam wrote:
On 10/21/21 5:25 AM, Alan Bateman wrote:
On 21/10/2021 10:49, Jaikiran Pai wrote:
:
Digging into it, it appears that since the ModuleDescriptor#equals()
calls equals() on enum types (in this specific case on
ModuleDescriptor.Requires.Modifier
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
33 matches
Mail list logo
