On Mon, 6 Dec 2021 07:07:03 GMT, Markus KARG wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Draft: Eliminated duplicate code using lambda expressions
>> - Draft: Use blocking mode also for target channel
>
> Ple
On Fri, 3 Dec 2021 07:34:16 GMT, Alan Bateman wrote:
> No objection to the change, I think it is just a re-balancing of tiers for CI
> systems.
Yes, quite. @dholmes-ora, are you happy with Alan's assessment?
-
PR: https://git.openjdk.java.net/jdk/pull/6619
On Fri, 3 Dec 2021 07:29:17 GMT, Toshio Nakamura wrote:
> Could you review this fix?
>
> Problem:
> Custom JRE generated by jlink cannot find non-ASCII named modules included
> inside the JRE.
>
> Cause and fix:
> If module or package name was composed by ASCII then non-ASCII characters,
> Im
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote:
> Exploratory builds indicate it is not currently necessary to exclude the
> doclint accessibility checks; this patch enables them.
>
> (Enabling the reference checks is left for future work.)
🎉
-
Marked as reviewed by ihse (Revie
On Mon, 6 Dec 2021 09:11:07 GMT, Aleksey Shipilev wrote:
>>> I've solicited feedback from core-libs folk as this affects them the most.
>>> At present we, Oracle, run the jdk_svc tests as part of hotspot testing,
>>> but this change will suddenly cause jdk testing to include them. That is
>>>
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote:
> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all
> tests not defined in the lower tiers. `hotspot:tier4` has lots of them,
> mostly long-running vmTestbase tests, which take many hours even on a very
> paralle
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote:
> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all
> tests not defined in the lower tiers. `hotspot:tier4` has lots of them,
> mostly long-running vmTestbase tests, which take many hours even on a very
> paralle
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request increm
On Fri, 3 Dec 2021 10:05:43 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Mon, 6 Dec 2021 00:15:13 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge jdk:master
>>
>>Signed-off-by: Andrew Leonard
>> - Merge branch 'master'
> The caches in ObjectStreamClass basically map WeakReference to
> SoftReference, where the ObjectStreamClass also references
> the same Class. That means that the cache entry, and thus the class and its
> class-loader, will not get reclaimed, unless the GC determines that memory
> pressure is
On Sat, 4 Dec 2021 08:47:03 GMT, Peter Levart wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary import
>
> src/java.base/share/classes/java/io/ClassCache.java line 63:
>
>> 61: protect
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request increm
On Mon, 6 Dec 2021 12:12:44 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get recl
> The specification of ObjectInputStream constructors that invoke
> `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention exceptions
> that may be thrown by the apply() method.
>
> In both constructors, add the following to the paragraph the describes
> invoking the factory:
>
>
On Mon, 6 Dec 2021 04:27:30 GMT, Jaikiran Pai wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
On Mon, 6 Dec 2021 04:30:16 GMT, Jaikiran Pai wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
On Mon, 6 Dec 2021 04:40:01 GMT, Jaikiran Pai wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
On Mon, 6 Dec 2021 04:44:18 GMT, Jaikiran Pai wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
Deprecate the sun.misc.Unsafe methods that return field offsets. These method
are an impediment to possible future changes. Layout may not be fixed in the
future, the VM should be allowed to re-layout dynamically based on patterns of
usage. We also have the issue of libraries using these methods
On Mon, 6 Dec 2021 13:57:48 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Fri, 3 Dec 2021 13:05:44 GMT, Alan Bateman wrote:
> Deprecate the sun.misc.Unsafe methods that return field offsets. These method
> are an impediment to possible future changes. Layout may not be fixed in the
> future, the VM should be allowed to re-layout dynamically based on patterns
> of
> The effects of invalid values of `jdk.serialFilter` and
> `jdk.serialFilterFactory` properties are
> incompletely specified. The behavior for invalid values of the properties is
> different and
> use an unconventional exception type, `ExceptionInInitializerError` and leave
> the `OIF.Config`
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote:
> Exploratory builds indicate it is not currently necessary to exclude the
> doclint accessibility checks; this patch enables them.
>
> (Enabling the reference checks is left for future work.)
This pull request has now been integrated.
Changes
On Fri, 3 Dec 2021 07:29:17 GMT, Toshio Nakamura wrote:
> Could you review this fix?
>
> Problem:
> Custom JRE generated by jlink cannot find non-ASCII named modules included
> inside the JRE.
>
> Cause and fix:
> If module or package name was composed by ASCII then non-ASCII characters,
> Im
On Fri, 3 Dec 2021 13:05:44 GMT, Alan Bateman wrote:
> Deprecate the sun.misc.Unsafe methods that return field offsets. These method
> are an impediment to possible future changes. Layout may not be fixed in the
> future, the VM should be allowed to re-layout dynamically based on patterns
> of
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote:
>> Instead of something like
>>
>> long x;
>> long y;
>> return (x < y) ? -1 : ((x == y) ? 0 : 1);
>>
>> we can use `return Long.compare(x, y);`
>>
>> All replacements are done with IDE.
>
> Сергей Цыпанов has updated the pull request inc
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API
On Mon, 6 Dec 2021 17:47:37 GMT, Alan Bateman wrote:
> I toyed with including staticFieldBase but I didn't find anything like the
> usage as the offset methods. Easy to include if you think it's worth doing.
Yes, I think you should include it, it's part of this set of functionality
(since base
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
> keys. However, the
On Mon, 6 Dec 2021 17:57:49 GMT, Paul Sandoz wrote:
> Yes, I think you should include it, it's part of this set of functionality
> (since base is used in conjunction with offsets)
Okay, done.
-
PR: https://git.openjdk.java.net/jdk/pull/6700
> Deprecate the sun.misc.Unsafe methods that return field offsets. These method
> are an impediment to possible future changes. Layout may not be fixed in the
> future, the VM should be allowed to re-layout dynamically based on patterns
> of usage. We also have the issue of libraries using these
On Mon, 6 Dec 2021 18:19:39 GMT, Alan Bateman wrote:
>> Deprecate the sun.misc.Unsafe methods that return field offsets. These
>> method are an impediment to possible future changes. Layout may not be fixed
>> in the future, the VM should be allowed to re-layout dynamically based on
>> pattern
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request increm
On Mon, 6 Dec 2021 16:36:37 GMT, Alan Bateman wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
>
On Mon, 6 Dec 2021 19:04:06 GMT, Andrew Leonard wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line
>> 300:
>>
>>> 298: \ --date=TIMESTAMP The timestamp in ISO-8601 extended
>>> offset date-time with\n\
>>> 299: \ optional
On Sat, 4 Dec 2021 22:34:50 GMT, Naoto Sato wrote:
>> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
>> display names were incorrectly substituted for CLDR. The reason it worked
>> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the
>> names for `zh-
8278311: Debian packaging doesn't work
-
Commit messages:
- Changes from another fix removed
- 8278311: Debian packaging doesn't work
Changes: https://git.openjdk.java.net/jdk/pull/6726/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6726&range=00
Issue: https://bugs
On Mon, 6 Dec 2021 18:19:39 GMT, Alan Bateman wrote:
>> Deprecate the sun.misc.Unsafe methods that return field offsets. These
>> method are an impediment to possible future changes. Layout may not be fixed
>> in the future, the VM should be allowed to re-layout dynamically based on
>> pattern
On 12/4/2021 4:31 PM, liach wrote:
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote:
Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` `merge`
would throw CME if the functions modified the map itself, and there are
corresponding specification changes.
Since I don't have
> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
> display names were incorrectly substituted for CLDR. The reason it worked
> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the names
> for `zh-Hant` were cached and hit for the following `zh-MO` name
On Mon, 6 Dec 2021 18:52:51 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use isFixedOffset() instead of useDaylightTime()
>
> src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.ja
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant @SuppressWarn
On Mon, 6 Dec 2021 19:11:45 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andre
On Mon, 6 Dec 2021 20:32:55 GMT, Naoto Sato wrote:
>> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
>> display names were incorrectly substituted for CLDR. The reason it worked
>> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the
>> names for `zh-
On Mon, 29 Nov 2021 19:08:43 GMT, Lance Andersen wrote:
>>> @AlanBateman yes, see above comment, thanks
>>
>> This is a significant change to the ZipEntry API that will require
>> discussion and agreement. Can you start a discussion on core-libs-dev about
>> the topic? You could start with a s
> The time to get JDK 19 underway draws nigh, please review this usual set of
> start-of-release updates, including CSRs for the javac and javax.lang.model
> updates:
>
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
>
> JDK-8277514: Add source 19
On Mon, Dec 6, 2021 at 8:10 AM Thiago Henrique Hupner wrote:
>
> Hi all.
>
> I've found something weird.
> If I try to "reflect" a MethodHandle.arrayElementGetter, the method
> returned is not accessible, so I need to call setAccessible to be able to
> use it.
> The same happens to arrayElementSet
On Mon, 6 Dec 2021 16:59:41 GMT, Roger Riggs wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type, `
On Mon, 6 Dec 2021 19:20:00 GMT, Alexey Semenyuk wrote:
> 8278311: Debian packaging doesn't work
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6726
On Mon, 6 Dec 2021 12:12:44 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get recl
51 matches
Mail list logo
