Re: RFR: 8278341: Liveness check for global scope is not as fast as it could be

2021-12-07 Thread Aleksey Shipilev
On Tue, 7 Dec 2021 13:12:13 GMT, Maurizio Cimadamore wrote: > When doing some unrelated performance measurements, I realized that segments > backed by global scope were still paying a relatively high cost for liveness > checks - that's because GlobalScopeImpl extends from SharedScopeImpl, and

Re: RFR: 8278341: Liveness check for global scope is not as fast as it could be

2021-12-07 Thread Jorn Vernee
On Tue, 7 Dec 2021 13:12:13 GMT, Maurizio Cimadamore wrote: > When doing some unrelated performance measurements, I realized that segments > backed by global scope were still paying a relatively high cost for liveness > checks - that's because GlobalScopeImpl extends from SharedScopeImpl, and

Integrated: 8277863: Deprecate sun.misc.Unsafe methods that return offsets

2021-12-07 Thread Alan Bateman
On Fri, 3 Dec 2021 13:05:44 GMT, Alan Bateman wrote: > Deprecate the sun.misc.Unsafe methods that return field offsets. These method > are an impediment to possible future changes. Layout may not be fixed in the > future, the VM should be allowed to re-layout dynamically based on patterns >

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v3]

2021-12-07 Thread Сергей Цыпанов
On Tue, 7 Dec 2021 12:01:27 GMT, Alexey Ivanov wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Inline local var > > src/java.base/share/classes/java/util/Calendar.java line 3420: > >> 3418: private

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v4]

2021-12-07 Thread Сергей Цыпанов
> Instead of something like > > long x; > long y; > return (x < y) ? -1 : ((x == y) ? 0 : 1); > > we can use `return Long.compare(x, y);` > > All replacements are done with IDE. Сергей Цыпанов has updated the pull request incrementally with two additional commits since the last revision: -

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-07 Thread Сергей Цыпанов
On Mon, 6 Dec 2021 17:48:37 GMT, Phil Race wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > > src/java.desktop/share/classes/sun/java2d/Spans.java line 322: > >>

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Alan Bateman
On Mon, 6 Dec 2021 19:11:45 GMT, Andrew Leonard wrote: >> Add a new --source-date (epoch seconds) option to jar and jmod >> to allow specification of time to use for created/updated jar/jmod entries. >> This then allows the ability to make the content deterministic. >> >> Signed-off-by:

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-07 Thread Сергей Цыпанов
On Mon, 6 Dec 2021 17:46:22 GMT, Phil Race wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > > src/java.desktop/share/classes/java/awt/geom/Line2D.java line 115: >

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v3]

2021-12-07 Thread Сергей Цыпанов
> Instead of something like > > long x; > long y; > return (x < y) ? -1 : ((x == y) ? 0 : 1); > > we can use `return Long.compare(x, y);` > > All replacements are done with IDE. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Andrew Leonard
On Tue, 7 Dec 2021 09:24:44 GMT, Alan Bateman wrote: > I've edited the CSR to make the summary a bit simpler. I've also removed some > of text from the Solution section as the discussion about SOURCE_DATE_EPOCH > being an issue due to the security manager was confusing. I also removed the >

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

2021-12-07 Thread Aleksey Shipilev
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very >

Re: RFR: 8278185: Custom JRE cannot find non-ASCII named module inside

2021-12-07 Thread Toshio Nakamura
On Fri, 3 Dec 2021 07:29:17 GMT, Toshio Nakamura wrote: > Could you review this fix? > > Problem: > Custom JRE generated by jlink cannot find non-ASCII named modules included > inside the JRE. > > Cause and fix: > If module or package name was composed by ASCII then non-ASCII characters, >

Re: RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive [v8]

2021-12-07 Thread Roman Kennke
> The caches in ObjectStreamClass basically map WeakReference to > SoftReference, where the ObjectStreamClass also references > the same Class. That means that the cache entry, and thus the class and its > class-loader, will not get reclaimed, unless the GC determines that memory > pressure is

Re: RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive [v7]

2021-12-07 Thread Roman Kennke
On Tue, 7 Dec 2021 06:23:22 GMT, Peter Levart wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix cast; add testcase to cover memory pressure > > test/jdk/java/io/ObjectStreamClass/TestOSCClassLoaderLeak.java line

Re: RFR: 8278185: Custom JRE cannot find non-ASCII named module inside [v2]

2021-12-07 Thread Toshio Nakamura
> Could you review this fix? > > Problem: > Custom JRE generated by jlink cannot find non-ASCII named modules included > inside the JRE. > > Cause and fix: > If module or package name was composed by ASCII then non-ASCII characters, > ImageStringsReader:stringFromByteBufferMatches()

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Lance Andersen
On Tue, 7 Dec 2021 09:32:47 GMT, Andrew Leonard wrote: > > I've edited the CSR to make the summary a bit simpler. I've also removed > > some of text from the Solution section as the discussion about > > SOURCE_DATE_EPOCH being an issue due to the security manager was confusing. > > I also

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Alan Bateman
On Tue, 7 Dec 2021 13:10:53 GMT, Andrew Leonard wrote: > @jddarcy hi Joe, what's the next step with the CSR now? > https://bugs.openjdk.java.net/browse/JDK-8277755 > thanks For the CSR then you need to press "Finalize". - PR: https://git.openjdk.java.net/jdk/pull/6481

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Andrew Leonard
On Mon, 6 Dec 2021 19:11:45 GMT, Andrew Leonard wrote: >> Add a new --source-date (epoch seconds) option to jar and jmod >> to allow specification of time to use for created/updated jar/jmod entries. >> This then allows the ability to make the content deterministic. >> >> Signed-off-by:

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-07 Thread Alexey Ivanov
On Tue, 7 Dec 2021 08:16:08 GMT, Сергей Цыпанов wrote: >> src/java.desktop/share/classes/java/awt/geom/Line2D.java line 115: >> >>> 113: */ >>> 114: public double getX1() { >>> 115: return x1; >> >> What do these changes have to do with the subject of the PR ? > >

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v3]

2021-12-07 Thread Alexey Ivanov
On Tue, 7 Dec 2021 08:28:47 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Andrew Leonard
On Mon, 6 Dec 2021 19:11:45 GMT, Andrew Leonard wrote: >> Add a new --source-date (epoch seconds) option to jar and jmod >> to allow specification of time to use for created/updated jar/jmod entries. >> This then allows the ability to make the content deterministic. >> >> Signed-off-by:

Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v20]

2021-12-07 Thread Andrew Leonard
On Tue, 7 Dec 2021 12:03:10 GMT, Lance Andersen wrote: > The latest CSR update looks good so I think you are in good shape now @LanceAndersen thank you Lance - PR: https://git.openjdk.java.net/jdk/pull/6481

RFR: 8278341: Liveness check for global scope is not as fast as it could be

2021-12-07 Thread Maurizio Cimadamore
When doing some unrelated performance measurements, I realized that segments backed by global scope were still paying a relatively high cost for liveness checks - that's because GlobalScopeImpl extends from SharedScopeImpl, and does not override the `isAlive` method. This means that when