On Fri, 10 Dec 2021 16:30:37 GMT, Jonathan Gibbons wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Turn `getRealPath()` into a no-arg helper method
>
> test/langtools/tools/javac/T8271079.java line 39:
>
>> 37:
On Fri, 10 Dec 2021 16:37:35 GMT, Jonathan Gibbons wrote:
> javac changes look good. I suggest adding this bug number to the test to
> check that URIs are not double-encoded.
I can't find [`8134451`](https://bugs.openjdk.java.net/browse/JDK-8134451) as
noted in the now removed comment directly
> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
> class `PathFileObject` in module `jdk.compiler` were always composed by base
> path names. Even for versioned entries of a multi-release JAR file.
>
> Now, a `URI` for an entry is composed of its real path names using a
On Fri, 10 Dec 2021 16:33:33 GMT, Jonathan Gibbons wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Turn `getRealPath()` into a no-arg helper method
>
> test/langtools/tools/javac/T8271079.java line 58:
>
>> 56:
On Fri, 10 Dec 2021 14:09:00 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andr
On Sat, 11 Dec 2021 11:57:57 GMT, Lance Andersen wrote:
> Hi Andrew,
>
> The latest Mach5 runs remain clean and the updates look good so you are good
> to integrate when you are ready!
Thank you @LanceAndersen
-
PR: https://git.openjdk.java.net/jdk/pull/6481
On Fri, 19 Nov 2021 16:52:36 GMT, Andrew Leonard wrote:
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Le
On Sat, 11 Dec 2021 11:29:50 GMT, Christian Stein wrote:
>> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
>> class `PathFileObject` in module `jdk.compiler` were always composed by base
>> path names. Even for versioned entries of a multi-release JAR file.
>>
>> Now,
