[jdk18] RFR: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

2022-01-03 Thread Aleksey Shipilev
Seems like a missing include. C++ docs say `offsetof` is from ``, adding that include explicitly fixes the build. Seems to only happen with older GCCs, but it seems to be a happy accident it works on newer ones, probably through the transitive include somewhere. Additional testing: - [x]

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v2]

2022-01-03 Thread Jatin Bhateja
> Patch extends existing macrologic inferencing algorithm to handle masked > logic operations. > > Existing algorithm: > > 1. Identify logic cone roots. > 2. Packs parent and logic child nodes into a MacroLogic node in bottom up > traversal if input constraint are met. > i.e. maximum number of

Re: a quick question about String

2022-01-03 Thread Andrew Haley
On 12/30/21 16:12, Alexander Scherbatiy wrote: Would it be useful to have some kind of an immutable array in Java language which works in the same way as ordinary array except it is not to possible to change its values after creation? Yes. https://openjdk.java.net/jeps/8261007 -- Andrew

Integrated: 8276700: Improve java.lang.ref.Cleaner javadocs

2022-01-03 Thread Hendrik Schreiber
On Fri, 22 Oct 2021 08:03:34 GMT, Hendrik Schreiber wrote: > Trivial improvement. > > Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`. > Repeat (again) in the code example that the `State` `Runnable `should be > implemented as static class and not reference the

Re: RFR: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java [v2]

2022-01-03 Thread Naoto Sato
> The proposed fix is to address the performance degradation caused by the fix > to JDK-8275721. Some amount of the degradation cannot be avoided as the > lookup now falls back up to the bundles at Locale.ROOT. However, by lowering > the fallback priority of `regionFormatFallback` than

Re: [jdk18] RFR: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

2022-01-03 Thread Victor Dyakov
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote: > Seems like a missing include. C++ docs say `offsetof` is from ``, > adding that include explicitly fixes the build. Seems to only happen with > older GCCs, but it seems to be a happy accident it works on newer ones, > probably through

Re: [jdk18] RFR: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

2022-01-03 Thread Alexander Matveev
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote: > Seems like a missing include. C++ docs say `offsetof` is from ``, > adding that include explicitly fixes the build. Seems to only happen with > older GCCs, but it seems to be a happy accident it works on newer ones, > probably through

Re: RFR: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java [v2]

2022-01-03 Thread Naoto Sato
On Mon, 3 Jan 2022 23:45:16 GMT, Joe Wang wrote: > Hope looping through Zone strings isn't really necessary. Thanks, Joe. IMHO, `DateFormatSymbols.getZoneStrings()` is badly designed. It just simply exposes the names in the underlying ResourceBundle, and I cannot think of any use cases for

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

2022-01-03 Thread Сергей Цыпанов
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed missing BufferedInputStream Maybe we need to include into this patch the benchmark

Re: RFR: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java [v2]

2022-01-03 Thread Joe Wang
On Mon, 3 Jan 2022 19:37:03 GMT, Naoto Sato wrote: >> The proposed fix is to address the performance degradation caused by the fix >> to JDK-8275721. Some amount of the degradation cannot be avoided as the >> lookup now falls back up to the bundles at Locale.ROOT. However, by lowering >> the

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v2]

2022-01-03 Thread Vladimir Kozlov
On Mon, 3 Jan 2022 12:31:50 GMT, Jatin Bhateja wrote: >> Patch extends existing macrologic inferencing algorithm to handle masked >> logic operations. >> >> Existing algorithm: >> >> 1. Identify logic cone roots. >> 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >>

Integrated: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java

2022-01-03 Thread Naoto Sato
On Fri, 10 Dec 2021 00:27:25 GMT, Naoto Sato wrote: > The proposed fix is to address the performance degradation caused by the fix > to JDK-8275721. Some amount of the degradation cannot be avoided as the > lookup now falls back up to the bundles at Locale.ROOT. However, by lowering > the