Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

On Thu, 23 Dec 2021 16:42:50 GMT, Alan Bateman wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8272746: ZipFile can't open big file (NegativeArraySizeException) > >

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v4]

On Wed, 5 Jan 2022 08:59:00 GMT, Jatin Bhateja wrote: >> Patch extends existing macrologic inferencing algorithm to handle masked >> logic operations. >> >> Existing algorithm: >> >> 1. Identify logic cone roots. >> 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >>

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v4]

On Thu, 6 Jan 2022 17:39:20 GMT, Sandhya Viswanathan wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8273322: Review comments resolution. > > test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v5]

> Patch extends existing macrologic inferencing algorithm to handle masked > logic operations. > > Existing algorithm: > > 1. Identify logic cone roots. > 2. Packs parent and logic child nodes into a MacroLogic node in bottom up > traversal if input constraint are met. > i.e. maximum number of

Re: RFR: 8273322: Enhance macro logic optimization for masked logic operations. [v5]

On Thu, 6 Jan 2022 18:26:32 GMT, Jatin Bhateja wrote: >> Patch extends existing macrologic inferencing algorithm to handle masked >> logic operations. >> >> Existing algorithm: >> >> 1. Identify logic cone roots. >> 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >>

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

On Thu, 6 Jan 2022 09:34:24 GMT, Alan Bateman wrote: > > @AlanBateman Could you please review the above comments. > > Thanks for changing the message, the update to ZipFile looks good to me > although I'm still surprised that the native tools support a CEN larger than > 2Gb. > > I'm slow to

Re: [jdk18] RFR: 8279527: Dereferencing segments backed by different scopes leads to pollution [v2]

On Wed, 5 Jan 2022 18:08:01 GMT, Maurizio Cimadamore wrote: >> This patch fixes a performance issue when dereferencing memory segments >> backed by different kinds of scopes. When looking at inline traces, I found >> that one of our benchmark, namely `LoopOverPollutedSegment` was already >>

Re: [jdk18] RFR: 8279527: Dereferencing segments backed by different scopes leads to pollution [v2]

On Thu, 6 Jan 2022 12:11:29 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use owner field instead of accessor in checkValidStateSlow > >

Re: [jdk18] RFR: 8279527: Dereferencing segments backed by different scopes leads to pollution [v3]

> This patch fixes a performance issue when dereferencing memory segments > backed by different kinds of scopes. When looking at inline traces, I found > that one of our benchmark, namely `LoopOverPollutedSegment` was already > hitting the ceiling of the bimorphic inline cache, specifically

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

On Thu, 9 Dec 2021 11:50:50 GMT, Сергей Цыпанов wrote: > `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Let's wait - PR: https://git.openjdk.java.net/jdk/pull/6782

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by lancea (Reviewer). - PR:

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

On Thu, 9 Dec 2021 11:50:50 GMT, Сергей Цыпанов wrote: > `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Changes requested by redestad (Reviewer).

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v5]

On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed missing BufferedInputStream I think you'll need to look at the interaction with

Re: RFR: 8276694: Pattern trailing unescaped backslash causes internal error

On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote: > Could you please review the 8276694 bug fixes? > > A message specific for this exception should be printed instead of an > internal error. This fix adds a new check to output an appropriate exception > message when the regular

Integrated: 8273322: Enhance macro logic optimization for masked logic operations.

On Mon, 20 Dec 2021 13:33:01 GMT, Jatin Bhateja wrote: > Patch extends existing macrologic inferencing algorithm to handle masked > logic operations. > > Existing algorithm: > > 1. Identify logic cone roots. > 2. Packs parent and logic child nodes into a MacroLogic node in bottom up >

Withdrawn: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging

On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > At the time Java supported applets and webstart, a special mechanism for > launching various applications in one JVM was used to reduce memory usage and > each application was isolated from each other. > > This isolation was