Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

2022-01-10 Thread Сергей Цыпанов
On Thu, 6 Jan 2022 16:38:05 GMT, Claes Redestad wrote: >> `Executable.getParameterTypes()` creates a copy of underlying array which is >> redundant in trusted code when we are sure the action is read-only. > > src/java.base/share/classes/java/lang/reflect/Executable.java line 313: > >> 311:

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

2022-01-10 Thread Сергей Цыпанов
On Thu, 6 Jan 2022 16:45:09 GMT, Claes Redestad wrote: >> `Executable.getParameterTypes()` creates a copy of underlying array which is >> redundant in trusted code when we are sure the action is read-only. > > src/java.base/share/classes/java/lang/reflect/Executable.java line 317: > >> 315:

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Сергей Цыпанов
> `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 8278461: Revert Executable --

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Сергей Цыпанов
On Mon, 10 Jan 2022 09:38:15 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 313: >> >>> 311: // getParameterTypes(). >>> 312: if (!genericInfo) { >>> 313: return getSharedParameterTypes(); >> >> Since this returns the

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Claes Redestad
On Mon, 10 Jan 2022 10:02:18 GMT, Сергей Цыпанов wrote: >> `Executable.getParameterTypes()` creates a copy of underlying array which is >> redundant in trusted code when we are sure the action is read-only. > > Сергей Цыпанов has updated the pull request incrementally with one additional > comm

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Claes Redestad
On Mon, 10 Jan 2022 09:53:56 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 317: >> >>> 315: final boolean realParamData = hasRealParameterData(); >>> 316: final Type[] genericParamTypes = >>> getGenericParameterTypes();

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v3]

2022-01-10 Thread Сергей Цыпанов
> `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - 82784

Integrated: Merge jdk18

2022-01-10 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8274679: Remove unnecessary conversion to String in security code in java.base - 8142362: Lots of code duplication in Copy class - 8218857: Confusing overloads for os::open - 8183227: read/write APIs in class os shall ret

Integrated: Merge jdk18

2022-01-10 Thread Jesper Wilhelmsson
On Mon, 10 Jan 2022 17:00:05 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: d9b1bb58 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/d9b1bb58600c03cee43387864d1530d4dd5f1422 Stats: 615 l

Re: RFR: 8278065: Refactor subclassAudits to use ClassValue [v3]

2022-01-10 Thread Roman Kennke
On Fri, 10 Dec 2021 21:07:37 GMT, Roman Kennke wrote: >> As a follow-up to #6375, this change refactors >> java.io.ObjectInputStream.Caches#subclassAudits and >> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead >> of SoftReference, similar to what we did in #6375 for

jdk11u build failure on Windows

2022-01-10 Thread Vyom Tiwari
Hi, I am facing the build issue with OpenJDK11(jdk11u). I am trying to build jdk11u on Windows and I am getting the below error. ./src/java.base/windows/native/libnet/net_util_md.c(792): error C2065: 'TCP_INITIAL_RTO_NO_SYN_RETRANSMISSIONS': undeclared identifier make[3]: **