> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by prr (Reviewer).
Looks like there's only one client source code file touched
Most of the client changes
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
I've increased the number of reviewers because as well as the
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
LGTM also.
Similar suggestion for updating copyrights.
-
Marked as reviewed by wetmore (Reviewer).
PR:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
We usually request that these be be broken up by area to attract the
appropriate reviewers and avoid eye-strain. The client
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the autovectorizer, the complexity of doing it by hand is
On Fri, 4 Mar 2022 17:14:34 GMT, Claes Redestad wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
Several attempts have been made to improve Formatter's numeric performance by
caching the current Locale zero. Such fixes, however, ignore the real issue,
which is the slowness of fetching DecimalFormatSymbols. By directly caching
DecimalFormatSymbols in the Formatter, this enhancement
On Fri, 4 Mar 2022 19:33:07 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 2016:
>>
>>> 2014: static DecimalFormatSymbols getDecimalFormatSymbols(Locale
>>> locale) {
>>> 2015: DecimalFormatSymbols dfs = DFS;
>>> 2016: if (dfs != null &&
On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> Hi
>
> I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
> Now: what is the next step?
>
>
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi Lance
I can make a second commit updating the copyright year
Tell me if this is necessary
ciao
matteo
-
PR:
On Fri, 4 Mar 2022 19:50:29 GMT, Naoto Sato wrote:
>> I know this looks wrong and I debated with myself about it, but 1) Locale
>> equals is complex 2) many Locales are global constants 3) there is a 1-1
>> correspondence of DecimalFormatSymbols to locale. AFAIK even If two locales
>>
On Fri, 4 Mar 2022 02:27:53 GMT, Stuart Marks wrote:
> OK, I took a look at HashMapsPutAllOverAllocateTableTest.java. It's certainly
> a good start at testing stuff in this area. However, I notice that
>
> ```
> test/jdk/java/util/HashMap/WhiteBoxResizeTest.java
> ```
>
> already exists and
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
Looks good.
-
Marked as reviewed by stuefe
On Fri, 4 Mar 2022 02:27:53 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cast several float to double before calculation
>
> OK, I took a look at HashMapsPutAllOverAllocateTableTest.java. It's
On Thu, 3 Mar 2022 15:46:37 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> cast several float to double before calculation
I
On Fri, 4 Mar 2022 17:43:25 GMT, liach wrote:
> nitpick for the test code: for better performance, move method handle and var
> handle to static final fields so the jvm can run faster
will do it when we really migrate this test, but it should be done in another
pr when I add WeakHashMap's
On Fri, 4 Mar 2022 17:44:44 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
>>
On Fri, 4 Mar 2022 19:00:54 GMT, Naoto Sato wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
Hi
I have reviewed the code for removing double semicolons at the end of lines
all the best
matteo
-
Commit messages:
- Removed double semicolon at the end of lines
Changes: https://git.openjdk.java.net/jdk/pull/7268/files
Webrev:
Despite the hash value being cached for Strings, computing the hash still
represents a significant CPU usage for applications handling lots of text.
Even though it would be generally better to do it through an enhancement to the
autovectorizer, the complexity of doing it by hand is trivial and
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi
I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
Now: what is the next step?
This is a cleanup
On Fri, 4 Mar 2022 17:30:48 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
nitpick for the test code: for better
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
This pull request has now been integrated.
Changeset: 733c7907
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
The changes look OK. The copyright year probably should be updated as part of
this PR
-
Marked as reviewed by
On Fri, 4 Mar 2022 15:54:14 GMT, Ludovic Henry wrote:
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the
On Fri, 4 Mar 2022 06:06:52 GMT, Joe Darcy wrote:
>> test/jdk/java/lang/Math/RoundTests.java line 32:
>>
>>> 30: public static void main(String... args) {
>>> 31: int failures = 0;
>>> 32: for (int i = 0; i < 10; i++) {
>>
>> Is there an idiom to trigger the
On Fri, 4 Mar 2022 17:17:12 GMT, Roger Riggs wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> We usually request that these be be broken up by area to attract the
> appropriate reviewers and avoid eye-strain. The
On Fri, 4 Mar 2022 18:59:56 GMT, Naoto Sato wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Fri, 4 Mar 2022 15:54:14 GMT, Ludovic Henry wrote:
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the
On Fri, 4 Mar 2022 17:01:05 GMT, Roger Riggs wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
>>
On Fri, 4 Mar 2022 17:54:20 GMT, Jim Laskey wrote:
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
>
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 4 Mar 2022 20:23:38 GMT, XenoAmess wrote:
> would you mind if I break WhiteBoxResizeTest class into several smaller Test
> classes, each focus on one of the test points you said?
Well, separate classes wouldn't be the approach that I'd take myself. However,
I'm interested in you
On Tue, 1 Mar 2022 01:44:44 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice, good work matteo
Should I change the JBS issue title to match the PR title, or is it preferred
for the PR title to
On Fri, 4 Mar 2022 20:05:23 GMT, Stuart Marks wrote:
> This actually tests three things: 1) table is lazily allocated, 2) default
> capacity is 16, and 3) using putAll to populate the map with 64 elements
> results in a table size of 128. This should really be broken into three
> separate
On Fri, 4 Mar 2022 21:17:50 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
I would have just inlined JNU_CHECK_EXCEPTION and added the
On Fri, 4 Mar 2022 21:30:53 GMT, David Holmes wrote:
> I would have just inlined JNU_CHECK_EXCEPTION and added the cleanup code
> directly. The additional macro wasn't really necessary and would not really
> be usable for any kind of general cleanup actions beyond a one-liner.
>
> But it is
On Fri, 4 Mar 2022 21:26:57 GMT, Joe Wang wrote:
> Is the public API change, adding the isIsoLike() method, necessary?
Yes, I believe so. Without a means to tell whether the `TemporalAccessor`, such
as `LocalDate`, supports `IsoFields`, `IsoFields` would have to hard-code which
temporal
On Fri, 4 Mar 2022 17:30:48 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
> I see codes WhiteBoxResizeTest. If you
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addresses review comments
-
Changes:
Hi, I have to say I'm pretty skeptical of this change overall.
It sounds like the main issue is iterating over the entrySet of a map that might be
modified concurrently. The bug report says
> for concurrent maps, regular iteration of entrySet may fail spontaneously
This isn't true for
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement
On Fri, 4 Mar 2022 05:02:37 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
> Occasionally in core-libs we've discussed whether or not to do a pass over
> the exception classes and proactively add any of four missing convention
> constructors per java.lang.Throwable (no-arg, string, cause, cause and
> string). Last time this came up, we decided a wide-scale effort
Sounds reasonable. Then how about the claims on performance improvement,
especially for maps that have to create entry objects on entry set
iteration? In my few jmh benchmarks run, it seems adding from identity hash
map at least is sped up, while most other maps have no significant
difference.
On
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement
On Sat, 5 Mar 2022 03:14:36 GMT, Joe Darcy wrote:
>> Occasionally in core-libs we've discussed whether or not to do a pass over
>> the exception classes and proactively add any of four missing convention
>> constructors per java.lang.Throwable (no-arg, string, cause, cause and
>> string).
On Sat, 5 Mar 2022 03:14:33 GMT, Roger Riggs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Retrofit another location.
>
> src/java.base/share/classes/java/io/InvalidObjectException.java line 63:
>
>> 61: */
> Occasionally in core-libs we've discussed whether or not to do a pass over
> the exception classes and proactively add any of four missing convention
> constructors per java.lang.Throwable (no-arg, string, cause, cause and
> string). Last time this came up, we decided a wide-scale effort
On Fri, 4 Mar 2022 21:54:57 GMT, Zhengyu Gu wrote:
> The macros are used to hide the different syntax of c and c++ to avoid
> polluting code here, it seems to be a common pattern in client code.
That's to allow for general use by C or C++ source files. But you are only
needing this in a C
On Fri, 4 Mar 2022 05:02:37 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR:
On Fri, 4 Mar 2022 21:17:50 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Fri, 4 Mar 2022 20:00:54 GMT, Roger Riggs wrote:
>> I am afraid people are still using constructors for creating a locale,
>> instead of the factory method that was added later. Since `new Locale("en")
>> == new Locale("en")` returns `false`, I'd still expect `equals()` to compare
>>
On Fri, 4 Mar 2022 05:02:37 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
Occasionally in core-libs we've discussed whether or not to do a pass over the
exception classes and proactively add any of four missing convention
constructors per java.lang.Throwable (no-arg, string, cause, cause and string).
Last time this came up, we decided a wide-scale effort wasn't
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
This PR changes a comment in javax/swing/RepaintManager.java. This commented
out code should be removed altogether in another
Please review this small patch that fixes a potential memory leak that
exception return fails to release allocated `cacheDirs`
Test:
- [x] jdk_desktop on Linux x86_64
-
Commit messages:
- 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
Changes:
`java.util.zip.Inflater` is the Java wrapper class for zlib's inflater
functionality. `Inflater::inflate(byte[] output, int off, int len)`
currently calls zlib's native `inflate(..)` function and passes the
address of `output[off]` and `len` to it via JNI.
The specification of zlib's
Hi Julian,
Thanks for facilitating the communication, I probably should have
dropped you
from the reply as it was intended for the list in general as well as the
PR submitter.
Thanks, Roger
On 3/4/22 2:08 AM, Julian Waters wrote:
Hi all,
I apologize for the confusion, it seems like
65 matches
Mail list logo