On 11/03/2022 4:40 pm, Ioi Lam wrote:
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
I ended up changing `os::malloc()` to zero the buffer when running with
-Xshare:dump. Hopefully one extra check of `if (DumpSharedSpaces)` doesn't
matter too much for regular VM executions because
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Fri, 11 Mar 2022 04:56:23 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Fri, 11 Mar 2022 01:28:13 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
@RogerRiggs Good point about `Integer`
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new:
On Fri, 11 Mar 2022 07:03:00 GMT, David Holmes wrote:
> > Well, he does it for `DumpSharedSpaces` only. Are you really worried about
> > that one load+conditional jump?
>
> As I said (and I'm not the only one who says this :) ) "death by a thousand
> cuts".
Thank you, that is a good
On Fri, 11 Mar 2022 01:42:19 GMT, XenoAmess wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine test
>
> oops seems I wronglly added a teat case 0/1
> will delete it later
> @XenoAmess I don't think we need
I can't find this comment in the PR so replying via email ...
On 11/03/2022 9:24 am, Ioi Lam wrote:
On Wed, 9 Mar 2022 07:47:19 GMT, Thomas Stuefe wrote:
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
Fixed zero build
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
> > I ended up changing `os::malloc()` to zero the buffer when running with
> > -Xshare:dump. Hopefully one extra check of `if (DumpSharedSpaces)` doesn't
> > matter too much for regular VM executions because `os::malloc()` already
> > has
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Fri, 11 Mar 2022 06:50:00 GMT, David Holmes wrote:
> I can combine the tests for `MemTracker::tracking_level()` and
> `DumpSharedSpaces` into a single test and do more work only when the uncommon
> path is taken. This would require some refactoring of the
> MemTracker/MallocTracker code.
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new:
On Thu, 10 Mar 2022 22:21:28 GMT, Stuart Marks wrote:
> The difficulty with having a loop instead of constants is that the expected
> value now needs to be computed. We could probably use `tableSizeFor` to do
> this. But this is starting to get uncomfortably close to a testing
> antipattern
On Thu, 10 Mar 2022 22:37:58 GMT, Roger Riggs wrote:
> Heads up here! java.lang.Integer is specified as a value based class and
> should not be used where identity is needed.
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html
>
> I don't have a
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new:
On Thu, 10 Mar 2022 19:34:29 GMT, Ioi Lam wrote:
>> src/hotspot/share/prims/jvm.cpp line 2887:
>>
>>> 2885: return;
>>> 2886: }
>>> 2887: #endif
>>
>> Should we do this for jni_AttachCurrentThread too?
>
> This hasn't been necessary for me because jni_AttachCurrentThread is not
> called
On Thu, 10 Mar 2022 18:34:27 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>>
On Wed, 9 Mar 2022 22:52:41 GMT, Mandy Chung wrote:
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>
On Fri, 11 Mar 2022 05:55:20 GMT, Kim Barrett wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> zero GC heap filler arrays
>
> src/hotspot/share/gc/shared/collectedHeap.cpp line 449:
>
>> 447:
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On 11/03/2022 4:50 pm, Thomas Stuefe wrote:
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
Thanks for pointing this out. I ran more tests and found that on certain
platforms, there are other structures that have problems with uninitialized
gaps. I ended up changing `os::malloc()` to
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
On Sun, 6 Mar 2022 01:39:02 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Fri, 11 Mar 2022 01:28:13 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
oops seems I wronglly added a teat case
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
> > Thanks for pointing this out. I ran more tests and found that on certain
> > platforms, there are other structures that have problems with uninitialized
> > gaps. I ended up changing `os::malloc()` to zero the buffer when running
> >
On Fri, 11 Mar 2022 06:55:23 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Wed, 9 Mar 2022 07:58:51 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Hi Ioi,
>
> some questions, comments inline.
>
> Like David in the comments, I am also a bit vague
On Wed, 9 Mar 2022 11:45:59 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> The "heap dump" aspect of this is not something I'm familiar with, but if the
> threads don't affect
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For simple webserver resource files - should the copyright year be 2022?
-
PR: https://git.openjdk.java.net/jdk/pull/7765
On Wed, 9 Mar 2022 16:09:01 GMT, liach wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8282662: Revert dubious changes
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line 910:
>
>> 908:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()` with `List.of()` is dubious as
> the latter is
Please review this trivial patch to correct last parameter of
`GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean`
-
Commit messages:
- 8282897: Fix call parameter to GetStringChars() in
HostLocaleProviderAdapter_md.c
Changes:
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu wrote:
> Please review this trivial patch to correct last parameter of
> `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean`
Looks fine to me.
-
Marked as reviewed by shade (Reviewer).
PR:
On Thu, 10 Mar 2022 12:11:06 GMT, Magnus Ihse Bursie wrote:
>> The "heap dump" aspect of this is not something I'm familiar with, but if
>> the threads don't affect the list of classes dumped, they surely must affect
>> what is in the heap dump otherwise their execution would not be an issue.
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Thu, 10 Mar 2022 12:50:58 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Well, previously we'd get different dumps on different runs. If that was an
> issue, surely it
On Wed, 9 Mar 2022 11:38:34 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Wed, 9 Mar 2022 07:58:51 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Hi Ioi,
>
> some questions, comments inline.
>
> Like David in the comments, I am also a bit vague
On 09/03/2022 19:33, Volker Simonis wrote:
@Alan, @Lance,
Sorry for my obtrusiveness, but what's your opinion on this issue?
I saw your mail but I haven't had time to study it yet and see if the
spec option you prefer is the best. I will try to get time next week.
-Alan
The Skara bots messed up this one badly. It was a reply to David's
comment, not Ioi's latest push.
/Magnus
On 2022-03-10 13:56, Magnus Ihse Bursie wrote:
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
This patch makes the result of "java -Xshare:dump" deterministic:
- Disabled new Java
On Wed, 9 Mar 2022 11:38:34 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Mon, 7 Mar 2022 16:46:28 GMT, Roger Riggs wrote:
>> Olga Mikhaltsova has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reverted addition of the test via echo
>
> As an alternative fix, please take a look at Draft PR:
>
On Fri, 4 Mar 2022 19:04:40 GMT, Jatin Bhateja wrote:
>> IMO RoundTests should have a explicit @run tag without any VM options as
>> well.
>>
>> Do the added VM options run on all platforms in question? What is the
>> approximate time to run the test run compared to before?
>
> Hi @jddarcy ,
On Sat, 5 Mar 2022 19:54:44 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote:
> IIRC, localized resource files should have the same copyright year as the
> base English one. That's what I was told by the l10n engineer when I had the
> same comment.
Thanks Naoto! I have no objection then.
-
PR:
On Thu, 10 Mar 2022 01:11:03 GMT, Stuart Marks wrote:
> Sorry, the test changes look like they're heading in the wrong direction. I
> tried to provide some hints for what I was looking for in my previous
> comments. At this point, I felt it would have been too time-consuming to
> provide a
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with five additional
commits since the last revision:
- clean out tests
- Remove 'randomness' keyword.
- Cleanup and commenting.
- initial rewrite of
> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
> metacharacters
Ian Graves has updated the pull request incrementally with 196 additional
commits since the last revision:
- Merge branch 'bug-8264160' of github.com:igraves/jdk into bug-8264160
- Adding
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu wrote:
> Please review this trivial patch to correct last parameter of
> `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean`
LGTM. Thanks for the fix!
-
Marked as reviewed by naoto (Reviewer).
PR:
On Thu, 10 Mar 2022 16:13:42 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - clean out tests
> - Remove 'randomness' keyword.
>
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
manually create reference for ensuring test for WeakHashMap when
IntegerCache.high is configured/changed default
On Thu, 10 Mar 2022 16:15:03 GMT, XenoAmess wrote:
>> XenoAmess has updated the pull request incrementally with five additional
>> commits since the last revision:
>>
>> - clean out tests
>> - Remove 'randomness' keyword.
>> - Cleanup and commenting.
>> - initial rewrite of
On Thu, 10 Mar 2022 15:28:15 GMT, Aleksey Shipilev wrote:
> Looks fine to me.
Thanks, @shipilev
-
PR: https://git.openjdk.java.net/jdk/pull/7775
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
Looks good, Brian.
-
Marked as reviewed by naoto (Reviewer).
PR:
> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
> metacharacters
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding description of word-boundary regex
-
Changes:
- all:
On Thu, 10 Mar 2022 16:23:13 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with 196 additional
> commits since the last revision:
>
> - Merge branch
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
IIRC, localized resource files should have the same copyright year as the base
English one. That's what I was told by the l10n engineer when I had the same
comment.
-
PR:
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
I believe a CSR is needed for this change?
-
PR:
On Thu, 10 Mar 2022 16:23:13 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has refreshed the contents of this pull request, and previous
> commits have been removed. Incremental views are not available.
On Mon, 7 Mar 2022 16:46:28 GMT, Roger Riggs wrote:
>> Olga Mikhaltsova has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reverted addition of the test via echo
>
> As an alternative fix, please take a look at Draft PR:
>
Quoting related changes in https://bugs.openjdk.java.net/browse/JDK-8250568
modified the way that
process builder recognized argument strings, causing some arguments to be
doubly quoted and malformed.
ProcessBuilder encodes command arguments in two ways, a looser legacy encoding
and stricter
On Thu, 10 Mar 2022 19:41:03 GMT, Ioi Lam wrote:
>> I think he already did. I'm quoting:
>>
>>> However, the CDS archive also contains a heap dump, which includes Java
>>> HashMaps. If I allow those 3 Java threads to start, some HashMaps in the
>>> module graph will have unstable ordering. I
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
On Thu, 3 Mar 2022 15:38:44 GMT, Olga Mikhaltsova
wrote:
>> This fix made equal processing of strings such as ""C:\\Program
>> Files\\Git\\"" before and after JDK-8250568.
>>
>> For example, it's needed to execute the following command on Windows:
>> `C:\Windows\SysWOW64\WScript.exe
On Wed, 16 Feb 2022 21:19:04 GMT, Olga Mikhaltsova
wrote:
> This fix made equal processing of strings such as ""C:\\Program
> Files\\Git\\"" before and after JDK-8250568.
>
> For example, it's needed to execute the following command on Windows:
> `C:\Windows\SysWOW64\WScript.exe "MyVB.vbs"
On Thu, 3 Mar 2022 15:38:44 GMT, Olga Mikhaltsova
wrote:
>> This fix made equal processing of strings such as ""C:\\Program
>> Files\\Git\\"" before and after JDK-8250568.
>>
>> For example, it's needed to execute the following command on Windows:
>> `C:\Windows\SysWOW64\WScript.exe
On Fri, 4 Mar 2022 23:20:21 GMT, Roger Riggs wrote:
> Quoting related changes in https://bugs.openjdk.java.net/browse/JDK-8250568
> modified the way that
> process builder recognized argument strings, causing some arguments to be
> doubly quoted and malformed.
>
> ProcessBuilder encodes
On Thu, 10 Mar 2022 17:25:55 GMT, Naoto Sato wrote:
> LGTM. Thanks for the fix!
Thanks for the review.
-
PR: https://git.openjdk.java.net/jdk/pull/7775
On Thu, 10 Mar 2022 13:33:05 GMT, Zhengyu Gu wrote:
> Please review this trivial patch to correct last parameter of
> `GetStringChars()` call, which should be a `jboolean*`, instead of `jboolean`
This pull request has now been integrated.
Changeset: 879b6445
Author:Zhengyu Gu
URL:
> Several attempts have been made to improve Formatter's numeric performance by
> caching the current Locale zero. Such fixes, however, ignore the real issue,
> which is the slowness of fetching DecimalFormatSymbols. By directly caching
> DecimalFormatSymbols in the Formatter, this enhancement
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
Please review this small patch that fixes early `CHECK_NULL_RETURN` results not
releasing native `jchar` array returned by `GetStringChars()`.
-
Commit messages:
- 8282887: Potential memory leak in
sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Thu, 10 Mar 2022 13:51:56 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> I think he already did. I'm quoting:
>
>> However, the CDS archive also contains a heap dump,
> msg drop for jdk19, Mar 9, 2022
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
moved CurrencyNames changes to jdk.localedata
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7765/files
- new:
On Thu, 10 Mar 2022 16:17:16 GMT, Ian Graves wrote:
>> Proposed change in behavior to correct inconsistencies between `\w` and `\b`
>> metacharacters
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adding description of
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH
On Wed, 16 Feb 2022 22:32:21 GMT, Brian Burkhalter wrote:
> Remove reference to `java.io.InterruptedIOException` from
> `java.io.PrintStream`, and make the specifications of `checkError()`,
> `setError()`, and `clearError()` consistent between `java.io.PrintStream` and
>
On Wed, 9 Mar 2022 22:52:41 GMT, Mandy Chung wrote:
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>
On Thu, 10 Mar 2022 13:51:56 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> I think he already did. I'm quoting:
>
>> However, the CDS archive also contains a heap dump,
On Wed, 9 Mar 2022 07:51:46 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/prims/jvm.cpp line 2887:
>
>> 2885: return;
>> 2886: }
>> 2887: #endif
>
>
On Thu, 10 Mar 2022 18:40:13 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes early `CHECK_NULL_RETURN` results
> not releasing native `jchar` array returned by `GetStringChars()`.
LGTM.
-
Marked as reviewed by naoto (Reviewer).
PR:
On Thu, 10 Mar 2022 22:01:49 GMT, Stuart Marks wrote:
>> @stuart-marks please have a look in changes in the latest commit, I think
>> we'd better to manually create references for keys like that.
>
> Good point about WeakHashMap! I don't think we need a separate table. Since
> the value is
On Thu, 10 Mar 2022 18:34:27 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>>
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
CSR created: https://bugs.openjdk.java.net/browse/JDK-8282992
-
PR:
On Thu, 10 Mar 2022 16:10:31 GMT, XenoAmess wrote:
>> XenoAmess has updated the pull request incrementally with five additional
>> commits since the last revision:
>>
>> - clean out tests
>> - Remove 'randomness' keyword.
>> - Cleanup and commenting.
>> - initial rewrite of
On Thu, 10 Mar 2022 16:22:29 GMT, XenoAmess wrote:
>> test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 116:
>>
>>> 114: }
>>> 115:
>>> 116: void putN(Map map, int n) {
>>
>> @stuart-marks well we know this is correct for WeakHashMap when n <
>> IntegerCache.high because we
On Thu, 10 Mar 2022 19:35:16 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Thu, 10 Mar 2022 22:29:48 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Leave public for the time being
>
> src/java.base/share/classes/java/lang/runtime/Carrier.java line 346:
>
>>
On Wed, 9 Mar 2022 07:47:19 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/utilities/hashtable.hpp line 42:
>
>> 40:
>> 41: LP64_ONLY(unsigned int _gap;)
93 matches
Mail list logo
