Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes [v2]

> Can I please get a review of this change which handles > https://bugs.openjdk.java.net/browse/JDK-8283411? > > The commit here moves the temporary byte array from being a member of the > class to a local variable within the `skip` method which is the only place > where it is used as a

Re: RFR: 8283426: Fix 'exeption' typo

On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated type `exeption` Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes

On Sun, 20 Mar 2022 04:24:07 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which handles > https://bugs.openjdk.java.net/browse/JDK-8283411? > > The commit here moves the temporary byte array from being a member of the > class to a local variable within the `skip` method

Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes

Hello, Not sure how often skip is actually used so it might not matter, but this change would increase allocations if skip is called regularly. Not sure if EA can prevent that if it is only medium hot and therefore the callsite is not compiled or inlined? An alternative would be to make this

Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes

Hello Bernd, On 20/03/22 5:00 pm, Bernd Eckenfels wrote: Hello, Not sure how often skip is actually used so it might not matter, but this change would increase allocations if skip is called regularly. I had given this a thought before changing it. The skip doesn't get called in a regular

Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes [v2]

On Sun, 20 Mar 2022 13:53:34 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use Alan's suggestion and allocate less than 512 bytes if possible. Plus >> copyright year fix. > >

RFR: 8283426: Fix 'exeption' typo

Fix repeated type `exeption` - Commit messages: - [PATCH] Typo 'Exeption' instead of 'Exception' Changes: https://git.openjdk.java.net/jdk/pull/7879/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7879=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283426 Stats:

Re: RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes

On Sun, 20 Mar 2022 04:24:07 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which handles > https://bugs.openjdk.java.net/browse/JDK-8283411? > > The commit here moves the temporary byte array from being a member of the > class to a local variable within the `skip` method

Re: RFR: 8283426: Fix 'exeption' typo

On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated type `exeption` Looks good to me. Thanks! - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown [v5]

On Thu, 10 Feb 2022 04:30:34 GMT, Tagir F. Valeev wrote: >> See the bug description for details. >> >> I propose a simple solution. Let's allow ArraySpliterator to be non-SIZED >> and report artificial estimatedSize(), much bigger than the real one. This >> will allow AbstractSpliterator and

Re: RFR: JDK-8283415: Update java.lang.ref to use sealed classes

On Sat, 19 Mar 2022 22:30:13 GMT, Joe Darcy wrote: > Another refactoring to use sealed classes where possible, this time in the > java.lang.ref package. > > Copyright dates will be updated, if needed, before a push. Marked as reviewed by alanb (Reviewer). - PR:

Re: RFR: JDK-8283415: Update java.lang.ref to use sealed classes

On Sun, 20 Mar 2022 16:28:36 GMT, Alan Bateman wrote: >> Another refactoring to use sealed classes where possible, this time in the >> java.lang.ref package. >> >> Copyright dates will be updated, if needed, before a push. > > Marked as reviewed by alanb (Reviewer). PS @AlanBateman and

CSR creation request for JDK-8283237

Hello, I hereby request the creation of a CSR request for bug 8283237 by a jdk project author or committer, with the following contents: CSR of: JDK-8283237 Component: core-libs Subcomponent: java.lang.invoke Compatibility Kind: source

RFR: JDK-8283416: Update java.lang.invoke.MethodHandle to use sealed classes

Small refactoring to use sealed classes in the MethodHandle implementation hierarchy. DelegatingMethodHandle is non-sealed rather than sealed since it has two subclasses, one defined as a nested class and only a separate type in the same package. The permits clause does not allow listed those

Re: RFR: 8282162: [vector] Optimize vector negation API

On Sat, 19 Mar 2022 02:34:55 GMT, Jie Fu wrote: >> The current vector `"NEG"` is implemented with substraction a vector by zero >> in case the architecture does not support the negation instruction. And to >> fit the predicate feature for architectures that support it, the masked >> vector

Re: RFR: 8283426: Fix 'exeption' typo

On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated typo `exeption` Looks good. Thanks for cleaning this up. - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo

On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated typo `exeption` Good grief! I wouldn't have expected it to be so widespread. Thanks for noticing and fixing. - Marked as reviewed by wetmore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: JDK-8283416: Update java.lang.invoke.MethodHandle to use sealed classes

On Mon, 21 Mar 2022 04:04:45 GMT, Athijegannathan Sundararajan wrote: > "DelegatingMethodHandle is non-sealed rather than sealed since it has two > subclasses, one defined as a nested class and only a separate type in the > same package. The permits clause does not allow listed those two

Re: RFR: JDK-8283416: Update java.lang.invoke.MethodHandle to use sealed classes

On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote: > Small refactoring to use sealed classes in the MethodHandle implementation > hierarchy. > > DelegatingMethodHandle is non-sealed rather than sealed since it has two > subclasses, one defined as a nested class and only a separate type in the

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v10]

On Fri, 18 Mar 2022 16:16:31 GMT, Jim Laskey wrote: >> We propose to provide a runtime anonymous carrier class object generator; >> java.lang.runtime.Carrier. This generator class is designed to share >> anonymous classes when shapes are similar. For example, if several clients >> require