On Thu, 24 Mar 2022 07:01:43 GMT, XenoAmess wrote:
>> src/java.base/share/classes/java/util/Collections.java line 5822:
>>
>>> 5820: * @param the type of keys maintained by this map
>>> 5821: * @param the type of mapped values
>>> 5822: * @return initial
On Wed, 23 Mar 2022 18:41:59 GMT, XenoAmess wrote:
> 8186958: Need method to create pre-sized HashMap
src/java.base/share/classes/java/util/Collections.java line 5836:
> 5834: * @param the type of keys maintained by this map
> 5835: * @param the type of mapped
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
fix javadoc's @return
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
On Thu, 24 Mar 2022 11:14:54 GMT, David Holmes wrote:
>>> That isn't what is returned.
>>
>> @dholmes-ora Yes it isn't actually. but I cannot find a better description
>> string for it.
>>
>> "the pre-processed raw initial capacity for HashMap based classes." is more
>> exact but sounds
On Thu, 24 Mar 2022 11:15:12 GMT, David Holmes wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc's @return
>
> src/java.base/share/classes/java/util/Collections.java line 5836:
>
>> 5834: * @param
On Thu, 24 Mar 2022 00:44:02 GMT, liach wrote:
> Note that the methods may have to go to somewhere else in `java.util` if
> `Collections` cannot be loaded too early during startup, as HashMap is loaded
> very early
I'm afraid you are correct... moved the calculation function into HashMap
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
move the static functions to map classes themselves.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
delete a space.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
use jmh Blackhole
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
On Wed, 23 Mar 2022 21:04:52 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use jmh Blackhole
>
> test/jdk/java/util/Collections/CalculateHashMapCapacityTestJMH.java line 42:
>
>> 40: public class
On Wed, 23 Mar 2022 14:06:56 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Thu, 24 Mar 2022 11:14:54 GMT, David Holmes wrote:
>>> That isn't what is returned.
>>
>> @dholmes-ora Yes it isn't actually. but I cannot find a better description
>> string for it.
>>
>> "the pre-processed raw initial capacity for HashMap based classes." is more
>> exact but sounds
On Wed, 23 Feb 2022 22:33:42 GMT, liach wrote:
> Replaces simple `for (Map.Entry entry : map.entrySet())` with
> `map.forEach((k, v) ->)` calls. This change is better for thread-safety and
> reduces allocation for some map implementations.
>
> A more in-depth description of benefits is
On Wed, 23 Mar 2022 02:17:22 GMT, Vladimir Kozlov wrote:
>> Fei Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright header
>
> Update looks good.
> Testing results are also good.
@vnkozlov @shipilev : Thanks for
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests
On Mon, 8 Nov 2021 11:17:47 GMT, Fei Yang wrote:
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board.
On Wed, 23 Mar 2022 21:59:02 GMT, Valerie Peng wrote:
>> I see.
>>
>> Would you mind add a comment about the provider loading impact, just in case
>> someone else have similar questions in the future?
>
> Sure, I can do that. Will add a comment about this.
Thank you. I have no more comment
On Wed, 23 Mar 2022 22:48:41 GMT, Valerie Peng wrote:
>> It's been several years since we increased the default key sizes. Before
>> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
>> the Commercial National Security Algorithm Suite which suggests:
>>
>> - SHA-384
On Thu, 24 Mar 2022 04:52:16 GMT, David Holmes wrote:
> That isn't what is returned.
@dholmes-ora Yes it isn't actually. but I cannot find a better description
string for it.
"the pre-processed raw initial capacity for HashMap based classes." is more
exact but sounds weird.
Have you any
On Wed, 23 Mar 2022 06:55:50 GMT, Tobias Hartmann wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 22 commits:
>>
>> - 8279508: Using an explicit scratch register since rscratch1 is bound to
>> r10 and
On Thu, 24 Mar 2022 14:54:39 GMT, Roger Riggs wrote:
> It would be clearer with a comment on the constant or use the expression (the
> compiler will evaluate it). `Integer.MAX_VALUE / 4 * 3`.
@RogerRiggs
No, as `Integer.MAX_VALUE / 4 * 3` is actually 1610612733,
and
On Thu, 24 Mar 2022 16:44:50 GMT, XenoAmess wrote:
>> src/java.base/share/classes/java/util/HashMap.java line 2556:
>>
>>> 2554: */
>>> 2555: static int calculateHashMapCapacity(int expectedSize) {
>>> 2556: if (expectedSize >= 1610612736) {
>>
>> It would be clearer with a
On Thu, 24 Mar 2022 17:09:21 GMT, Roger Riggs wrote:
> I'm not too picky about how it is documented, as long as it is clear how the
> number 1610612733 is computed and why its the correct number. And I think
> that's working backward from Integer.MAX_VALUE. As for its precision, its
> almost
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- update jmh
- refine javadoc; refine implement when expectedSize < 0
-
Changes:
- all:
On Thu, 24 Mar 2022 16:46:11 GMT, XenoAmess wrote:
>>> It would be clearer with a comment on the constant or use the expression
>>> (the compiler will evaluate it). `Integer.MAX_VALUE / 4 * 3`.
>>
>> @RogerRiggs
>>
>> No, as `Integer.MAX_VALUE / 4 * 3` is actually 1610612733,
>>
>> and
On Thu, 24 Mar 2022 12:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> delete a space.
src/java.base/share/classes/java/util/HashMap.java line
> 8186958: Need method to create pre-sized HashMap
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine javadoc about default load factor
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7928/files
- new:
On Thu, 24 Mar 2022 14:36:36 GMT, Roger Riggs wrote:
> This method should say it is using a default load factor (0.75).
@RogerRiggs done.
> The default load factor should be mentioned.
@RogerRiggs done.
-
PR: https://git.openjdk.java.net/jdk/pull/7928
Hi Sverre,
The output comes from quite old jpackage (jdk15, I guess). Please try
jpackage from the newer jdk (the latest one would be the best option).
They don't have this issue.
- Alexey
On 3/23/2022 10:01 AM, Sverre Moe wrote:
Could jpackage instruct WiX when building a native
On Tue, 22 Mar 2022 10:09:40 GMT, Claes Redestad wrote:
>> Xin Liu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains six additional commits
>>
> It's been several years since we increased the default key sizes. Before
> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
> the Commercial National Security Algorithm Suite which suggests:
>
> - SHA-384 for secure hashing
> - AES-256 for symmetric encryption
> -
The issue was caused by the difference on handling control characters between
the parser and serializer. The parser rejected control characters while the
serializer converted them to NCRs. The fix is for the later to be aligned with
the parser, reporting error upon encountering control
On Thu, 24 Mar 2022 17:48:23 GMT, Maurizio Cimadamore
wrote:
>> make/test/BuildMicrobenchmark.gmk line 97:
>>
>>> 95: SRC := $(MICROBENCHMARK_SRC), \
>>> 96: BIN := $(MICROBENCHMARK_CLASSES), \
>>> 97: JAVAC_FLAGS := --add-exports
>>> java.base/sun.security.util=ALL-UNNAMED
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
On Thu, 24 Mar 2022 13:10:20 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop redundant javadoc statements re. handling of nulls
>> (handling of nulls is specified once and for all in
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Thu, 24 Mar 2022 13:00:12 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop redundant javadoc statements re. handling of nulls
>> (handling of nulls is specified once and for all in
On Wed, 23 Mar 2022 19:41:58 GMT, Andrey Turbanov wrote:
>> Fix repeated typo `exeption`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8283426: Fix 'exeption' typo
>
> Co-authored-by: Alexey Ivanov
>
Hi Sverre,
Oh, I misunderstood the problem. I though the issue was with parsing WiX
version string, but the problem is that jpackage doesn't like the value
of --version cli parameter.
On windows this value should satisfy constrains of MSI ProductVersion
property [1]:
The format of the string
> Please review this change to the java/util/prefs/AddNodeChangeListener.jar
> test.
>
> Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh
> Preferences on each test run, MacOS does not seem to honor this, and still
> stores prefs in Library/.
>
> This test has long
On Wed, 23 Mar 2022 17:29:04 GMT, Naoto Sato wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add test failure message to 'couldn't remove' RuntimeException
>
>
On Thu, 24 Mar 2022 06:41:11 GMT, Xue-Lei Andrew Fan wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment regarding possible deadlocks.
>
>
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
> same package. The permits clause does not allow
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Thu, 24 Mar 2022 19:19:34 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote:
> Fix repeated typo `exeption`
This pull request has now been integrated.
Changeset: dc5a65ab
Author:Andrey Turbanov
URL:
https://git.openjdk.java.net/jdk/commit/dc5a65ab378f0780f7760965f2b52cbbd7c62aad
Stats: 38 lines in
Hi,
This has been attempted on Java 15, Java 16 and the latest Java 17.
This is the output from Java 17
14:46:49
C:\cygwin64\home\build\jenkins-test\workspace\our-awesome-project_sverre_SF-99>gradlew.bat
--no-daemon --version
14:46:51
14:46:51
On Thu, 24 Mar 2022 18:58:43 GMT, Joe Darcy wrote:
>> Small refactoring to use sealed classes in the MethodHandle implementation
>> hierarchy.
>>
>> DelegatingMethodHandle is non-sealed rather than sealed since it has two
>> subclasses, one defined as a nested class and only a separate type
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Thu, 24 Mar 2022 19:17:40 GMT, Jorn Vernee wrote:
>> I'd suggest at least adding `--enable-preview` as an argument when running
>> benchmarks through the build system in that case. I think this should do the
>> trick:
>>
>>
>> diff --git a/make/RunTests.gmk b/make/RunTests.gmk
>> index
On Thu, 24 Mar 2022 18:35:12 GMT, Jorn Vernee wrote:
>> Sure, this is problematic - but at the same time I don't think there's a
>> better way to deal with this? I'd prefer to defer this to a separate issue
>> (and I think the build team is in a much better position to suggest a better
>>
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with
On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote:
> Proposing to deprecate the constructors in the `java.util.Locale` class.
> There is already a factory method and a builder to return singletons, so
> there is no need to have constructors anymore unless one purposefully wants
> to create
This creates a regression test for JDK-8240734. This was once blocked
by a time stamp issue which has been resolved by: [JDK-8276766
](https://bugs.openjdk.java.net/browse/JDK-8276766)
We found the issue can always be produced with at least 64 modules.
Note that we need to add the --date jmod
On Fri, 25 Mar 2022 00:18:54 GMT, Stuart Marks wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to
On Fri, 25 Mar 2022 04:17:57 GMT, Joe Darcy wrote:
> Working down the list of candidates to be sealed, this time
> IllegalFormatException.
>
> Please also review the companion CSR:
> https://bugs.openjdk.java.net/browse/JDK-8283669
Marked as reviewed by iris (Reviewer).
-
PR:
> This creates a regression test for
> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was
> once blocked
> by a time stamp issue which has been resolved by: [JDK-8276766
> ](https://bugs.openjdk.java.net/browse/JDK-8276766)
>
> We found the issue can be produced stably
Working down the list of candidates to be sealed, this time
IllegalFormatException.
Please also review the companion CSR:
https://bugs.openjdk.java.net/browse/JDK-8283669
-
Commit messages:
- JDK-8283668: Update IllegalFormatException to use sealed classes
Changes:
> This creates a regression test for JDK-8240734. This was once blocked
> by a time stamp issue which has been resolved by: [JDK-8276766
> ](https://bugs.openjdk.java.net/browse/JDK-8276766)
>
> We found the issue can always be produced with at least 64 modules.
> Note that we need to add the
On Wed, 2 Mar 2022 00:13:41 GMT, Valerie Peng wrote:
> It's been several years since we increased the default key sizes. Before
> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
> the Commercial National Security Algorithm Suite which suggests:
>
> - SHA-384 for
Proposing to deprecate the constructors in the `java.util.Locale` class. There
is already a factory method and a builder to return singletons, so there is no
need to have constructors anymore unless one purposefully wants to create
`ill-formed` Locale objects, which is discouraged. We cannot
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to be aligned
> with
67 matches
Mail list logo
