On Fri, 8 Apr 2022 12:20:32 GMT, Claes Redestad wrote:
>> A few additional enhancements aiming to improve VH performance in the
>> interpreter:
>>
>> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
>> 40->48) but removes an object and an indirection on any
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
Marked as reviewed
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote:
> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
> JDK version to target.
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the
> Add support to compress bits and expand bits of `int` and `long` values, see
> Hacker's Delight (2nd edition), section 7.4.
>
> Compressing or expanding bits of an `int` or `long` value can be composed to
> enable general permutations, and the "sheep and goats" operation (SAG) see
> Hacker's
> Please find enclosed a patch for
> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>
> My analysis is that the test fails intermittently because the `FileChannel`
> created by the test is garbage collected too early, which releases the
> associated lock before
On Fri, 8 Apr 2022 17:09:42 GMT, Alan Bateman wrote:
> Looks fine, you can drop use of getAbsolutePath if you want to, not important
> here.
Done - used `File::toPath` since `lock` is a `File`.
-
PR: https://git.openjdk.java.net/jdk/pull/8168
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
LGTM
-
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
Core libs changes
On Fri, 8 Apr 2022 16:39:31 GMT, Vladimir Kozlov wrote:
>> Hi Vladimir (@vnkozlov),
>>
>> Incorporated all the suggestions you made in the previous review and pushed
>> a new commit.
>> Please let me know if anything else is needed.
>>
>> Thanks,
>> Vamsi
>
> @vamsi-parasa I got failures in
On Fri, 8 Apr 2022 16:37:07 GMT, Daniel Fuchs wrote:
> Please find enclosed a patch for
> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>
> My analysis is that the test fails intermittently because the `FileChannel`
> created by the test is garbage collected too
On Thu, 7 Apr 2022 03:33:02 GMT, Vicente Romero wrote:
> We recently updated our ASM version to 9.2 and just this week version 9.3 was
> announced with support for JDK19 so it makes sense to update to this last
> version.
>
> Thanks in advance for the reviews,
> Vicente
This pull request has
> Please find enclosed a patch for
> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>
> My analysis is that the test fails intermittently because the `FileChannel`
> created by the test is garbage collected too early, which releases the
> associated lock before
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
On Fri, 8 Apr 2022 18:32:06 GMT, Sandhya Viswanathan
wrote:
> My suggestion is to keep the -ve path assembly optimization in this patch.
> When the optimization in IR is introduced, the assembly could then be
> simplified as suggested by @merykitty.
Okay. Lets do that as part of JDK-8282365.
On Fri, 8 Apr 2022 17:08:25 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch for
>> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>>
>> My analysis is that the test fails intermittently because the `FileChannel`
>> created by the test is garbage
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
On Fri, 8 Apr 2022 17:20:36 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch for
>> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>>
>> My analysis is that the test fails intermittently because the `FileChannel`
>> created by the test is garbage
On Fri, 8 Apr 2022 01:59:10 GMT, Quan Anh Mai wrote:
> Personally, I think the optimisation for `div < 0` should be handled by the
> mid-end optimiser, which will not only give us the advantages of dead code
> elimination, but also global code motion. I would suggest the backend only
> doing
On Thu, 7 Apr 2022 18:29:22 GMT, Paul Sandoz wrote:
>> Add support to compress bits and expand bits of `int` and `long` values, see
>> Hacker's Delight (2nd edition), section 7.4.
>>
>> Compressing or expanding bits of an `int` or `long` value can be composed to
>> enable general
On Thu, 7 Apr 2022 03:33:02 GMT, Vicente Romero wrote:
> We recently updated our ASM version to 9.2 and just this week version 9.3 was
> announced with support for JDK19 so it makes sense to update to this last
> version.
>
> Thanks in advance for the reviews,
> Vicente
Looks okay. Most of
On Fri, 8 Apr 2022 16:44:15 GMT, Mandy Chung wrote:
>> We recently updated our ASM version to 9.2 and just this week version 9.3
>> was announced with support for JDK19 so it makes sense to update to this
>> last version.
>>
>> Thanks in advance for the reviews,
>> Vicente
>
> Looks okay.
On Thu, 7 Apr 2022 22:44:19 GMT, Ioi Lam wrote:
> During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
> usually null. However, if a signed class is loaded, `resourceCache` will
> point to a `java.lang.ref.SoftReference`. Although rare (we have never seen
> this during our
On Fri, 8 Apr 2022 07:08:29 GMT, Alan Bateman wrote:
>> During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
>> usually null. However, if a signed class is loaded, `resourceCache` will
>> point to a `java.lang.ref.SoftReference`. Although rare (we have never seen
>> this
On Thu, 7 Apr 2022 22:44:19 GMT, Ioi Lam wrote:
> During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
> usually null. However, if a signed class is loaded, `resourceCache` will
> point to a `java.lang.ref.SoftReference`. Although rare (we have never seen
> this during our
> Add support to compress bits and expand bits of `int` and `long` values, see
> Hacker's Delight (2nd edition), section 7.4.
>
> Compressing or expanding bits of an `int` or `long` value can be composed to
> enable general permutations, and the "sheep and goats" operation (SAG) see
> Hacker's
On Tue, 5 Apr 2022 23:05:47 GMT, Joe Wang wrote:
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
> classes where the checks were really about equality or whether they were the
> exact class types. It was why they worked nonetheless even though some of
> them were
Please find enclosed a patch for
`8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
My analysis is that the test fails intermittently because the `FileChannel`
created by the test is garbage collected too early, which releases the
associated lock before the
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
On Fri, 8 Apr 2022 16:50:45 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporated review comments
>
> test/jdk/java/util/logging/CheckZombieLockTest.java line 247:
>
>> 245:
On Fri, 8 Apr 2022 01:05:33 GMT, Srinivas Vamsi Parasa
wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>>
This is the implementation of JEP 425: Virtual Threads (Preview); TBD which JDK
version to target.
We will refresh this PR periodically to pick up changes and fixes from the loom
repo.
Most of the new mechanisms in the HotSpot VM are disabled by default and
require running with
On Fri, 8 Apr 2022 00:55:50 GMT, Srinivas Vamsi Parasa
wrote:
>> I have few comments.
>
> Hi Vladimir (@vnkozlov),
>
> Incorporated all the suggestions you made in the previous review and pushed a
> new commit.
> Please let me know if anything else is needed.
>
> Thanks,
> Vamsi
On Fri, 8 Apr 2022 08:13:33 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that adds dedicated filler objects to
> the VM?
>
> Currently, when formatting areas of dead objects all gcs use instances of
> j.l.Object and int-arrays.
>
> This has the drawback of
On Fri, 8 Apr 2022 01:05:33 GMT, Srinivas Vamsi Parasa
wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>>
On 08/04/2022 07:27, Andrey Turbanov wrote:
Hello.
I found suspicious check in all 4 JDK implementations of
java.nio.file.FileSystem#getPathMatcher
https://github.com/openjdk/jdk/blob/8c1870521815a24fd12480e73450c2201542a442/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java#L178
Let's take advantage of Java 7 language feature - "Catching Multiple Exception
Types".
It simplifies code. Reduces duplication.
Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' statement
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into
On Thu, 7 Apr 2022 22:44:19 GMT, Ioi Lam wrote:
> During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
> usually null. However, if a signed class is loaded, `resourceCache` will
> point to a `java.lang.ref.SoftReference`. Although rare (we have never seen
> this during our
On Fri, 8 Apr 2022 at 06:57, Michael Kuhlmann wrote:
> Good morning!
>
> On 4/7/22 23:59, Kasper Nielsen wrote:
> > Hi Michael,
> >
> > I don't really have an opinion on how you obtain a logger. But one
> > particular
> > use-case I've had was that I would like to perform some access checks
>
Hello.
I found suspicious check in all 4 JDK implementations of
java.nio.file.FileSystem#getPathMatcher
https://github.com/openjdk/jdk/blob/8c1870521815a24fd12480e73450c2201542a442/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java#L178
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote:
> Currently the vector load with mask when the given index happens out of the
> array boundary is implemented with pure java scalar code to avoid the IOOBE
> (IndexOutOfBoundaryException). This is necessary for architectures that do
> not
On Wed, 6 Apr 2022 16:02:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use (double) DEFAULT_LOAD_FACTOR instead of 0.75
Regarding the scope of
On Fri, 8 Apr 2022 15:05:54 GMT, Maurizio Cimadamore
wrote:
> TestAdaptVarHandles
Thanks for reviewing, Maurizio. I ran the micros you suggested and I detect no
change whatsoever at peak performance. With `-Xint` there are some small
improvements in line with the results above.
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's release notes:
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote:
>> This is to upgrade the CLDR data from version 39 to version 41 which was
>> released yesterday. The vast majority of the changes are basically replacing
>> the CLDR data, along with tools/testcase alignments. Here is the link to
>> CLDR
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
On Fri, 8 Apr 2022 00:55:50 GMT, Srinivas Vamsi Parasa
wrote:
>> I have few comments.
>
> Hi Vladimir (@vnkozlov),
>
> Incorporated all the suggestions you made in the previous review and pushed a
> new commit.
> Please let me know if anything else is needed.
>
> Thanks,
> Vamsi
>
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote:
>> This is to upgrade the CLDR data from version 39 to version 41 which was
>> released yesterday. The vast majority of the changes are basically replacing
>> the CLDR data, along with tools/testcase alignments. Here is the link to
>> CLDR
On Fri, 8 Apr 2022 22:17:23 GMT, Srinivas Vamsi Parasa
wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>>
On Fri, 8 Apr 2022 12:20:32 GMT, Claes Redestad wrote:
>> A few additional enhancements aiming to improve VH performance in the
>> interpreter:
>>
>> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
>> 40->48) but removes an object and an indirection on any
On Wed, 6 Apr 2022 16:02:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use (double) DEFAULT_LOAD_FACTOR instead of 0.75
Quick question: If the
On Fri, 8 Apr 2022 12:20:32 GMT, Claes Redestad wrote:
>> A few additional enhancements aiming to improve VH performance in the
>> interpreter:
>>
>> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
>> 40->48) but removes an object and an indirection on any
On Fri, 8 Apr 2022 09:26:08 GMT, Alan Bateman wrote:
> I think this looks okay. Can you say how long the test runs for you? It
> creates 130 JMOD files and I'm just wondering if the default timeout is
> enough when running with debug builds.
The following is the test result on linux x86 with
Hi all,
can I have reviews for this change that adds dedicated filler objects to the
VM?
Currently, when formatting areas of dead objects all gcs use instances of
j.l.Object and int-arrays.
This has the drawback of not being easily able to discern whether a given
object is actually dead
On Wed, 30 Mar 2022 01:55:30 GMT, Dongbo He wrote:
>> This creates a regression test for
>> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was
>> once blocked
>> by a time stamp issue which has been resolved by: [JDK-8276766
>>
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
On Fri, 8 Apr 2022 12:12:06 GMT, ExE Boss wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplified as suggested by @ExE-Boss
>
> src/java.base/share/classes/java/lang/invoke/IndirectVarHandle.java line 104:
>
A few additional enhancements aiming to improve VH performance in the
interpreter:
- Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
40->48) but removes an object and an indirection on any instance actually used
- and might avoid allocating the `MethodHandle[]`
> A few additional enhancements aiming to improve VH performance in the
> interpreter:
>
> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
> 40->48) but removes an object and an indirection on any instance actually
> used - and might avoid allocating the
On Fri, 8 Apr 2022 12:16:17 GMT, Claes Redestad wrote:
>> A few additional enhancements aiming to improve VH performance in the
>> interpreter:
>>
>> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
>> 40->48) but removes an object and an indirection on any
On Wed, 6 Apr 2022 16:28:21 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Wed, 6 Apr 2022 16:28:21 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Wed, 6 Apr 2022 16:28:21 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
63 matches
Mail list logo
