Changeset: 0b3660c68262
Author:alanb
Date: 2009-04-15 14:53 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b3660c68262
6795561: (bf) CharBuffer.subSequence() uses wrong capacity value for new buffer
Reviewed-by: sherman, iris
!
Changeset: 99fc62f032a7
Author:ramap
Date: 2009-03-09 15:32 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/99fc62f032a7
6536193: Fix the flaw in UTF8XmlOutput
Reviewed-by: tbell
!
src/share/classes/com/sun/xml/internal/bind/v2/runtime/output/UTF8XmlOutput.java
6831461: (sample) Copy -r fails with IllegalArgumentexception:
'maxDepth' is negative
Sherman - this is bug in the Copy sample code that one of the tech
writers ran into. For the -r option the sample code is calling
walkFileTree with a max depth of -1 instead of Integer.MAX_VALUE. Not
sure
6829503: addShutdownHook fails if called after shutdown has commenced.
Webrev at:
http://cr.openjdk.java.net/~mchung/6829503/webrev.00/
I change the Shutdown#add method to take the registerShutdownInProgress
parameter. If set to true, the specified shutdown hook is allowed to be
registered
Thanks for your quick response on this.
A quick review says: looks good to me.
Someone should give it a more thorough review.
-
The solution of allowing shutdown hooks of a particular type to be added
during shutdown before that slot is reached is clever.
I'm sure there are use cases for
Hi Mandy,
Looks good but I have one query.
At the top-level there are 3 shutdown hooks:
- console hook
- application hooks
- deleteOnExit hook
and they run in this order. The deleteOnExit hook can be added when
shutdown is in progress, so this allows first-use of deleteOnExit during
an
Hi Martin,
Thanks for the quick review.
Users should only add their shutdown hooks via the
System.addShutdownHook() method. java.lang.Shutdown is an
implementation class for registering internal hooks besides application
shutdown hooks - including the shutdown hook for Console and
