Re: REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-21 Thread Tim Bell
Hi Martin: It would be good for me to generate webrevs. But the webrev tools should support mq out of the box. I want a single supported command that will turn a mq patch into a webrev on cr.openjdk.java.net. Thanks, I am always looking for feedback on the cr.ojn server. That is a worthy

Re: Review request for 6829503

2009-04-21 Thread Alan Bateman
Mandy Chung wrote: Alan, Thanks for the review and comments. Here is the revised webrev incorporating your comments. See below for my inlined reply. http://cr.openjdk.java.net/~mchung/6829503/webrev.01/ Alan Bateman wrote: Good work! It mostly looks good to me and I've only a few

Re: Review request for 6829503

2009-04-21 Thread Mandy Chung
Thanks Alan. Mandy Alan Bateman wrote: Mandy Chung wrote: Alan, Thanks for the review and comments. Here is the revised webrev incorporating your comments. See below for my inlined reply. http://cr.openjdk.java.net/~mchung/6829503/webrev.01/ Alan Bateman wrote: Good work! It mostly

Re: REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-21 Thread David Holmes - Sun Microsystems
Hi Jeremy, In the case where the exception is thrown this would be definitely slower :) But I would have expected some improvement otherwise as this is a native call with all the ensuing checks and transitions. C'est la vie. It was just a thought. :) Cheers, David Jeremy Manson said the