Re: Replacement of Quicksort in java.util.Arrays with Dual-Pivot Quicksort: improvements

2009-09-15 Thread Vladimir Yaroslavskiy
Hello Andrew, It means that the threshold = 7 is optimal for combination: insertion sort + Bentley's implementation, and 17 - for Insertion + Dual-Pivot Quicksort. I can add that for Dual-Pivot Quicksort old threshold = 7 shows slower results than 17. Other values, such as 25, 27, show similar

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-09-15 Thread Martin Buchholz
Martin, Just to be clear, I approve this change of tightening the hashCode specifications for Byte, Short, and Character going back into JDK 7. I added a test case, as I half-promised, http://cr.openjdk.java.net/~martin/webrevs/openjdk7/hashCode-spec/ This test is particularly

Re: [OpenJDK 2D-Dev] Review Request for 6879044

2009-09-15 Thread Mandy Chung
Hi Andrew, Why not just use a straightforward static assignment to a final variable as before? A simple AWT app creates 79 loggers on solaris-i586 and 34 loggers on windows-i586. SwingSet2 creates a total of 85 loggers on solaris-i586 and 35 on windows-i586. Improvement on client startup

Re: AWT Dev Review Request for 6879044

2009-09-15 Thread Mandy Chung
Oleg Sukhodolsky wrote: On Mon, Sep 14, 2009 at 9:19 PM, Mandy Chung mandy.ch...@sun.com wrote: I thought that it is possible to log int a file using default logger, Not the default logging configuration. thus I was surprised that description of PlatformLogger says about System.err. I'd

hg: jdk7/tl/langtools: 6860965: Project Coin: binary literals; ...

2009-09-15 Thread jonathan . gibbons
Changeset: 69eaccd3ea85 Author:jjg Date: 2009-09-15 18:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/69eaccd3ea85 6860965: Project Coin: binary literals 6860973: Project Coin: Underscores in literals Summary: [Portions contributed by Bruce Chapman] Reviewed-by:

hg: jdk7/tl/jdk: 6882363: 4/4 typos in java.util.logging javadocs

2009-09-15 Thread daniel . daugherty
Changeset: e8c2dd4b8bac Author:dcubed Date: 2009-09-15 22:11 -0600 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8c2dd4b8bac 6882363: 4/4 typos in java.util.logging javadocs Summary: Fix typos, some grammar and some inconsistencies in phrasing. Reviewed-by: tbell !