Re: Core review request for 5062288 (reflect) Core reflection uses raw types when it could be using wildcards

2009-10-06 Thread Alan Bateman
Joseph D. Darcy wrote: Hello. Please review my changes to address: 5062288 (reflect) Core reflection uses raw types when it could be using wildcards http://cr.openjdk.java.net/~darcy/5062288.0/ This changeset removes most of the raw types warnings in core reflection, java.lang.Class and

hg: jdk7/tl/jdk: 5062288: (reflect) Core reflection uses raw types when it could be using wildcards

2009-10-06 Thread joe . darcy
Changeset: 572791538be5 Author:darcy Date: 2009-10-06 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/572791538be5 5062288: (reflect) Core reflection uses raw types when it could be using wildcards Reviewed-by: alanb ! src/share/classes/java/lang/Class.java !

Request for review: Race conditions in java.nio.charset.Charset

2009-10-06 Thread Ulf Zibis
I.) Internal charset cache will be corrupted in theoretical race conditions: Startpoint: cache1 -- Charset1 cache2 -- Charset2 Scenario 1: - Thread1 asks for Charset2 via Charset.forName(Charset2). - If Thread1 is interrupted after code line: cache2 = cache1 in method lookup2(String

hg: jdk7/tl/jdk: 6888802: sun.misc.BootClassLoaderHook.getBootstrapPaths stack overflow

2009-10-06 Thread mandy . chung
Changeset: 1b81fc851b20 Author:mchung Date: 2009-10-06 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1b81fc851b20 602: sun.misc.BootClassLoaderHook.getBootstrapPaths stack overflow Summary: Fixed sun.misc.BootClassLoaderHook.getBootstrapPaths calls

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-06 Thread David Holmes - Sun Microsystems
Hi Joe, I thought the point that Jason Mehrens was making was that this: +public static String toString(Object o) { +String.valueOf(o); +} is actually pointless. Why introduce such redundancy when people can just use String.valueOf directly ? This doesn't provide any benefit.

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-06 Thread Joe Darcy
David Holmes - Sun Microsystems wrote: Hi Joe, I thought the point that Jason Mehrens was making was that this: +public static String toString(Object o) { +String.valueOf(o); hat Jason Mehrens was making was that this: +public static String toString(Object o) { +

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-06 Thread David M. Lloyd
On 10/06/2009 06:43 PM, Joe Darcy wrote: David Holmes - Sun Microsystems wrote: Hi Joe, I thought the point that Jason Mehrens was making was that this: + public static String toString(Object o) { + String.valueOf(o); hat Jason Mehrens was making was that this: + public static String

Adding methods to logger in jdk 7

2009-10-06 Thread Paulo Levi
Logger has the utility method severe, warning etc so you can use the various log levels without using the longer log method... I'd like some more overloadings, for adding a throwable, besides a string for those methods. Logger.getLogger(getClass().getName()).severe(string, throwable);

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-06 Thread David Holmes - Sun Microsystems
Joe, Joe Darcy said the following on 10/07/09 09:43: David Holmes - Sun Microsystems wrote: I thought the point that Jason Mehrens was making was that this: +public static String toString(Object o) { +String.valueOf(o); hat Jason Mehrens was making was that this: +public

Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-06 Thread Martin Buchholz
I also vote against Objects.toString(). Foo.valueOf might not be the best name, (I'll resist the urge to suggest a better one) but it is an entrenched convention, and so cannot be considered a wart to be fixed. Martin On Tue, Oct 6, 2009 at 20:14, David Holmes - Sun Microsystems