Joseph D. Darcy wrote:
Hello.
Please review my changes to address:
5062288 (reflect) Core reflection uses raw types when it could be
using wildcards
http://cr.openjdk.java.net/~darcy/5062288.0/
This changeset removes most of the raw types warnings in core
reflection, java.lang.Class and
Changeset: 572791538be5
Author:darcy
Date: 2009-10-06 13:31 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/572791538be5
5062288: (reflect) Core reflection uses raw types when it could be using
wildcards
Reviewed-by: alanb
! src/share/classes/java/lang/Class.java
!
I.) Internal charset cache will be corrupted in theoretical race conditions:
Startpoint:
cache1 -- Charset1
cache2 -- Charset2
Scenario 1:
- Thread1 asks for Charset2 via Charset.forName(Charset2).
- If Thread1 is interrupted after code line: cache2 = cache1
in method lookup2(String
Changeset: 1b81fc851b20
Author:mchung
Date: 2009-10-06 15:14 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1b81fc851b20
602: sun.misc.BootClassLoaderHook.getBootstrapPaths stack overflow
Summary: Fixed sun.misc.BootClassLoaderHook.getBootstrapPaths calls
Hi Joe,
I thought the point that Jason Mehrens was making was that this:
+public static String toString(Object o) {
+String.valueOf(o);
+}
is actually pointless. Why introduce such redundancy when people can
just use String.valueOf directly ? This doesn't provide any benefit.
David Holmes - Sun Microsystems wrote:
Hi Joe,
I thought the point that Jason Mehrens was making was that this:
+public static String toString(Object o) {
+String.valueOf(o); hat Jason Mehrens was making was that this:
+public static String toString(Object o) {
+
On 10/06/2009 06:43 PM, Joe Darcy wrote:
David Holmes - Sun Microsystems wrote:
Hi Joe,
I thought the point that Jason Mehrens was making was that this:
+ public static String toString(Object o) {
+ String.valueOf(o); hat Jason Mehrens was making was that this:
+ public static String
Logger has the utility method severe, warning etc so you can use the
various log levels without using the longer log method...
I'd like some more overloadings, for adding a throwable, besides a
string for those methods.
Logger.getLogger(getClass().getName()).severe(string, throwable);
Joe,
Joe Darcy said the following on 10/07/09 09:43:
David Holmes - Sun Microsystems wrote:
I thought the point that Jason Mehrens was making was that this:
+public static String toString(Object o) {
+String.valueOf(o); hat Jason Mehrens was making was that this:
+public
I also vote against Objects.toString().
Foo.valueOf might not be the best name,
(I'll resist the urge to suggest a better one)
but it is an entrenched convention,
and so cannot be considered a wart to be fixed.
Martin
On Tue, Oct 6, 2009 at 20:14, David Holmes - Sun Microsystems
10 matches
Mail list logo