Re: Concatenated .gz files/streams

2010-05-23 Thread Martin Buchholz
First, let me apologize for my poor judgment back in 2006. Concatenated gzip members are clearly supported by rfc1952, the gzip command, and by the many votes for bug 4691425. The JDK should support this feature as well. One can argue this change doesn't go far enough, and that one should be able

Re: Concatenated .gz files/streams

2010-05-23 Thread Xueming Shen
Martin Buchholz wrote: One can argue this change doesn't go far enough, and that one should be able to perform operations that motivated the existence of the multiple member feature, like skip to the next gzip member and to inspect the filename and extra fields in the gzip header, but that's a

Re: Concatenated .gz files/streams

2010-05-23 Thread Martin Buchholz
Thanks for the improvements. Everything looks good to me, but here are some additional suggestions: Rename n to members to make it a little clearer. 38 int n = rnd.nextInt(10) + 1; Also use a random size with the GZIPInputStream constructor 69 GZIPInputStream gzis = new

hg: jdk7/tl/jdk: 2 new changesets

2010-05-23 Thread weijun . wang
Changeset: d01726854317 Author:weijun Date: 2010-05-24 09:28 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d01726854317 6948803: CertPath validation regression caused by SHA1 replacement root and MD2 disable feature Reviewed-by: xuelei, mullan !

hg: jdk7/tl/jdk: 4691425: GZIPInputStream fails to read concatenated .gz files

2010-05-23 Thread xueming . shen
Changeset: 41a5722e6e10 Author:sherman Date: 2010-05-24 00:39 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/41a5722e6e10 4691425: GZIPInputStream fails to read concatenated .gz files Summary: to support concatenated .gz streams Reviewed-by: martin !