Changeset: 2e0204644cf4
Author:alanb
Date: 2010-11-18 19:16 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2e0204644cf4
7000913: (bf) CharBuffer.wrap, slice, position, slice leads to CharBuffer with
incorrect offser
Reviewed-by: forax
!
6402006 FileInputStream.available() returns negative values when
reading a large file
Webrev at:
http://cr.openjdk.java.net/~mchung/6402006/webrev.00/
This fixes a bug in the windows implementation of io_util.c that ignores
the high-order doubleword of the file size in computing the end of
Alan, Kelly,
Would you please help review the patch that tries to address those
compiler warning
in zip area?
http://cr.openjdk.java.net/~sherman/6989471/webrev
http://cr.openjdk.java.net/%7Esherman/6989471/webrev/
I added some comments to document the fact that
Looks good to me. Thanks for doing this.
-kto
On Nov 18, 2010, at 2:03 PM, Xueming Shen wrote:
Alan, Kelly,
Would you please help review the patch that tries to address those
compiler warning
in zip area?
http://cr.openjdk.java.net/~sherman/6989471/webrev
I added some comments to
6631046: BufferedInputStream.available() reports negative int on very
large inputstream
Webrev at:
http://cr.openjdk.java.net/~mchung/6631046/webrev.00/
InputStream.available() returns an int. For streams larger than 2GB, the
FileInputStream.available() implementation returns
Hi Mike,
Thanks for the review, here is the new version:
http://cr.openjdk.java.net/~ksrini/6990106/webrev.02/
Attribute.java/Instruction.java/Package.java.File :
- Layout.equals(Object x) {
return x instanceof Layout equals((Layout)x);
}
should be :
Layout.equals(Object x) {
return
Hi Mandy,
Looks good to me.
David
Mandy Chung said the following on 11/19/10 08:34:
6631046: BufferedInputStream.available() reports negative int on very
large inputstream
Webrev at:
http://cr.openjdk.java.net/~mchung/6631046/webrev.00/
InputStream.available() returns an int. For streams
Hi Kumar,
I reviewed your latest webrev.02. Looks good to me.
Thanks
Mandy
On 11/12/10 12:17, Kumar Srinivasan wrote:
Thanks for all the reviews!.
Here are the fixes in this version:
http://cr.openjdk.java.net/~ksrini/6452854/webrev.01
1. Fixed the representation of numbers and scaling
Changeset: 03177f49411d
Author:jjg
Date: 2010-11-18 16:13 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/03177f49411d
6999438: remove support for exotic identifiers from JDK 7
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/code/Source.java
!
Would it be possible to call GetFileSizeEx() (or add a call to GetLastError())
MSDN:
Note that if the return value is INVALID_FILE_SIZE (0x), an
application must call GetLastError to determine whether the function has
succeeded or failed. The reason the function may appear to fail
A few more I nits I noticed.
BandStructure : allKQBands could be final.
ClassReader : string switch opportunities in readAttributes()
FixedArrayList : Seems to be unchanged since last webrev. Was nothing saved by
extending AbstractList?
ConstantPool : equals() only works as long as all
Alan,
It might not be a real regression if only consider the supported platforms
(and yes, the malloc manpageI can found does clearly indicate NULL is
for error).
However I prefer to add some checks to make sure it behaves the same
(compared to before the #6728376 change went it), even on the
12 matches
Mail list logo
