Re: Review request 7039809: Remove @ConstructorProperties annotation from java.io.File class

2011-04-29 Thread Alan Bateman
Mandy Chung wrote: Sergey, Alan, Can you review the fix for: 7039809: Remove @ConstructorProperties annotation from java.io.File class Webrev at: http://cr.openjdk.java.net/~mchung/jdk7/7039809/webrev.00/ Looks good to me. -Alan.

Re: Review request the fix for CR 7040150

2011-04-29 Thread Lance Andersen - Oracle
On Apr 28, 2011, at 11:52 PM, Stuart Marks wrote: On 4/28/11 11:13 AM, Lance Andersen - Oracle wrote: Hi all, I could use a reviewer for 7040150 which addresses a positioning issue with CacheResultSetImpl.removeCurrentRow(). The diff is located at:

hg: jdk7/tl/jdk: 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow

2011-04-29 Thread lance . andersen
Changeset: 0b1354ecf5a3 Author:lancea Date: 2011-04-29 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow Reviewed-by: smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java

hg: jdk7/tl/jdk: 7039809: Remove @ConstructorProperties annotation from java.io.File class

2011-04-29 Thread mandy . chung
Changeset: 24ad188dc46c Author:mchung Date: 2011-04-29 08:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24ad188dc46c 7039809: Remove @ConstructorProperties annotation from java.io.File class Reviewed-by: alanb, malenkov ! src/share/classes/java/io/File.java -

hg: jdk7/tl/langtools: 4 new changesets

2011-04-29 Thread maurizio . cimadamore
Changeset: 4c03383f6529 Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c03383f6529 7040104: javac NPE on Object a[]; Object o = (a=null)[0]; Summary: When a null literal is found on top of stack, if expected type is

Re: Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()

2011-04-29 Thread Neil Richards
On 28 April 2011 12:01, Alan Bateman alan.bate...@oracle.com wrote: I skimmed through the webrev and I agree this is a better approach. I will try to do a detailed review before Monday. It would be great if others on the list could jump in and help too as we are running out of time. Neil - I

hg: jdk7/tl/jaxp: 7040147: jaxp 1.4.5 jdk7 integration

2011-04-29 Thread kelly . ohair
Changeset: 30129a58aacc Author:ohair Date: 2011-04-29 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/30129a58aacc 7040147: jaxp 1.4.5 jdk7 integration Reviewed-by: joehw ! jaxp.properties

hg: jdk7/tl/jdk: 7036252: sunpkcs11-solaris.cfg needs a review

2011-04-29 Thread valerie . peng
Changeset: 40e2b3a25533 Author:valeriep Date: 2011-04-29 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/40e2b3a25533 7036252: sunpkcs11-solaris.cfg needs a review Summary: Updated the disabled mechanisms section since Solaris bug 6306708 has been fixed. Reviewed-by:

hg: jdk7/tl/jdk: 7040572: Fix broken java/nio/charset/StandardCharset/Standard.java and add more tests.

2011-04-29 Thread mike . duigou
Changeset: 36dd30b5f85d Author:mduigou Date: 2011-04-29 14:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/36dd30b5f85d 7040572: Fix broken java/nio/charset/StandardCharset/Standard.java and add more tests. Reviewed-by: alanb !