hg: jdk8/tl/langtools: 2 new changesets

2011-10-24 Thread maurizio . cimadamore
Changeset: d346ab55031b Author:mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d346ab55031b 7096014: Javac tokens should retain state Summary: Refactor javac tokens from enum constants to stateful instances (to keep track of position,

Code Review 7104209: Cleanup and remove librmi (native library)

2011-10-24 Thread Chris Hegarty
It appears that the only function of librmi is to export the VM function JVM_LatestUserDefinedLoader. It seems really silly to have a whole native library to perform such a trivial operation. JVM_LatestUserDefinedLoader is also used in java.io.ObjectInputStream. It would make more sense to

Re: Code Review 7104209: Cleanup and remove librmi (native library)

2011-10-24 Thread Mike Duigou
Looks good. Nice catch. Mike On Oct 24 2011, at 07:20 , Chris Hegarty wrote: It appears that the only function of librmi is to export the VM function JVM_LatestUserDefinedLoader. It seems really silly to have a whole native library to perform such a trivial operation.

Re: Code Review 7104209: Cleanup and remove librmi (native library)

2011-10-24 Thread Chris Hegarty
Thanks Mike, It was actually Alan that caught this. Crazy that someone ( at some time ) even thought this was a good idea! -Chris. On 24/10/2011 15:41, Mike Duigou wrote: Looks good. Nice catch. Mike On Oct 24 2011, at 07:20 , Chris Hegarty wrote: It appears that the only function of

code review request : 7099658 : Properties.loadFromXML fails with ClassCastException

2011-10-24 Thread Seán Coffey
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7099658 Simple fix where loadFromXML method should call into the standard API and use the getDocumentElement() call to obtain the properties Element. http://cr.openjdk.java.net/~coffeys/webrev.7099658/ regards, Sean.

Re: code review request : 7099658 : Properties.loadFromXML fails with ClassCastException

2011-10-24 Thread Alan Bateman
On 24/10/2011 18:27, Seán Coffey wrote: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7099658 Simple fix where loadFromXML method should call into the standard API and use the getDocumentElement() call to obtain the properties Element. http://cr.openjdk.java.net/~coffeys/webrev.7099658/

Re: Code Review 7104209: Cleanup and remove librmi (native library)

2011-10-24 Thread Alan Bateman
On 24/10/2011 15:20, Chris Hegarty wrote: It appears that the only function of librmi is to export the VM function JVM_LatestUserDefinedLoader. It seems really silly to have a whole native library to perform such a trivial operation. JVM_LatestUserDefinedLoader is also used in

Re: code review request : 7099658 : Properties.loadFromXML fails with ClassCastException

2011-10-24 Thread Mandy Chung
On 10/24/11 10:27 AM, Seán Coffey wrote: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7099658 Simple fix where loadFromXML method should call into the standard API and use the getDocumentElement() call to obtain the properties Element. http://cr.openjdk.java.net/~coffeys/webrev.7099658/

hg: jdk8/tl/jdk: 7104209: Cleanup and remove librmi (native library)

2011-10-24 Thread chris . hegarty
Changeset: 3f391e649ccb Author:chegar Date: 2011-10-24 20:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f391e649ccb 7104209: Cleanup and remove librmi (native library) Reviewed-by: mduigou, alanb ! make/java/java/mapfile-vers ! make/sun/rmi/rmi/Makefile -

hg: jdk8/tl/jdk: 7103549: Remove dependencies on libjava and libjvm from security libraries

2011-10-24 Thread chris . hegarty
Changeset: b375523d6037 Author:chegar Date: 2011-10-24 21:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b375523d6037 7103549: Remove dependencies on libjava and libjvm from security libraries Reviewed-by: vinnie, ohair, alanb, dholmes !

Re: Code Review 7104209: Cleanup and remove librmi (native library)

2011-10-24 Thread David Holmes
On 25/10/2011 12:47 AM, Chris Hegarty wrote: Thanks Mike, It was actually Alan that caught this. Crazy that someone ( at some time ) even thought this was a good idea! Not only did someone think it a good idea but nobody else disagreed. Sometimes these things are lost in ancient history but