JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Joe Darcy
Hello, Responding to some of code review feedback from Ulf about the unsigned API work, I've taken a pass at purging code'#92;u0030'/code from the jdk repo's javadoc and replacing it with {@code '\u005Cu0030'} since {@code} is generally preferable. Webrev with these changes and other

hg: jdk8/tl/jdk: 7132248: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing

2012-01-23 Thread xuelei . fan
Changeset: d383b5d128e3 Author:xuelei Date: 2012-01-23 04:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d383b5d128e3 7132248: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing Reviewed-by: alanb !

Re: JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Ulf Zibis
Am 23.01.2012 11:33, schrieb Alan Bateman: On 23/01/2012 08:23, Joe Darcy wrote: With these changes, the javadoc builds runs without additional warnings and a specdiff against a reference copy of the javadoc shows no unexpected changes. I'm wondering because of /code.../code error, Alan

RFR 7132378: Race in FutureTask if used with explicit set ( not Runnable )

2012-01-23 Thread Chris Hegarty
This issue was raised on the jdk7u-dev mailing list [1]. The change is to update the FutureTask implementation to what is in Doug's CVS. The old implementation using AbstractQueuedSynchronizer is replaced with a control state field that is updated by CAS to track completion, along with a

Re: JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Joe Darcy
On 01/23/2012 02:33 AM, Alan Bateman wrote: On 23/01/2012 08:23, Joe Darcy wrote: Hello, Responding to some of code review feedback from Ulf about the unsigned API work, I've taken a pass at purging code'#92;u0030'/code from the jdk repo's javadoc and replacing it with {@code

Re: JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Joe Darcy
On 01/23/2012 05:11 AM, Ulf Zibis wrote: Am 23.01.2012 11:33, schrieb Alan Bateman: On 23/01/2012 08:23, Joe Darcy wrote: With these changes, the javadoc builds runs without additional warnings and a specdiff against a reference copy of the javadoc shows no unexpected changes. I'm wondering

Re: JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Ulf Zibis
Am 23.01.2012 18:53, schrieb Joe Darcy: Well, there is the make/scripts directory in the the top-level JDK repository forest. Could you please publish your script there? (maybe via this patch) Joe, thanks for catching my change proposal. Would like to see me as contributor :-) I meant

Re: JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Joe Darcy
On 01/23/2012 10:29 AM, Ulf Zibis wrote: Am 23.01.2012 18:53, schrieb Joe Darcy: Well, there is the make/scripts directory in the the top-level JDK repository forest. Could you please publish your script there? (maybe via this patch) I just used some semi-automated search and replace in

hg: jdk8/tl/jdk: 2 new changesets

2012-01-23 Thread sean . mullan
Changeset: 3df0bd3ed880 Author:mullan Date: 2012-01-23 12:17 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3df0bd3ed880 7131084: XMLDSig XPathFilter2Transform regression involving intersect filter Reviewed-by: xuelei !

Re: JDK 8 code review request for 7132338 Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread Alan Bateman
On 23/01/2012 17:41, Joe Darcy wrote: Hi Alan, Not sure what happened in RandomAccessFile; specdiff caught various problems with earlier versions of the work before I send the webrev out for review. In any case, thanks for the catching the problem; an updated webrev with a corrected (but

hg: jdk8/tl/jdk: 7132338: Use @code friendly idiom for '\' in javadoc

2012-01-23 Thread joe . darcy
Changeset: 91471160 Author:darcy Date: 2012-01-23 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91471160 7132338: Use @code friendly idiom for '\' in javadoc Reviewed-by: alanb ! src/share/classes/java/io/DataInput.java !

Code Review Request Bug #7129185:(coll) Please add Collections.emptyNavigableSet()

2012-01-23 Thread Darryl Mocek
Re-sending this with the synopsis in the subject line (and the correct bug #). Hello core-libs. Please review this patch to fix Bug #7129185. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug #4533691, including adding a Collections.emptyNavigableSet

Re: Code Review Request Bug #7129185:(coll) Please add Collections.emptyNavigableSet()

2012-01-23 Thread Joseph Darcy
Hello Darryl, On 1/23/2012 3:19 PM, Darryl Mocek wrote: Re-sending this with the synopsis in the subject line (and the correct bug #). Hello core-libs. Please review this patch to fix Bug #7129185. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug

Re: RFR 7132378: Race in FutureTask if used with explicit set ( not Runnable )

2012-01-23 Thread David Holmes
Hi Chris, Hard to evaluate a completely new design like this as the devil is always in the details. I don't understand the purpose of handlePossibleCancellationInterrupt. Given it doesn't clear the interrupt state why does it need to wait? Otherwise it looks okay. Thanks, David On

7132270: tools/launcher/DefaultLocaleTestRun.java failing (win)

2012-01-23 Thread Kumar Srinivasan
Hi, Fixes spurious test failure noticed on Windows 64, for some reason the env variable CLASSPATH either is not set in the child environment or it is wrong. This solution eliminates the need to depend on the env variable, instead the classpath (defined by jtreg) is set on the command line of

Re: Code review request for #6469160, #7088271

2012-01-23 Thread David Holmes
Hi Brandon, On 21/01/2012 4:19 AM, Brandon Passanisi wrote: Resending again... Hello core-libs. I was wondering of somebody could be please review the following fix for #6469160 and #7088271. The changes in the webrev fix both bugs. Information is below: Webrev URL: