Re: Code Review Request: 7118100: Inconsistency when using system and user preference on OSX Lion

2012-04-26 Thread Alan Bateman
On 26/04/2012 01:34, Kurchi Hazra wrote: Hi, While syncing user preferences, a BackingStoreException is not expected, since the current user should be able to read/write such preferences to the persistent storage (unlike system preferences, where current user needs to have admin rights). This

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-26 Thread Dmitry Samersoff
Deven, Thank you! On 2012-04-26 05:21, Deven You wrote: Hi Dmitry, Thanks for your help. I have created a CR with internal id 2236492 which hasn't be published yet. So please set this internal CR id as duplicate to 716419 as well. This is the original mail for this problem:

Re: Code Review Request: 7118100: Inconsistency when using system and user preference on OSX Lion

2012-04-26 Thread Kurchi Hazra
Thanks Alan for the thumbs up. I filed 7164636 for the cleanup. - Kurchi On 4/26/2012 12:18 AM, Alan Bateman wrote: On 26/04/2012 01:34, Kurchi Hazra wrote: Hi, While syncing user preferences, a BackingStoreException is not expected, since the current user should be able to read/write

Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Mandy Chung
7164376 Replace use of sun.security.action.LoadLibraryAction with direct call of System.loadLibrary Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/ This change is required for jdk modularization. High level summary: it replaces the use of LoadLibraryAction:

hg: jdk8/tl/jdk: 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion

2012-04-26 Thread kurchi . subhra . hazra
Changeset: 108a02a57b75 Author:khazra Date: 2012-04-26 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/108a02a57b75 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Summary: Enable user to read/write preferences to persistent storage

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Sean Mullan
Looks fine, just a couple of nits. src/macosx/classes/com/apple/concurrent/LibDispatchNative.java, - the closing static brace is not indented the same as the open brace. src/solaris/classes/sun/management/FileSystemImpl.java src/windows/classes/sun/management/FileSystemImpl.java -

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Mandy Chung
Thanks, Sean. I have fixed the 3 files per your comment. Mandy On 4/26/2012 1:59 PM, Sean Mullan wrote: Looks fine, just a couple of nits. src/macosx/classes/com/apple/concurrent/LibDispatchNative.java, - the closing static brace is not indented the same as the open brace.

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-26 Thread Mandy Chung
Thanks, Phil. FYI. I plan to use TL gate for the entire changeset. The change will show up in the awt/2D repos when this gets integrated in the next promoted build. Mandy On 4/26/2012 3:51 PM, Phil Race wrote: All looks good to me. Compiler won't spot misspelled library names so I did try

hg: jdk8/tl/corba: 5 new changesets

2012-04-26 Thread lana . steuck
Changeset: a1b6b8f33d86 Author:ohair Date: 2012-04-10 08:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a1b6b8f33d86 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by: ohair,

hg: jdk8/tl/jaxws: 4 new changesets

2012-04-26 Thread lana . steuck
Changeset: a34aee728ac0 Author:ohair Date: 2012-04-10 08:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a34aee728ac0 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by: ohair,

hg: jdk8/tl/langtools: 6 new changesets

2012-04-26 Thread lana . steuck
Changeset: 807ca8ffbeb4 Author:ohair Date: 2012-04-10 08:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/807ca8ffbeb4 7074397: Build infrastructure changes (makefile re-write) Summary: New makefiles transition, old and new living side by side for now. Reviewed-by:

hg: jdk8/tl/hotspot: 38 new changesets

2012-04-26 Thread lana . steuck
Changeset: e02867d10860 Author:amurillo Date: 2012-03-30 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e02867d10860 7158137: new hotspot build - hs24-b07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 51612f0c0a79 Author:nloodin Date: 2012-03-15

hg: jdk8/tl/jdk: 48 new changesets

2012-04-26 Thread lana . steuck
Changeset: fcc788b5f917 Author:mfang Date: 2012-03-16 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcc788b5f917 Merge Changeset: 5e32f84f0ca9 Author:mfang Date: 2012-03-22 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e32f84f0ca9

Re: Remove the assert in Integer.valueOf()

2012-04-26 Thread Joe Darcy
On 4/24/2012 8:01 AM, Alan Bateman wrote: On 24/04/2012 14:56, Rémi Forax wrote: Here, I don't really ask for tweaking something but more to remove an assert which do something which is unrelated to the current algorithm. In my opinion, it's a debug assert used during the development that

Re: RFR: 7103570 AtomicIntegerFieldUpdater does not work when SecurityManager is installed

2012-04-26 Thread David Holmes
Due to a problem with jtreg and the installation of a security manager I've had to modify the test to install the security manager itself. updated webrev: http://cr.openjdk.java.net/~dholmes/7103570/webrev.02/ Still need an official Review (thanks Chris!) :) Will push as soon as CCC is