Re: Review/comment needed for the new public java.util.Base64 class

2012-10-18 Thread Xueming Shen
On 10/18/2012 6:19 AM, Ulf Zibis wrote: Hi Sherman, you could create the code table by help of a String constant, which would speed up the loading and save a little footprint on the class file. (you have forgotten those tricks from sun.nio.cs coders? ;-) ) The implementation probably needs

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-18 Thread Ulf Zibis
Am 18.10.2012 16:04, schrieb Xueming Shen: On 10/18/2012 6:19 AM, Ulf Zibis wrote: Oops, you are working at 6 in the morning? Hi Sherman, you could create the code table by help of a String constant, which would speed up the loading and save a little footprint on the class file. (you have

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-18 Thread Michael Schierl
Am 18.10.2012 04:10, schrieb Xueming Shen: Hi Webrev has been updated with following changes (1) added a pair of en/decode(ByteBuffer src, ByteBuffer dst) methods I think line 443 needs an additional check for atom == 0. Same for the array case. At least if you do not want an endOfInput

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-18 Thread Xueming Shen
Michael, The current approach assumes that the base64 en/decoding of a file, stream will be handled by the en/decoder.wrap(...). The en/decode(bb, bb) is basically for one time invocation input and output from/to existing buffers, with the hope of avoiding the coding-life-circle management,

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-18 Thread Mike Duigou
I wonder if there would be advantage in using a SharedSecrets mechanism to allow construction of a String directly from a char array. The intermediate byte array seems wasteful especially for what is likely to be a heavily used path. Mike On Oct 17 2012, at 19:10 , Xueming Shen wrote: Hi

bug fix for native kerberos libraries

2012-10-18 Thread Christos Zoulas
Hello, This simple fix allows kerberos authentication to work with: -Dsun.security.jgss.native=true and microsoft's sqljdbc 4.0.2206.100 driver. Enjoy, christos --- a/java/src/sun/security/jgss/GSSUtil.java Mon Oct 15 17:43:08 2012 -0400 +++

Re: bug fix for native kerberos libraries

2012-10-18 Thread Sean Mullan
(Forwarding to security-dev as this should be discussed in that group, not core-libs). On 10/18/12 5:02 PM, chris...@zoulas.com wrote: Hello, This simple fix allows kerberos authentication to work with: -Dsun.security.jgss.native=true and microsoft's sqljdbc 4.0.2206.100 driver.

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-18 Thread Xueming Shen
On 10/18/2012 07:43 AM, Alan Bateman wrote: On 18/10/2012 03:10, Xueming Shen wrote: Hi Webrev has been updated with following changes (1) added a pair of en/decode(ByteBuffer src, ByteBuffer dst) methods (2) some minor spec clarification regarding the end of decoding (3) performance tuning.

RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Christian Thalinger
http://cr.openjdk.java.net/~twisti/6771058 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp Reviewed-by: This test can fail if finalizer of Basic is not called for some reason. It happens in compiled mode if compilation is more slow than execution of the main loop. The

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Christian Thalinger
On Oct 18, 2012, at 3:31 PM, Mandy Chung mandy.ch...@oracle.com wrote: Hi Christian, Thanks for taking on this bug. Sure. I'm trying to get HotSpot nightly failures down. Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Mandy Chung
Hi Christian, Thanks for taking on this bug. Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug build. If you increase the max number of GCs, I wonder how long the test will take to complete/pass? With your fix, how many GC does it

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Mandy Chung
On 10/18/2012 3:37 PM, Christian Thalinger wrote: Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug build. If you increase the max number of GCs, I wonder how long the test will take to complete/pass? Around 14 GCs (runtime with

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread David Holmes
Hi Chris, On 19/10/2012 8:37 AM, Christian Thalinger wrote: On Oct 18, 2012, at 3:31 PM, Mandy Chungmandy.ch...@oracle.com wrote: Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug build. If you increase the max number of GCs, I

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread David Holmes
Hi Martin, On 19/10/2012 10:58 AM, Martin Buchholz wrote: http://code.google.com/p/guava-libraries/source/browse/guava-testlib/src/com/google/common/testing/GcFinalization.java That code uses runFinalization in places which means it is not exercising the primary finalization mechanism. But

Re: [7u12] Request for approval: 7198073: (prefs) user prefs not saved [macosx]

2012-10-18 Thread Seán Coffey
Approved for jdk7u-dev. regards, Sean. On 18/10/2012 13:34, Kurchi Hazra wrote: This is a request for approval to backport the fix for 7198073 from 8 to 7u12. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198073 Webrev: http://cr.openjdk.java.net/~khazra/7198073/7u12/webrev/