On 24/01/2013 22:54, David Holmes wrote:
I was trying to test the fixes for the langtools jtreg issue but when
I submitted my tl forest to JPRT the windows builds failed:
Kumar may have replied to you already but see 8006846 and 8003549.
-Alan,
Changeset: 4c9fcb5cbc07
Author:dingxmin
Date: 2013-01-25 17:00 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c9fcb5cbc07
7183373: URLClassloader.close() does not close JAR files whose resources have
been loaded via getResource()
Reviewed-by: chegar
!
On 25/01/2013 08:33, Alan Bateman wrote:
On 24/01/2013 22:54, David Holmes wrote:
I was trying to test the fixes for the langtools jtreg issue but when
I submitted my tl forest to JPRT the windows builds failed:
Kumar may have replied to you already but see 8006846 and 8003549.
This only
On 24/01/2013 20:29, Eric McCorkle wrote:
Also, can someone more experienced in core-libs please confirm that it
has indeed not been used since that long ago (and perhaps more
importantly, that there are no current plans to use it)?
The only usage that I can find is in the distance past, long
Changeset: 4a4b97f7f83b
Author:alanb
Date: 2013-01-25 13:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a4b97f7f83b
8006565: java.lang.instrument specification should make it clear that
-javaagent is optional
Reviewed-by: sla, dcubed, mchung
!
Thanks for the input, everyone.
I take it this is ok to push, then?
On 01/25/13 06:22, Alan Bateman wrote:
On 24/01/2013 20:29, Eric McCorkle wrote:
Also, can someone more experienced in core-libs please confirm that it
has indeed not been used since that long ago (and perhaps more
Dan,
I've taken a pass over this and overall this is good clean-up and
something that was just not possible before jdk8 because of the need to
keep -XX:+UseVMInterruptibleIO working on Solaris.
A few comments:
- I don't understand why these changes require the make file changes to
link
On 24/01/2013 13:37, Claes Redestad wrote:
Hi all,
this is a refactoring of the I/O trace instrumentation that's going
into JDK
7u14. The fix is only applicable to jdk7 since the corresponding code
does not yet
exist in jdk8.
Bug: 8006757: Refactor Socket and File I/O tracing
Had a chat with Alexey off list. Since 7162111 is indeed required to get
these tests running on headless systems we've agreed to go ahead with
this fix. (but not 8004928) A webrev with this change is at:
http://cr.openjdk.java.net/~robm/7162111/webrev.02/
On 01/25/2013 06:35 AM, David Holmes wrote:
On 25/01/2013 2:36 AM, Peter Levart wrote:
On 01/24/2013 04:45 PM, Peter Levart wrote:
Is there really no existing alignment gap in j.l.Class layout that a
boolean can slide into?
There might be, I will check.
All instance fields in j.l.Class are
That's unfortunate. Can you steal a bit in one of the int fields? E.g.
lastAnnotationsRedefinedCount surely doesn't need the full range right? :)
Sent from my phone
On Jan 25, 2013 11:02 AM, Peter Levart peter.lev...@gmail.com wrote:
On 01/25/2013 06:35 AM, David Holmes wrote:
On 25/01/2013
Looks good. Did you test the fix in ssh session to Mac?
-uta
On 25.01.2013 19:37, Rob McKenna wrote:
Had a chat with Alexey off list. Since 7162111 is indeed required to
get these tests running on headless systems we've agreed to go ahead
with this fix. (but not 8004928) A webrev with this
Changeset: c6ea84a629db
Author:vinnie
Date: 2013-01-25 16:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6ea84a629db
8006946: PKCS12 test failure due to incorrect alias name
Reviewed-by: mullan
! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
On 01/25/2013 08:02 PM, Peter Levart wrote:
On 01/25/2013 06:35 AM, David Holmes wrote:
On 25/01/2013 2:36 AM, Peter Levart wrote:
On 01/24/2013 04:45 PM, Peter Levart wrote:
...so it seems that in both cases, adding a boolean to j.l.Class wastes
8 bytes per Class object :-(
Seems to be the
Hi David,
I was surprised to see Usafe report these offsets. See below:
java.lang.Class *instance* field offsets:
Field Type Field Name Offset
-- -- --
Constructor cachedConstructor 12
On 01/25/2013 05:34 PM, Aleksey Shipilev wrote:
On 01/25/2013 08:02 PM, Peter Levart wrote:
On 01/25/2013 06:35 AM, David Holmes wrote:
On 25/01/2013 2:36 AM, Peter Levart wrote:
On 01/24/2013 04:45 PM, Peter Levart wrote:
...so it seems that in both cases, adding a boolean to j.l.Class
On 01/25/2013 05:34 PM, Aleksey Shipilev wrote:
But, otherwise, can't we use java.lang.ClassValue to associate this flag
with each class?
That is my proposed patch. It tries to be space saving and does not
associate the flag with each class, but only with each subclass of
On 01/25/2013 08:37 PM, Peter Levart wrote:
On 01/25/2013 05:34 PM, Aleksey Shipilev wrote:
80 4 ClassValueMap Class.classValueMap
8412 (alignment/padding gap)
What's this? why 12 bytes?
96 4 int Class.classRedefinedCount
Beats me,
On 01/25/2013 08:40 PM, Peter Levart wrote:
On 01/25/2013 05:34 PM, Aleksey Shipilev wrote:
But, otherwise, can't we use java.lang.ClassValue to associate this flag
with each class?
That is my proposed patch. It tries to be space saving and does not
associate the flag with each class, but
On 01/25/2013 05:42 PM, Aleksey Shipilev wrote:
On 01/25/2013 08:37 PM, Peter Levart wrote:
On 01/25/2013 05:34 PM, Aleksey Shipilev wrote:
80 4 ClassValueMap Class.classValueMap
8412 (alignment/padding gap)
What's this? why 12 bytes?
96 4
But the build uses applescript, preventing builds via ssh.
But I commend this effort, I consider it important that our testing is as
robust as possible.
-kto
On Jan 25, 2013, at 7:37 AM, Rob McKenna wrote:
Had a chat with Alexey off list. Since 7162111 is indeed required to get
these
Hi David,
I think I already have a kind of answer. You wrote it in RFR: 8005232
(JEP-149) Class Instance size reduction:
On 01/06/2013 11:46 PM, David Holmes wrote:
In Java 8, using a 32-bit example, a java.lang.Class instance is 112
bytes consisting of:
- 8 byte object header
- 20
Changeset: 117491dd58c2
Author:vinnie
Date: 2013-01-25 17:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/117491dd58c2
8006951: Avoid storing duplicate PKCS12 attributes
Reviewed-by: mullan
! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
I don't think anyone is using MethodParameters at this point, but I want
to post this just to be sure.
The latest version of the spec alters the class file format of
MethodParameters attributes.
The latest version can be found here:
http://cr.openjdk.java.net/~abuckley/8misc.pdf
I will be
On 01/24/2013 03:34 PM, Peter Levart wrote:
On 01/24/2013 03:10 PM, Alan Bateman wrote:
On 24/01/2013 13:49, Peter Levart wrote:
Should I file a RFE first?
Sorry I don't have time at the moment to study the proposed patch but
just to mention that it has come up a few times, its just that it
Changeset: 77bde15bc6a9
Author:khazra
Date: 2013-01-25 11:52 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77bde15bc6a9
7017962: Obsolete link is used in URL class level spec
Summary: Change the link to an archived document
Reviewed-by: chegar, mduigou
!
Yup, all affected tests pass in both jprt and via an ssh session to a mac.
-Rob
On 25/01/13 16:07, Alexey Utkin wrote:
Looks good. Did you test the fix in ssh session to Mac?
-uta
On 25.01.2013 19:37, Rob McKenna wrote:
Had a chat with Alexey off list. Since 7162111 is indeed required to
Looks fine as far as I can see.
Thanks,
-Joe
On 1/24/2013 3:30 PM, Eric McCorkle wrote:
As far as Coleen and I are aware, this is internal-only. If anyone
knows otherwise, please comment before the end of tomorrow.
Other than that, do you see any problems, Joe?
On 01/24/13 15:41, Joe Darcy
Hi Kuchi,
Javadoc always alphabetizes the summary sections.
But if you scroll down you'll see them in declaration order.
Roger
On 1/16/2013 2:50 PM, Kurchi Hazra wrote:
Hi Sherman,
As I was telling you, I had a very minor comment - the javadoc for the
enums DayOfWeek and Month shows the
Am 18.01.2013 19:26, schrieb Vladimir Kozlov:
Here are Hotspot changes with new jtreg test:
http://cr.openjdk.java.net/~kvn/6896617/webrev
Hi Vladimir,
now I've tried to understand your hotspot code :-)
I tried to do some optimization with less jumps for small strings:
jmp(len = 8) --
Am 18.01.2013 19:26, schrieb Vladimir Kozlov:
Here are Hotspot changes with new jtreg test:
http://cr.openjdk.java.net/~kvn/6896617/webrev
Hi Vladimir,
additionnally instead:
6322 load_unsigned_short(tmp5, Address(src, len, Address::times_2, 0));
6323 testl(tmp5, 0xff00); // check
Am 18.01.2013 19:26, schrieb Vladimir Kozlov:
Here are Hotspot changes with new jtreg test:
http://cr.openjdk.java.net/~kvn/6896617/webrev
Hi Vladimir,
I'm wondering if there would be a similar intrinsic for the reverse decode case?
Also sun.nio.cs.ASCII$Encode.encodeArrayLoop() could
Am 23.01.2013 08:56, schrieb Kirk Pepperdine:
On 2013-01-23, at 1:14 AM, Vitaly Davidovich vita...@gmail.com
mailto:vita...@gmail.com wrote:
Personally, optimizing for interpreter (or even C1) doesn't seem worth it. If something's truly
hot and best perf is desired then use C2 or tiered.
Am 23.01.2013 02:15, schrieb David Holmes:
On 23/01/2013 10:14 AM, Vitaly Davidovich wrote:
Personally, optimizing for interpreter (or even C1) doesn't seem worth it.
If something's truly hot and best perf is desired then use C2 or tiered.
If the method isn't hot enough to trigger the C2
Changeset: 4209b3936a7f
Author:mduigou
Date: 2013-01-25 16:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4209b3936a7f
8005632: Extend java.util.Logger to use SupplierString for messages
Reviewed-by: briangoetz, mduigou
Contributed-by: henry@oracle.com
!
Right - I was going to ask if those tools took into account injected fields.
David
On 26/01/2013 3:32 AM, Peter Levart wrote:
Hi David,
I think I already have a kind of answer. You wrote it in RFR: 8005232
(JEP-149) Class Instance size reduction:
On 01/06/2013 11:46 PM, David Holmes wrote:
Eric,
These situations are historically known as Flag Days and they require
careful management.
I don't know exactly what has to be done but the way to approach this is
to modify the VM to be prepared to handle both the old format and the
new. Then after it has reached TL/jdklangtools
37 matches
Mail list logo
