Hi Henry,
Minor thing.
In Comparator:
194 * @param other the other comparator used when equals on this.
195 * @throws NullPointerException if the argument is null.
196 * @since 1.8
197 */
198 default ComparatorT thenComparing(Comparator? super T other) {
199
Ok, let be nuclear on this,
There is no good reason to introduce OptionalT in java.util.
It doen't work like Google's Guava Optional despite having the same
name, it doesn't work like Scala's Option despite having a similar name,
moreover the lambda pipeline face a similar issue with the
Changeset: 34372bb9115d
Author:sla
Date: 2013-03-05 19:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34372bb9115d
8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library
missing onLoad entry: private_dt_socket
Reviewed-by: alanb
!
On 03/06/2013 11:54 AM, Jed Wesley-Smith wrote:
Really, this is a lot of fuss over nothing.
There is actually no fundamental difference between Scala's Option, Guava's
Optional, Fugue's Option, Java's Optional and Haskell's Maybe – they are
modelling the same thing, the possibility of a value
On 06/03/2013 04:13, BILL PITTORE wrote:
On 3/5/2013 7:36 PM, Dean Long wrote:
If JNI_ONLOAD_SYMBOLS contains something like _JNI_OnLoad@8 on
Windows, you can't just
turn that into _JNI_OnLoad@8_ + libname. I think it needs to be
_JNI_OnLoad_ + libname + @8
I'll look into that. When I built
On 05/03/2013 23:05, bill.pitt...@oracle.com wrote:
This request is tied to bugid 8005716 that deals with adding support
for statically linked JNI libraries.
The JEP is here: http://openjdk.java.net/jeps/178
The bug is here:http://bugs.sun.com/view_bug.do?bug_id=8005716
The webrevs are here:
Hi,
Can I get a review of this small fix for issue 8007808: Missing method:
Executable.getAnnotatedReturnType()
http://cr.openjdk.java.net/~jfranck/8007808/webrev.00/
When we added Core Reflection support for type annotations this method got
left out on Executable, but were included on
Hi Joel,
Look good; approved.
-Joe
On 3/6/2013 6:37 AM, Joel Borggrén-Franck wrote:
Hi,
Can I get a review of this small fix for issue 8007808: Missing
method: Executable.getAnnotatedReturnType()
http://cr.openjdk.java.net/~jfranck/8007808/webrev.00/
When we added Core Reflection support
Changeset: d0178bd8125c
Author:mcimadamore
Date: 2013-03-06 15:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0178bd8125c
8009299: Javac crashes when compiling method reference to static interface
method
Summary: Assertion in Check.checMethod is too strict
Just another idea:
findFirst() throws NoSuchElementException if the stream is empty.
Add an intermediary operation that maps an empty stream to a non-empty one
StreamT ifEmpty(T item);
so we can say
stream.ifEmpty(null).findFirst();
stream.ifEmpty(0).reduce(sum);
Hi Joel,
looks good for me too :)
Rémi
On 03/06/2013 04:35 PM, Joe Darcy wrote:
Hi Joel,
Look good; approved.
-Joe
On 3/6/2013 6:37 AM, Joel Borggrén-Franck wrote:
Hi,
Can I get a review of this small fix for issue 8007808: Missing
method: Executable.getAnnotatedReturnType()
On Mar 5, 2013, at 7:36 PM, Dean Long wrote:
If JNI_ONLOAD_SYMBOLS contains something like _JNI_OnLoad@8 on Windows, you
can't just
turn that into _JNI_OnLoad@8_ + libname. I think it needs to be
_JNI_OnLoad_ + libname + @8
Good catch Dean.
Looks like onLoadSymbols[] is unused in
Changeset: b35d986ff276
Author:mduigou
Date: 2013-03-06 08:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b35d986ff276
8009162: root repo make test target should run against image
Reviewed-by: alanb, martin, erikj
! common/makefiles/Main.gmk
On Mar 6 2013, at 09:19 , Alan Bateman wrote:
On 05/03/2013 22:46, Mike Duigou wrote:
I have updated the webrev to remove the useAltHashing boolean.
http://cr.openjdk.java.net/~mduigou/JDK-8006593/5/webrev/
Mike
Peter's suggestion to remove the useAltHashing field is a great idea.
On 3/5/2013 9:16 AM, Jim Gish wrote:
On 03/01/2013 05:48 PM, Mandy Chung wrote:
On 3/1/2013 1:25 PM, Jim Gish wrote:
Please review
http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/
This removes the stack search from Logger.findResourceBundle()
It's good to
On Mar 6 2013, at 08:21 , Bob Vandette wrote:
For a traditional
JRE that doesn't even require static library support, we'd have to make sure
to run on a VM that
support JNI_VERSION_1_8. It looks like the JDK maintains their own copy of
jni.h.
In earlier days the jni.h file was copied
Changeset: 7246a6e4dd5a
Author:juh
Date: 2013-02-28 16:36 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7246a6e4dd5a
8006853: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout 0
Reviewed-by: mullan
!
On 3/5/2013 8:13 PM, BILL PITTORE wrote:
On 3/5/2013 7:36 PM, Dean Long wrote:
If JNI_ONLOAD_SYMBOLS contains something like _JNI_OnLoad@8 on
Windows, you can't just
turn that into _JNI_OnLoad@8_ + libname. I think it needs to be
_JNI_OnLoad_ + libname + @8
I'll look into that. When I built
Whatever happened to the elvis operator solution from project coin, surely that
solves the majority of issues Optional was meant to solve anyway, without the
headache of type-mix mud clutering up the code.
http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/47.html
_
From:
My intention was to say implementation removed.
Uwe
-
Uwe Schindler
uschind...@apache.org
Apache Lucene PMC Member / Committer
Bremen, Germany
http://lucene.apache.org/
-Original Message-
From: Joe Darcy [mailto:joe.da...@oracle.com]
Sent: Monday, March 04, 2013 5:16 PM
To: Uwe
There is no need for an Option container to show how nested collections may be
misused, you could just as easily show an example of a ListListListT that
is isomorphic to a flattened IterableT . I'd simply point to the utility of
the monadic bind or flatMap function!
There are several reasons
Hi Bill;
Some notes from reviewing the JDK side changes.
System.java/Runtime.java:
The example which begins with the name If the filename argument, needs to
better identify that L is an example. (Italics?)
java/lang/ClassLoader.java:
NativeLibrary::fromClass could be final.
Really, this is a lot of fuss over nothing.
There is actually no fundamental difference between Scala's Option, Guava's
Optional, Fugue's Option, Java's Optional and Haskell's Maybe – they are
modelling the same thing, the possibility of a value not being present.
The fact that there may be
Hello,
I'm not one of the people that you're looking at to review this, but I
have to give this feedback anyway. I tried to give similar feedback
on another mailing list and got no response (maybe I chose the wrong
list). These changes have been bothering me. :)
1. Why disable the following
Hi,
just one suggestion:
rename comparing with compareWith
1)
public static T, U extends Comparable? super U ComparatorT
compareWith(Function? super T, ? extends U keyExtractor) {
2)
default ComparatorT thenCompareWith(Comparator? super T other)
Best Regards,
Ali Ebrahimi
On Wed, Mar 6,
If JNI_ONLOAD_SYMBOLS contains something like _JNI_OnLoad@8 on
Windows, you can't just
turn that into _JNI_OnLoad@8_ + libname. I think it needs to be
_JNI_OnLoad_ + libname + @8
Looks like onLoadSymbols[] is unused in
Java_java_lang_ClassLoader_00024NativeLibrary_findBuiltinLib().
Instead
Looks good to me!
Are this the only methods in the corelib that were removed in favour of a
default implementation in the interface?
Uwe
-
Uwe Schindler
uschind...@apache.org
Apache Lucene PMC Member / Committer
Bremen, Germany
http://lucene.apache.org/
-Original Message-
From:
Changeset: cb0ac8979caa
Author:tbell
Date: 2013-02-26 09:25 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/cb0ac8979caa
8009019: Updates to generated-configure.sh required for 8008914
Reviewed-by: sundar, jlaskey, jjg
! common/autoconf/generated-configure.sh
Thanks for the reviews Joe and Remi
cheers
/Joel
On 6 mar 2013, at 17:15, Remi Forax fo...@univ-mlv.fr wrote:
Hi Joel,
looks good for me too :)
Rémi
On 03/06/2013 04:35 PM, Joe Darcy wrote:
Hi Joel,
Look good; approved.
-Joe
On 3/6/2013 6:37 AM, Joel Borggrén-Franck wrote:
The link below has been updated with a few minor changes, notably to use
constants from {Double,Float}Consts and to include the link to the OpenJDK
issue report. A formatting issue resulting from an awk failure during webrev
script execution was also fixed.
B.
On Feb 28, 2013, at 1:34 PM,
Nice catch, Serguei!
Unfortunately I have already pushed my change, but I filed JDK-8009558:
linked_md.c::dll_build_name can get stuck in an infinite loop to track this
new problem and I am working on a fix.
Thanks,
/Staffan
On 5 mar 2013, at 20:26, serguei.spit...@oracle.com wrote:
Hi
Staffan,
Thank you for the confirmation and taking care about this issue!
Thanks,
Serguei
On 3/6/13 11:36 AM, Staffan Larsen wrote:
Nice catch, Serguei!
Unfortunately I have already pushed my change, but I filed
JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite
loop to
On 03/06/2013 12:58 PM, Mandy Chung wrote:
On 3/5/2013 9:16 AM, Jim Gish wrote:
On 03/01/2013 05:48 PM, Mandy Chung wrote:
On 3/1/2013 1:25 PM, Jim Gish wrote:
Please review
http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/
This removes the stack search from
On 03/06/2013 03:28 AM, Ali Ebrahimi wrote:
Hi,
just one suggestion:
rename comparing with compareWith
There was a round of discussion on naming.
http://mail.openjdk.java.net/pipermail/lambda-libs-spec-observers/2012-November/000446.html
I have my personal preference among proposals, but
Actually for windows I *did* export the undecorated name. I just didn't
see where I did it in the VS IDE. If you don't export the undecorated
name it doesn't work of course.
bill
On 3/5/2013 11:13 PM, BILL PITTORE wrote:
On 3/5/2013 7:36 PM, Dean Long wrote:
If JNI_ONLOAD_SYMBOLS contains
Hello,
Someone on the ICU team recently compared the use of \w between ICU,
Java, and Unicode TR#18
http://www.unicode.org/reports/tr18/#Compatibility_Properties .
The results are in the following ICU bug
http://bugs.icu-project.org/trac/ticket/10006.
A question for core-libs-dev is, does
On 03/06/2013 02:31 AM, Michael Hixson wrote:
Hello,
I'm not one of the people that you're looking at to review this, but I
have to give this feedback anyway. I tried to give similar feedback
on another mailing list and got no response (maybe I chose the wrong
list). These changes have
On 3/6/2013 11:42 AM, Jim Gish wrote:
http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/
L122-125: you may want to replace code/code with {@code }
I think we'll save that for a later day - and then update all the
occurrences of code to {@code}
Fine with
On 03/06/2013 12:44 PM, Steven R. Loomis wrote:
Hello,
Someone on the ICU team recently compared the use of \w between ICU, Java,
and Unicode TR#18
http://www.unicode.org/reports/tr18/#Compatibility_Properties .
The results are in the following ICU bug
On 3/6/13 1:06 PM, Xueming Shen wrote:
On 03/06/2013 12:44 PM, Steven R. Loomis wrote:
Hello,
Someone on the ICU team recently compared the use of \w between
ICU, Java, and Unicode TR#18
http://www.unicode.org/reports/tr18/#Compatibility_Properties .
The results are in the following ICU bug
On 3/6/2013 12:50 PM, Mike Duigou wrote:
Hi Bill;
Some notes from reviewing the JDK side changes.
System.java/Runtime.java:
The example which begins with the name If the filename argument, needs to better
identify that L is an example. (Italics?)
Re-worded that a bit.
Changeset: 14e49a70729a
Author:martin
Date: 2013-03-06 17:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14e49a70729a
8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
Summary: Define FILES_m to force use of linker script
Reviewed-by: sherman,
Pushed to jdk8/tl/jdk.
I recommend this be backported to jdk7u.
Changeset: cf54f6be3e9e
Author:weijun
Date: 2013-03-07 11:32 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf54f6be3e9e
8009604: old make images failed: JarBASE64Encoder class not found
Reviewed-by: xuelei, wetmore
! make/common/Release.gmk
44 matches
Mail list logo
