Re: RFR: JDK-8013827 and JDK-8011950, , java.io.File.createTempFile enters infinite loop when passed invalid data

2013-06-01 Thread Alan Bateman
On 31/05/2013 19:15, Dan Xu wrote: On 05/29/2013 04:54 AM, Alan Bateman wrote: Thanks for taking this one. The changes mean that IAE is now thrown for cases where it wasn't thrown previously and I'm wondering if this is worth doing. It might be simpler to just throw IOException on the

Re: RFR 8005698 : Handle Frequent HashMap Collisions with Balanced Trees

2013-06-01 Thread Doug Lea
On 05/31/13 10:10, Alan Bateman wrote: Assuming Doug and Mike are okay with this then I suggest we try to get it into jdk8/tl soon so that it has a few days bake time before Lana grabs the changes from jdk8/tl for b94. I think Mike is going to sponsor this. On cross-checking with

Re: Review request for JDK-8014834 : shell tests don't begin with #!/bin/sh

2013-06-01 Thread Eric McCorkle
Thanks, Kumar. Do I have a second? Note: JPRT has been unreliable lately, so it may be a while before I can put this in. On 05/30/13 17:45, Kumar Srinivasan wrote: Hi Erik, This looks good, historically the #!shell was inserted after the CopyRight, because it was thought that the

hg: jdk8/tl/langtools: 8010737: javac, known parameter's names should be copied to automatically generated constructors for inner classes

2013-06-01 Thread vicente . romero
Changeset: e9855150c5b0 Author:vromero Date: 2013-06-01 21:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9855150c5b0 8010737: javac, known parameter's names should be copied to automatically generated constructors for inner classes Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6695379: Copy method annotations and parameter annotations to synthetic bridge methods

2013-06-01 Thread vicente . romero
Changeset: ec871c3e8337 Author:vromero Date: 2013-06-01 22:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec871c3e8337 6695379: Copy method annotations and parameter annotations to synthetic bridge methods Reviewed-by: mcimadamore !

Re: RFR: JDK-8013827 and JDK-8011950, , java.io.File.createTempFile enters infinite loop when passed invalid data

2013-06-01 Thread Dan Xu
On 06/01/2013 03:05 AM, Alan Bateman wrote: On 31/05/2013 19:15, Dan Xu wrote: On 05/29/2013 04:54 AM, Alan Bateman wrote: Thanks for taking this one. The changes mean that IAE is now thrown for cases where it wasn't thrown previously and I'm wondering if this is worth doing. It might be