Hello!
We have a request to backport fix for 7147084.
First, it depends on the fix for 8007454, so the webrev includes it too.
Second, the fix had to be adjusted a bit.
- I had to manually replaced Java_java_lang_ProcessImpl_create()
function body with the new version, as 'hg patch' could not
It was meant to be sent to jdk7u-dev
On 24.09.2013 12:03, Ivan Gerasimov wrote:
Hello!
We have a request to backport fix for 7147084.
First, it depends on the fix for 8007454, so the webrev includes it too.
Second, the fix had to be adjusted a bit.
- I had to manually replaced
Updated webrev here:
http://cr.openjdk.java.net/~emc/8020981/
Are there any more comments, or is this good to go?
On 09/19/13 18:15, Eric McCorkle wrote:
The webrev has been updated with Joe's comments addressed.
On 09/19/13 00:11, David Holmes wrote:
On 19/09/2013 9:59 AM, Eric McCorkle
Hi Eric,
Some feedback:
Executable.java:
299 * (i) The number of parameters (parameter_count) is wrong for the
method
What is wrong in this case? Do you mean inconsistent with the signature?
302 * (iv) A parameter's name is , or contains an illegal character [0]
What does [0] mean
Changeset: b606775fd1a3
Author:stefank
Date: 2013-08-29 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3
8014659: NPG: performance counters for compressed klass space
Reviewed-by: jmasa, sla
Contributed-by: erik.he...@oracle.com
!
On 24/09/2013 07:24, Daniel Fuchs wrote:
:
There doesn't seem to be any reason to use any magic timeout value in
these tests - so I simply removed the /timeout=10 option and verified
that the tests passed in configurations where they previously failed.
Sometimes people specify /timeout when
Hi,
There is a new warning about overloads on methods with functional interfaces,
but it appears to be over-agressive as Doug pointed out to me off-list.
If i enable this when compiling tl (make JAVAC_WARNINGS:=-Xlint:overloads) then
one can observe warnings such as on the primitive
Changeset: 96dcb66e6b0a
Author:jjg
Date: 2013-09-24 10:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a
8025050: Doclint doesn't recognize dfn tag
Reviewed-by: bpatel
! src/share/classes/com/sun/tools/doclint/HtmlTag.java
!
Changeset: 503338f16d2b
Author:jjg
Date: 2013-09-24 10:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/503338f16d2b
8025246: [doclint] doclint is showing error on anchor already defined when it's
not
Reviewed-by: bpatel
!
Hi,
I had reported this issue with attached test with behavior I observed, Brian
and me agreed that SuppressWarnings on either one as in this test case should
be sufficient.
Cheers,
Henry
On Sep 24, 2013, at 10:14 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
There is a new
Forgot that attachment is not allowed, the test code is following,
public class TestOverload {
interface FooT {
void m(T arg);
}
interface IntFoo {
void m(int arg);
}
interface BarT {
void bar(FooT arg);
}
interface IntBar
Changeset: 6a05a713450d
Author:jjg
Date: 2013-09-24 11:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a05a713450d
8025272: doclint needs to check for valid usage of @value tag
Reviewed-by: bpatel
! src/share/classes/com/sun/tools/doclint/Checker.java
!
Webrev updated to address these issues.
On 09/24/13 07:51, Joel Borggren-Franck wrote:
364 try {
365 tmp = getParameters0();
366 } catch(IllegalArgumentException e) {
367 // Rethrow ClassFormatErrors
368 throw new
Changeset: 3ae62331a56f
Author:jjg
Date: 2013-09-24 13:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f
8002154: [doclint] doclint should check for issues which are errors in javadoc
Reviewed-by: bpatel
!
Eric,
Should MalformedParametersException save IAE as the root cause? Or is that
an internal detail you don't want leaked?
Webrev updated to address these issues.
On 09/24/13 07:51, Joel Borggren-Franck wrote:
364 try {
365 tmp = getParameters0();
366
Thumbs up.
Mandy
On 9/24/2013 7:24 AM, Daniel Fuchs wrote:
Hi,
This is a trivial fix for:
8025140 - TEST_BUG: java/util/logging/Logger/getGlobal tests fail
due to timeout
JBS:https://bugs.openjdk.java.net/browse/JDK-8025140
webrev:
Hi,
Please review the new webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/1/webrev/
The updated code will attempt to escape potentially bad characters(based
on our best knowledge on Windows and common systems), it's not likely we
can avoid problem for all file systems.
Anyhow, we
Changeset: 184c0d6698c3
Author:bpatel
Date: 2013-09-24 16:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/184c0d6698c3
8016328: Regression : Javadoc i18n regression caused by fix for 8012375
Reviewed-by: jjg
!
On 09/24/2013 11:59 PM, Henry Jen wrote:
Hi,
Please review the new webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/1/webrev/
The updated code will attempt to escape potentially bad characters(based
on our best knowledge on Windows and common systems), it's not likely we
can avoid
19 matches
Mail list logo
