hg: jdk8/tl/jaxws: 2 new changesets

2013-09-27 Thread lana . steuck
Changeset: df5d4d016425 Author:tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/df5d4d016425 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties Changeset: cc682329886b

hg: jdk8/tl/hotspot: 77 new changesets

2013-09-27 Thread lana . steuck
Changeset: e42e456fbe6e Author:amurillo Date: 2013-09-13 00:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e42e456fbe6e 8024764: new hotspot build - hs25-b51 Reviewed-by: jcoomes ! make/hotspot_version Changeset: baa7927dfbd2 Author:zgu Date: 2013-09-04 08:5

hg: jdk8/tl/jdk: 3 new changesets

2013-09-27 Thread lana . steuck
Changeset: 946f3fd5f8bf Author:tbell Date: 2013-09-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/946f3fd5f8bf 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties ! makefiles/jprt.properties

hg: jdk8/tl/nashorn: 2 new changesets

2013-09-27 Thread lana . steuck
Changeset: d1e2050e575e Author:cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d1e2050e575e Added tag jdk8-b109 for changeset 6ec2f9e5ed5b ! .hgtags Changeset: 982dd6e1bf4f Author:lana Date: 2013-09-27 18:38 -0700 URL: http://hg.o

hg: jdk8/tl/jaxp: 2 new changesets

2013-09-27 Thread lana . steuck
Changeset: 02bfab2aa938 Author:tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/02bfab2aa938 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties Changeset: 4c84c5b447b0 A

hg: jdk8/tl/langtools: 3 new changesets

2013-09-27 Thread lana . steuck
Changeset: 985abf1cd327 Author:tbell Date: 2013-09-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/985abf1cd327 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties Changeset: 6f11dc295

hg: jdk8/tl: 2 new changesets

2013-09-27 Thread lana . steuck
Changeset: 91f47e8da5c6 Author:tbell Date: 2013-09-25 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/91f47e8da5c6 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties Changeset: 0cc21882d2f6 Author

hg: jdk8/tl/corba: 2 new changesets

2013-09-27 Thread lana . steuck
Changeset: 428428cf5e06 Author:tbell Date: 2013-09-25 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/428428cf5e06 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties Changeset: 3d2b7ce93c5c

hg: jdk8/tl/jdk: 8025610: Add explicit @throws NPE documentation to Optional constructor and Optional.of

2013-09-27 Thread mike . duigou
Changeset: d921ce805abe Author:mduigou Date: 2013-09-27 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d921ce805abe 8025610: Add explicit @throws NPE documentation to Optional constructor and Optional.of Reviewed-by: briangoetz, chegar, alanb ! src/share/classes/java/

hg: jdk8/tl/jdk: 8025128: File.createTempFile fails if prefix is absolute path

2013-09-27 Thread dan . xu
Changeset: 754db1268be1 Author:dxu Date: 2013-09-27 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/754db1268be1 8025128: File.createTempFile fails if prefix is absolute path Summary: Use only the file name from the supplied prefix for backward compatibility Reviewed-by

Re: RFR: JDK-8025610 : (xs) Optional constructor and Optional.of should explicitly document NPE

2013-09-27 Thread Dan Xu
It looks good. -Dan On 09/27/2013 03:53 PM, Mike Duigou wrote: Hello all; As pointed out by Roger Riggs, Optional.of (and the private Optional(T) constructor) don't explicitly document throwing NPE in response to a null value despite describing value as "non-null". This changeset improves t

hg: jdk8/tl/langtools: 8015073: c.s.t.javac.api.JavacTool.getTask() - more informative exception

2013-09-27 Thread kumar . x . srinivasan
Changeset: 82044fe8c7f7 Author:ksrini Date: 2013-09-27 16:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82044fe8c7f7 8015073: c.s.t.javac.api.JavacTool.getTask() - more informative exception Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTool.jav

Re: RFR: JDK-8025610 : (xs) Optional constructor and Optional.of should explicitly document NPE

2013-09-27 Thread Alan Bateman
On 27/09/2013 15:53, Mike Duigou wrote: Hello all; As pointed out by Roger Riggs, Optional.of (and the private Optional(T) constructor) don't explicitly document throwing NPE in response to a null value despite describing value as "non-null". This changeset improves the documentation to add an

Re: RFR: JDK-8025128, File.createTempFile fails if prefix is absolute path

2013-09-27 Thread Alan Bateman
On 27/09/2013 13:40, Dan Xu wrote: Hi, Recently I made changes in TempDirectory.generateFile() method to prevent using invalidparameters to create temporary files. But such tight control will bring a compatibility issue. This change is going to solve theseproblems. Please help review it. Than

Re: RFR: JDK-8025610 : (xs) Optional constructor and Optional.of should explicitly document NPE

2013-09-27 Thread Chris Hegarty
Looks good to me Mike. -Chris > On 27 Sep 2013, at 17:53, Mike Duigou wrote: > > Hello all; > > As pointed out by Roger Riggs, Optional.of (and the private Optional(T) > constructor) don't explicitly document throwing NPE in response to a null > value despite describing value as "non-null".

Re: RFR: JDK-8025128, File.createTempFile fails if prefix is absolute path

2013-09-27 Thread Chris Hegarty
Looks ok to me Dan. -Chris. On 09/27/2013 01:40 PM, Dan Xu wrote: Hi, Recently I made changes in TempDirectory.generateFile() method to prevent using invalidparameters to create temporary files. But such tight control will bring a compatibility issue. This change is going to solve theseproblem

RFR: JDK-8025610 : (xs) Optional constructor and Optional.of should explicitly document NPE

2013-09-27 Thread Mike Duigou
Hello all; As pointed out by Roger Riggs, Optional.of (and the private Optional(T) constructor) don't explicitly document throwing NPE in response to a null value despite describing value as "non-null". This changeset improves the documentation to add an @throws NPE tag to the javadoc. http://

RFR: JDK-8025128,File.createTempFile fails if prefix is absolute path

2013-09-27 Thread Dan Xu
Hi, Recently I made changes in TempDirectory.generateFile() method to prevent using invalidparameters to create temporary files. But such tight control will bring a compatibility issue. This change is going to solve theseproblems. Please help review it. Thanks! Bug: https://bugs.openjdk.java

hg: jdk8/tl/jdk: 2 new changesets

2013-09-27 Thread mike . duigou
Changeset: fbe6f5dbb24f Author:mduigou Date: 2013-09-27 13:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbe6f5dbb24f 8023339: Refined Collection.removeIf UOE conditions Reviewed-by: mduigou Contributed-by: paul.san...@oracle.com ! src/share/classes/java/util/Collection.

Re: RFR: 8023339 & 8023340 : (xs) Refine throws UOE/NPE Conditions

2013-09-27 Thread Mike Duigou
Corrected before push. Mike On Sep 20 2013, at 12:11 , Paul Sandoz wrote: > Hi Mike, > > You made changes to the documentation of List.replaceAll which does not > perform matching: > > 398 * @param operator the operator to apply to each element > 399 * @throws UnsupportedOperationEx

Re: RFR (M): 8024635: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-27 Thread John Rose
Good. — John On Sep 27, 2013, at 5:39 AM, Sergey Kuksenko wrote: > Updated version at > http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.02/ > according comments: > - remove "null check" comment near Object.requireNonNull calls > - distort/(change parameters order) in key-purposed Me

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-09-27 Thread Jonathan Gibbons
Yes, doclint is enforcing the HTML 4.01 spec for JDK 8. http://www.w3.org/TR/REC-html40/ This is in accordance with the DOCTYPE declaration generated at the beginning of all javadoc-generated files. FWIW, is *always* wrong. It would signify an empty paragraph, equivalent to . -- Jon On

Re: RFR (M): 8024635: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-27 Thread Christian Thalinger
Looks good. On Sep 27, 2013, at 5:39 AM, Sergey Kuksenko wrote: > > Updated version at > http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.02/ > according comments: > - remove "null check" comment near Object.requireNonNull calls > - distort/(change parameters order) in key-purposed M

hg: jdk8/tl/langtools: 8025548: langtools test tools/javac/lambda/methodReference/BridgeMethod.java incorrectly assumes no other methods generated in lambda class

2013-09-27 Thread robert . field
Changeset: dee28dd47e12 Author:rfield Date: 2013-09-27 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dee28dd47e12 8025548: langtools test tools/javac/lambda/methodReference/BridgeMethod.java incorrectly assumes no other methods generated in lambda class Reviewed

hg: jdk8/tl/langtools: 8024842: Define ABS_TEST_OUTPUT_DIR via TEST_OUTPUT_DIR

2013-09-27 Thread mike . duigou
Changeset: 4ed8565fa536 Author:mduigou Date: 2013-09-27 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ed8565fa536 8024842: Define ABS_TEST_OUTPUT_DIR via TEST_OUTPUT_DIR Reviewed-by: ihse, erikj, vromero ! test/Makefile

Re: Fwd: Re: type anno test code check in

2013-09-27 Thread Joe Darcy
On 9/23/2013 3:26 AM, Charlie Wang wrote: OK, here's the link http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation1/webrev/ Also I would appreciate it if you could check in the code once you are OK with it, because these tests have gone through numerous rounds of review and I would like to

hg: jdk8/tl/langtools: 8025537: Convert 2 javac/enumdeclarations tests in jtreg for regression ws

2013-09-27 Thread sonali . goel
Changeset: 699b86e82656 Author:sogoel Date: 2013-09-27 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/699b86e82656 8025537: Convert 2 javac/enumdeclarations tests in jtreg for regression ws Reviewed-by: jjg + test/tools/javac/enum/EnumAsIdentifier.java + test/too

hg: jdk8/tl/jdk: 8025595: Remove alt-rt.jar, used by +AggressiveOps (jdk repo portion of JDK-8024826)

2013-09-27 Thread mike . duigou
Changeset: 914f8d4570df Author:mduigou Date: 2013-09-27 10:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914f8d4570df 8025595: Remove alt-rt.jar, used by +AggressiveOps (jdk repo portion of JDK-8024826) Reviewed-by: alanb, chegar, dholmes, ksrini ! makefiles/CompileJava

Re: RFR (3rd): 8023524: Mechanism to dump generated lambda classes / log lambda code generation

2013-09-27 Thread Henry Jen
On Sep 26, 2013, at 4:01 PM, Mandy Chung wrote: > Hi Henry, > > On 9/25/2013 12:37 AM, Henry Jen wrote: >> Hi, >> >> Please review the update webrev at >> http://cr.openjdk.java.net/~henryjen/ccc/8023524/2/webrev/ > > The doPrivileged block looks okay. It'd be good to limit privileges > by c

hg: jdk8/tl/langtools: 6978886: javadoc shows stacktrace after print error resulting from disk full

2013-09-27 Thread alexander . zuev
Changeset: 2c24a04ebfb4 Author:kizune Date: 2013-09-27 21:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2c24a04ebfb4 6978886: javadoc shows stacktrace after print error resulting from disk full Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-09-27 Thread Joe Darcy
Adding Jon Gibbons, author of doclint. Sergey, currently doclint is enforcing the rules of HTML 4 rather than HTML 5. At some point in the future, we may migrate to HTML 5. -Joe On 9/27/2013 4:08 AM, Sergey Bylokhov wrote: Hello, I have a question about of = > . Should we follow html speci

hg: jdk8/tl/langtools: 8022765: Compiler crashes with exception on wrong usage of an annotation.

2013-09-27 Thread jan . lahoda
Changeset: b7d8b71e1658 Author:jlahoda Date: 2013-09-27 17:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7d8b71e1658 8022765: Compiler crashes with exception on wrong usage of an annotation. Summary: Error recovery for incorrect annotation attribute values - ensure

hg: jdk8/tl/jdk: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread joel . franck
Changeset: 95f609fcb639 Author:ehelin Date: 2013-09-26 16:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95f609fcb639 8025502: Exclude tests due to JDK-8025427 Reviewed-by: ksrini ! test/ProblemList.txt

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Erik Helin
On 2013-09-27, Joel Borggren-Franck wrote: > Hi > > Looks good. I've run the jdk_tools tests and these gets excluded. > > I'll sponsor this for you. Thanks! Erik > > cheers > /Joel > > On 2013-09-27, Erik Helin wrote: > > Hi all, > > > > Joel found a small issue with the patch, the paths we

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Joel Borggren-Franck
Hi Looks good. I've run the jdk_tools tests and these gets excluded. I'll sponsor this for you. cheers /Joel On 2013-09-27, Erik Helin wrote: > Hi all, > > Joel found a small issue with the patch, the paths were slightly wrong. > > An updated webrev is located at: > http://cr.openjdk.java.net

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Erik Helin
Hi all, Joel found a small issue with the patch, the paths were slightly wrong. An updated webrev is located at: http://cr.openjdk.java.net/~ehelin/8025427/webrev.01/ Thanks, Erik On 2013-09-27, Erik Helin wrote: > On 2013-09-26, Kumar Srinivasan wrote: > > Hi Erik, > > > > Looks good!, the b

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Erik Helin
On 2013-09-26, Kumar Srinivasan wrote: > Hi Erik, > > Looks good!, the bug must be tagged with keyword "noreg-build". Thanks! I've added the label to the bug. Erik > Kumar > > >Hi all, > > > >I need to exclude some tests due a recent change to jstat that caused to > >jstat to output the \ufff

Re: RFR (M): 8024635: Caching MethodType's descriptor string improves lambda linkage performance

2013-09-27 Thread Sergey Kuksenko
Updated version at http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.02/ according comments: - remove "null check" comment near Object.requireNonNull calls - distort/(change parameters order) in key-purposed MethodType constructor - move count-slot logic from checkPType to checkPTypes.

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-09-27 Thread Sergey Bylokhov
Hello, I have a question about of = > . Should we follow html specification[1] here or we should always replace to ? [1] http://dev.w3.org/html5/markup/p.html#p see@ Tag omission On 01.07.2013 22:47, Alan Bateman wrote: On 01/07/2013 19:24, Joe Darcy wrote: Hello, Yet another found of docl

hg: jdk8/tl/langtools: 8024497: crash returning this-referencing lambda from default method

2013-09-27 Thread vicente . romero
Changeset: 16194509e483 Author:vromero Date: 2013-09-27 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/16194509e483 8024497: crash returning this-referencing lambda from default method Reviewed-by: jjg, rfield ! src/share/classes/com/sun/tools/javac/code/Symbol.j

hg: jdk8/tl/jdk: 8024861: Incomplete token triggers GSS-API NullPointerException

2013-09-27 Thread weijun . wang
Changeset: eb2c81533876 Author:weijun Date: 2013-09-27 15:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb2c81533876 8024861: Incomplete token triggers GSS-API NullPointerException Reviewed-by: mullan ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java + test