On Feb 1, 2014, at 10:23 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 01/02/2014 18:13, Joe Darcy wrote:
Hello,
Back in JDK 5, the sun.misc.FpUtils class was added to provide low-level
floating-point manipulations methods needed to write tests of the math
library. Over time, those
Looks good to me. Thanks Roger.
-Chris.
On 01/02/14 18:58, Lance @ Oracle wrote:
Looks fine
Which releases are you think of including this in if any besides 9?
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Hi,
An old issue has resurfaced because of a change in AWT. AWT, now, on Mac
OS X, attaches a system graphics thread to the running VM, using
JNI_AttachCurrentThread. This change can result in a NPE, if a security
manager is installed, and the security manager tries to print the name
of the
On 03/02/2014 13:18, Chris Hegarty wrote:
Hi,
An old issue has resurfaced because of a change in AWT. AWT, now, on
Mac OS X, attaches a system graphics thread to the running VM, using
JNI_AttachCurrentThread. This change can result in a NPE, if a
security manager is installed, and the
+1 from a (lower case) reviewer. ;-)
Brian
On Feb 1, 2014, at 10:13 AM, Joe Darcy wrote:
Hello,
Back in JDK 5, the sun.misc.FpUtils class was added to provide low-level
floating-point manipulations methods needed to write tests of the math
library. Over time, those low-level functions
Looks good.
Mandy
On 2/1/2014 10:03 AM, roger riggs wrote:
Hi,
A few small changes to cleanup the name and use of CHECK macros.
The CHECK_NULL_* macros are more generally useful without the JNU_
prefix.
The JNU_CHECK_EXCEPTION* macros apply only when there is an jni
environment.
Webrev:
Hi Alan,
I was on the fence about whether or not to include the bug id in the
test; after you comment, I've removed it in the version that was pushed.
Thanks for the review,
-Joe
On 02/01/2014 01:23 PM, Alan Bateman wrote:
On 01/02/2014 18:13, Joe Darcy wrote:
Hello,
Back in JDK 5, the
+1
Kumar
On 2/3/2014 9:45 AM, Mandy Chung wrote:
Looks good.
Mandy
On 2/1/2014 10:03 AM, roger riggs wrote:
Hi,
A few small changes to cleanup the name and use of CHECK macros.
The CHECK_NULL_* macros are more generally useful without the JNU_
prefix.
The JNU_CHECK_EXCEPTION* macros apply
Hi,
We'd like to propose a JEP to update the Xerces implementation in the
JDK and bring it to up to date to the current Xerces release. Please
review the draft.
Thanks,
Joe
JEP:
Title: Updating JAXP to Xerces 2.11.0
Author: Joe Wang
Organization: Oracle
Created: 2014/01/24
Type: Feature
Please re-review.
I missed a warning that the CHECK_NULL macros was being redefined.
Retaining the previous changes to java/util/jar/pack that removed the
redefinition
addresses the issue.
The webrev now only has a few small changes to cleanup the name and use
of CHECK macros.
The
Looks good Roger.
-Chris.
On 3 Feb 2014, at 20:17, roger riggs roger.ri...@oracle.com wrote:
Please re-review.
I missed a warning that the CHECK_NULL macros was being redefined.
Retaining the previous changes to java/util/jar/pack that removed the
redefinition
addresses the issue.
On 2/3/2014 12:17 PM, roger riggs wrote:
Please re-review.
I missed a warning that the CHECK_NULL macros was being redefined.
Retaining the previous changes to java/util/jar/pack that removed the
redefinition
addresses the issue.
The webrev now only has a few small changes to cleanup the
Hi Huizhe,
Is there a possibility to look at having a more loosely coupled
relationship between Xerces and what is core JDK? I'm thinking about (in
combination with) Jigsaw that you could allow the Xerces components to be
kept up to date more often (assuming API compatibility etc is retained).
Yes,
And it would be even nicer if we could get some of the patches integrated
upstream so that it could be eventually possible to not maintaining this
code, but instead use upstream bundles directly.
Not sure how this could be done, but would be awesome.
Cheers,
Mario
Il 03/feb/2014 22:14
+1
Kumar
On 2/3/2014 12:17 PM, roger riggs wrote:
Please re-review.
I missed a warning that the CHECK_NULL macros was being redefined.
Retaining the previous changes to java/util/jar/pack that removed the
redefinition
addresses the issue.
The webrev now only has a few small changes to
On 03/02/2014 21:13, Martijn Verburg wrote:
Hi Huizhe,
Is there a possibility to look at having a more loosely coupled
relationship between Xerces and what is core JDK? I'm thinking about (in
combination with) Jigsaw that you could allow the Xerces components to be
kept up to date more often
Hi Lance,
The convenience macros are only intended for JDK 9.
Roger
On 2/1/2014 1:58 PM, Lance @ Oracle wrote:
Looks fine
Which releases are you think of including this in if any besides 9?
http://oracle.com/us/design/oracle-email-sig-198324.gifLance
Andersen| Principal Member of
On 03/02/2014 20:17, roger riggs wrote:
Please re-review.
I missed a warning that the CHECK_NULL macros was being redefined.
Retaining the previous changes to java/util/jar/pack that removed the
redefinition
addresses the issue.
The webrev now only has a few small changes to cleanup the
Il 03/feb/2014 22:50 Alan Bateman alan.bate...@oracle.com ha scritto:
In any case, I think this JEP is a good step as it brings the
implementations closer and also revs the support on a number of standards.
Indeed!
Mario
Makes sense - thanks for the extra explanation!
Cheers,
Martijn
On 3 February 2014 22:49, Alan Bateman alan.bate...@oracle.com wrote:
On 03/02/2014 21:13, Martijn Verburg wrote:
Hi Huizhe,
Is there a possibility to look at having a more loosely coupled
relationship between Xerces and
Nobody took the bait on this yet? :-)
Certainly there's a lot of semi-myth on this topic, on both sides. Here's my
source of mythology (or urban legend, as one might have it):
http://www.ibm.com/developerworks/java/library/j-jtp09275/index.html
My concern here is not so much about leaking of
On 02/03/2014 02:19 PM, huizhe wang wrote:
The JDK contains an older Xerces implementation, version 2.7.1. Although there
were
updates in JDK 7 to bring in some changes, we did not bring it completely up to
date
to any later release. The goal of this JEP is to complete the update and bring
On 2/3/2014 5:18 AM, Chris Hegarty wrote:
Hi,
An old issue has resurfaced because of a change in AWT. AWT, now, on
Mac OS X, attaches a system graphics thread to the running VM, using
JNI_AttachCurrentThread. This change can result in a NPE, if a
security manager is installed, and the
Please review this group of java.time updates:
8032749 https://bugs.openjdk.java.net/browse/JDK-8032749: Typo in
java.time.Clock
8032888 https://bugs.openjdk.java.net/browse/JDK-8032888: Error message typo
in TemporalAccessor
8032558 https://bugs.openjdk.java.net/browse/JDK-8032558: Instant
Looks fine Roger; cheers,
-Joe
On 02/03/2014 02:43 PM, roger riggs wrote:
Please review this group of java.time updates:
8032749 https://bugs.openjdk.java.net/browse/JDK-8032749: Typo in
java.time.Clock
8032888 https://bugs.openjdk.java.net/browse/JDK-8032888: Error
message typo in
+1
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Feb 3, 2014, at 5:43 PM, roger riggs roger.ri...@oracle.com wrote:
Please review this group of java.time
The changeset looks fine. But, do we need a CCC for 8032558 and 8032494 for the
record?
-Sherman
On 02/03/2014 02:43 PM, roger riggs wrote:
Please review this group of java.time updates:
8032749 https://bugs.openjdk.java.net/browse/JDK-8032749: Typo in
java.time.Clock
8032888
Thanks Martijn, Mario and Sean for the comments and Alan for the
explanation.
The Xerces implementation has forked mainly in the following areas:
1. integration
The JDK StAX implementation shared the same scanner with that of
SAX/DOM parsers. This part of code has been significantly
+1 by me
Stephen
On 3 February 2014 22:43, roger riggs roger.ri...@oracle.com wrote:
Please review this group of java.time updates:
8032749 https://bugs.openjdk.java.net/browse/JDK-8032749: Typo in
java.time.Clock
8032888 https://bugs.openjdk.java.net/browse/JDK-8032888: Error message
Hi Paul
I know this may be a little bit late. But I am still asking you review this.
http://cr.openjdk.java.net/~tyan/JDK-8033358/webrev.01/
This is a whole demo code include the stream demo code you reviewed before also
included parallel part. There is one other parallel demo that Paul has
Hello,
Please review this small fix to address
JDK-803352: Fix raw type lint warning in sun.nio.ch
--- a/src/share/classes/sun/nio/ch/Reflect.javaMon Feb 03 16:58:02
2014 -0500
+++ b/src/share/classes/sun/nio/ch/Reflect.javaMon Feb 03 22:07:47
2014 -0800
@@ -1,5 +1,5 @@
/*
- *
On 3/02/2014 11:54 PM, Alan Bateman wrote:
On 03/02/2014 13:18, Chris Hegarty wrote:
Hi,
An old issue has resurfaced because of a change in AWT. AWT, now, on
Mac OS X, attaches a system graphics thread to the running VM, using
JNI_AttachCurrentThread. This change can result in a NPE, if a
+1.
Cheers,
Henry
On 02/03/2014 10:09 PM, Joe Darcy wrote:
Hello,
Please review this small fix to address
JDK-803352: Fix raw type lint warning in sun.nio.ch
--- a/src/share/classes/sun/nio/ch/Reflect.javaMon Feb 03 16:58:02
2014 -0500
+++
33 matches
Mail list logo
