Re: JDK 9 RFR of 6375303: Review use of caching in BigDecimal

2014-03-25 Thread Peter Levart
On 03/24/2014 06:48 PM, Brian Burkhalter wrote: Hi Peter, On Mar 24, 2014, at 2:21 AM, Peter Levart peter.lev...@gmail.com mailto:peter.lev...@gmail.com wrote: Thanks to Aleksey for re-establishing the access, I bring you results of the microbenchmark from his quad-core Cortex-A9: Thanks

Re: The s.m.Unsafe representation in hotspot and method registration

2014-03-25 Thread Paul Sandoz
On Mar 24, 2014, at 7:49 PM, Staffan Larsen staffan.lar...@oracle.com wrote: We have abandoned the HSX model. From JDK 8 one version of Hotspot will be tied to one version of the JDK. This looks like old code that has not been cleaned up. Thanks, yes, looks like we can clean this up and

Re: Process API Updates (JEP 102)

2014-03-25 Thread Kasper Nielsen
On Mon, Mar 24, 2014 at 10:11 PM, roger riggs roger.ri...@oracle.comwrote: Hi, I'm starting to work on JEP 102, Process API Updates for JDK 9. Are there use cases for which this is insufficient? Please comment. What about a non-blocking waitFor mechanism such as void

Re: Process API Updates (JEP 102)

2014-03-25 Thread Martijn Verburg
Hi Roger, Is there a short survey we could send out to the wider dev community on this one? I think just about every day to day Java developer has had to use Process at some stage in their career. Cheers, Martijn On 24 March 2014 21:11, roger riggs roger.ri...@oracle.com wrote: Hi, I'm

Re: Process API Updates (JEP 102)

2014-03-25 Thread Robert Stupp
Would be nice to have some kind of async process I/O streaming. And an event mechanism to receive notifications when the process terminates or input is available from stdout/stderr. Am 25.03.2014 um 09:45 schrieb Kasper Nielsen kaspe...@gmail.com: On Mon, Mar 24, 2014 at 10:11 PM, roger

Re: JDK 9 RFR of 6375303: Review use of caching in BigDecimal

2014-03-25 Thread Paul Sandoz
On Mar 24, 2014, at 8:30 PM, Mike Duigou mike.dui...@oracle.com wrote: The other issue here, and why this thread has gone on so long, is that we've been trying to establish what the best idiom is (for 2014-) for this lazy initialization situation so that we can reuse it with less thought

Re: Process API Updates (JEP 102)

2014-03-25 Thread Chris Hegarty
On 25 Mar 2014, at 08:45, Kasper Nielsen kaspe...@gmail.com wrote: On Mon, Mar 24, 2014 at 10:11 PM, roger riggs roger.ri...@oracle.comwrote: Hi, I'm starting to work on JEP 102, Process API Updates for JDK 9. Are there use cases for which this is insufficient? Please comment.

RE: RFR: 8036786: Update jdk7 testlibrary to match jdk8

2014-03-25 Thread Mattis Castegren
This is becoming URGENT as we have other high priority cases pending the backport of these test libraries. We could backport these fixes without the tests and then file a separate bug to backport the tests, but it would be great if we could just get a review of this, as it is a pretty straight

Re: Process API Updates (JEP 102)

2014-03-25 Thread Peter Levart
On 03/24/2014 10:11 PM, roger riggs wrote: Hi, I'm starting to work on JEP 102, Process API Updates for JDK 9. The use cases identified include test execution and build systems such as Jtreg and Hudson/Jenkins. And there is a use-case for using Java to monitor the health of a more complex

Re: RFR: 8036786: Update jdk7 testlibrary to match jdk8

2014-03-25 Thread Staffan Larsen
I’ve looked at the changes in StreamPumper and ProcessTools: they look good. Since the rest of the code is a straight backport, I didn’t look at it. Reviewed. Thanks, /Staffan On 6 mar 2014, at 16:34, Vladimir Kempik vladimir.kem...@oracle.com wrote: Please review this change to update jdk

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-03-25 Thread Staffan Larsen
I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs to the review thread. I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted. Thanks,

Re: Process API Updates (JEP 102)

2014-03-25 Thread David M. Lloyd
On 03/24/2014 04:11 PM, roger riggs wrote: Hi, I'm starting to work on JEP 102, Process API Updates for JDK 9. The use cases identified include test execution and build systems such as Jtreg and Hudson/Jenkins. And there is a use-case for using Java to monitor the health of a more complex

Re: Process API Updates (JEP 102)

2014-03-25 Thread Florian Weimer
On 03/24/2014 10:11 PM, roger riggs wrote: From the scope of the JEP, a fairly simple API seems sufficient. - Enumerate the direct children - The rest of the functions are similar to Process - to terminate a process, forcibly and normally - to destroy a process and all of its

Re: Process API Updates (JEP 102)

2014-03-25 Thread Roger Riggs
Hi Martin, Good idea, I'll put something together in the next couple of weeks. Roger On 3/25/14 1:54 AM, Martijn Verburg wrote: Hi Roger, Is there a short survey we could send out to the wider dev community on this one? I think just about every day to day Java developer has had to use

Re: Process API Updates (JEP 102)

2014-03-25 Thread Alan Bateman
On 25/03/2014 09:50, Peter Levart wrote: : It would just require the API specification to strengthen it's guarantees on some methods: for example destroyForcibly() would guarantee forcible termination. It might require an additional method like destroyNicely() or terminateNicely() which

Experimental patches for unsafe cleanup was Re: The s.m.Unsafe representation in hotspot and method registration

2014-03-25 Thread Paul Sandoz
On Mar 25, 2014, at 9:34 AM, Paul Sandoz paul.san...@oracle.com wrote: On Mar 24, 2014, at 7:49 PM, Staffan Larsen staffan.lar...@oracle.com wrote: We have abandoned the HSX model. From JDK 8 one version of Hotspot will be tied to one version of the JDK. This looks like old code that has

Re: Experimental patches for unsafe cleanup was Re: The s.m.Unsafe representation in hotspot and method registration

2014-03-25 Thread Staffan Larsen
(Adding hotspot-runtime-dev since some changes are in hotspot code). On 25 mar 2014, at 14:20, Paul Sandoz paul.san...@oracle.com wrote: On Mar 25, 2014, at 9:34 AM, Paul Sandoz paul.san...@oracle.com wrote: On Mar 24, 2014, at 7:49 PM, Staffan Larsen staffan.lar...@oracle.com wrote:

Re: Process API Updates (JEP 102)

2014-03-25 Thread Alan Bateman
On 25/03/2014 12:17, David M. Lloyd wrote: There are two features we would definitely like to see added: 1) NIO Channel interface for process streams 2) The ability to pass additional channels to child processes #1 seems relatively straightforward, Assuming #1 means non-blocking and

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-03-25 Thread Alan Bateman
On 25/03/2014 12:14, Staffan Larsen wrote: I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs to the review thread. I’m sure you know this, but for the record: please don’t push this until

ProcessReaper: single thread reaper

2014-03-25 Thread Peter Levart
On 03/24/2014 10:05 PM, roger riggs wrote: Hi Rob, Martin, et.al. I've prototyped (for 9) a thread reaper[1] that uses a single thread to wait for exiting processes and calling back to the process with the exit status. the interesting part is getting the exit status back to the Process that

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-03-25 Thread Yekaterina Kantserova
On 03/25/2014 01:14 PM, Staffan Larsen wrote: I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs to the review thread. I’m sure you know this, but for the record: please don’t push this until

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-03-25 Thread Yekaterina Kantserova
On 03/25/2014 02:53 PM, Alan Bateman wrote: On 25/03/2014 12:14, Staffan Larsen wrote: I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs to the review thread. I’m sure you know this, but for

Re: JDK 9 RFR of 6375303: Review use of caching in BigDecimal

2014-03-25 Thread Brian Burkhalter
On Mar 25, 2014, at 1:58 AM, Paul Sandoz paul.san...@oracle.com wrote: This is another example of a stable variable. I would like to re-iterate my scepticism that such changes are necessary in this case (i am not sure if it is possible to create a benchmark that could better exacerbate

Re: ProcessReaper: single thread reaper

2014-03-25 Thread Peter Levart
On 03/25/2014 03:05 PM, Peter Levart wrote: That's enough races for today. Or just one more... The debug log(Unexpected process exit for pid:...) could also be reached when new process is spawned by UNIXProcess constructor and before the constructor manages to register new consumer for it's

Re: ProcessReaper: single thread reaper

2014-03-25 Thread Roger Riggs
Hi Peter, Thanks for the comments, I'll fix the races conditions, I intended to go back to the dedicated thread but wanted to check for scalability in the case of a large number of threads and non-trivial termination overheads where the streams had to be drained. Thanks, Roger On 3/25/14

Re: ProcessReaper: single thread reaper

2014-03-25 Thread Peter Levart
On 03/25/2014 05:25 PM, Roger Riggs wrote: Hi Peter, Thanks for the comments, I'll fix the races conditions, I intended to go back to the dedicated thread but wanted to check for scalability in the case of a large number of threads and non-trivial termination overheads where the streams had

Re: Experimental patches for unsafe cleanup was Re: The s.m.Unsafe representation in hotspot and method registration

2014-03-25 Thread Paul Sandoz
On Mar 25, 2014, at 2:37 PM, Staffan Larsen staffan.lar...@oracle.com wrote: (Adding hotspot-runtime-dev since some changes are in hotspot code). On 25 mar 2014, at 14:20, Paul Sandoz paul.san...@oracle.com wrote: On Mar 25, 2014, at 9:34 AM, Paul Sandoz paul.san...@oracle.com wrote:

Re: Process API Updates (JEP 102)

2014-03-25 Thread Mark Sheppard
Hi Roger, I have a few questions for your consideration, hopefully they make sense! Is this API to be available to the plug-in/applet? Even with appropriate permissions? What permissions are required to invoke operations on the API? Do you need to differentiate between spawning a Java

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

2014-03-25 Thread Jonathan Gibbons
On 03/25/2014 07:31 AM, Yekaterina Kantserova wrote: On 03/25/2014 02:53 PM, Alan Bateman wrote: On 25/03/2014 12:14, Staffan Larsen wrote: I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs

Implicit 'this' return for void methods

2014-03-25 Thread Victor Polischuk
Good day, everyone, I have a question regarding a proposal I found some time ago: http://tech.puredanger.com/java7#chained. In a word, it is all about replacing 'void' behavior to always return 'this' and I think for static methods it would be nice to return Class instance. I have not found

Re: RFR (L) 8037210: Get rid of char-based descriptions 'J' of basic types

2014-03-25 Thread Christian Thalinger
+ enum BasicType { + L_TYPE('L', Object.class, Wrapper.OBJECT), // all reference types + I_TYPE('I', int.class,Wrapper.INT), + J_TYPE('J', long.class, Wrapper.LONG), + F_TYPE('F', float.class, Wrapper.FLOAT), + D_TYPE('D', double.class,

8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

2014-03-25 Thread Mike Duigou
Hello all; Recently HotSpot gained additional support for transactional memory, https://bugs.openjdk.java.net/browse/JDK-8031320. This patch is a libraries followon to that change. RTM and other transactional memory implementations benefit from clustering writes towards the end of the

Re: Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-25 Thread Mandy Chung
On 3/24/2014 8:15 AM, Alan Bateman wrote: On 21/03/2014 21:28, Mandy Chung wrote: This is the second patch to eliminate the dependencies to sun.security.action: https://bugs.openjdk.java.net/browse/JDK-8038177 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8038177/webrev.00/

Re: Review request for 8038177 Eliminate unnecessary dependency to sun.security.action

2014-03-25 Thread Alan Bateman
On 25/03/2014 20:41, Mandy Chung wrote: : The ExtendedCharsets.init method has a check to ensure that the VM has been booted. Sherman can confirm that. 1170 protected void init() { 1171 if (initialized) 1172 return; 1173 if (!sun.misc.VM.isBooted()) 1174

Re: ProcessReaper: single thread reaper

2014-03-25 Thread Roger Riggs
Hi Martin, Two cases, one current and one future. In the current case, Process can spawn a process and the process can exit before Process can register the callback to get the exitValue. Peter pointed out this race in his comments. The exitValue needs to be saved (for some time yet to be

Re: ProcessReaper: single thread reaper

2014-03-25 Thread Roger Riggs
Hi Peter, The stream draining code was added in 2011 to address resource exhaustion due to poor hygiene. * JDK-6944584 https://bugs.openjdk.java.net/browse/JDK-6944584 Improvements to subprocess handling on Unix Moves the resource 'leak' from the OS kernel/process space to the heap and

Re: 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

2014-03-25 Thread Remi Forax
On 03/25/2014 09:37 PM, Mike Duigou wrote: Hello all; Recently HotSpot gained additional support for transactional memory, https://bugs.openjdk.java.net/browse/JDK-8031320. This patch is a libraries followon to that change. RTM and other transactional memory implementations benefit from

Re: ProcessReaper: single thread reaper

2014-03-25 Thread Roger Riggs
No, in the prototype only. The current shipping implementation dedicates a thread to each Process and waits only for a specific pid to exit. Roger On 3/25/14 3:50 PM, Martin Buchholz wrote: Roger, are you saying there's a race in the currently shipping implementation? --- I believe

Re: Process API Updates (JEP 102)

2014-03-25 Thread Roger Riggs
Hi Peter, On 3/25/14 2:50 AM, Peter Levart wrote: On 03/24/2014 10:11 PM, roger riggs wrote: Hi, I'm starting to work on JEP 102, Process API Updates for JDK 9. The use cases identified include test execution and build systems such as Jtreg and Hudson/Jenkins. And there is a use-case for

Re: Process API Updates (JEP 102)

2014-03-25 Thread Roger Riggs
Hi Florian, On 3/25/14 5:18 AM, Florian Weimer wrote: On 03/24/2014 10:11 PM, roger riggs wrote: From the scope of the JEP, a fairly simple API seems sufficient. - Enumerate the direct children - The rest of the functions are similar to Process - to terminate a process, forcibly and

Re: 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

2014-03-25 Thread David Holmes
Mike, On 26/03/2014 6:37 AM, Mike Duigou wrote: Hello all; Recently HotSpot gained additional support for transactional memory, https://bugs.openjdk.java.net/browse/JDK-8031320. This patch is a libraries followon to that change. RTM and other transactional memory implementations benefit

Re: Implicit 'this' return for void methods

2014-03-25 Thread David Holmes
On 26/03/2014 6:19 AM, Victor Polischuk wrote: Good day, everyone, I have a question regarding a proposal I found some time ago: http://tech.puredanger.com/java7#chained. More direct original link: http://www.mernst.org/blog/rss.xml#AModestLanguageProposal In a word, it is all about