Re: JDK9 project: XML/JAXP Approachability / Ease of Use

Thanks Michael! And, welcome to core-libs-dev! :-) On 6/26/2014 4:02 AM, Michael Kay wrote: Here are some quick thoughts about the state of XML support in the JDK: 1. XML Parser. The version of Xerces in the JDK has long been buggy, and no-one has been fixing the bugs. It needs to be replaced

RFR: 8048207 : (xs) Collections.checkedQueue offer() calls add() on wrapped queue

Hello all; This changeset corrects an issue with the Collections.checkedQueue() utility method added in Java 8. The wrapper implementation incorrectly calls add() on the wrapped queue rather than offer(). I improved the existing unit test to include this condition (and converted it to TestNG).

Re: ThreadLocalRandom clinit troubles

On 6/26/2014 4:10 PM, Doug Lea wrote: This seems to be the best idea yet, assuming that people are OK with the changes to sun.security.provider.SeedGenerator and NativeSeedGenerator.java I've been meaning to review this thread, but have been chasing several urgent escalations. Brad

Re: ThreadLocalRandom clinit troubles

Peter: Thanks very much for attacking the shocking impact/complexity of getting a few seed bits. On 06/25/2014 01:41 PM, Peter Levart wrote: Peeking around in the sun.security.provider package, I found there already is a minimal internal infrastructure for obtaining random seed. It's encapsula

Re: Process trees and termination

On 6/26/14 7:23 AM, roger riggs wrote: On 6/26/2014 4:55 AM, Peter Levart wrote: - Will there be a guarantee that ProcessHandle objects returned from factory methods: [...] representing those processes that were started by ProcessBuilder API are actually the same Process objects that were return

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

The possible values are: off, summary and detail Thanks, -Zhengyu On 6/26/2014 3:58 PM, Neil Toda wrote: You are right. I found this upon looking: https://www.securecoding.cert.org/confluence/display/seccode/POS34-C.+Do+not+call+putenv()+with+a+pointer+to+an+automatic+variable+as+the+argume

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

You are right. I found this upon looking: https://www.securecoding.cert.org/confluence/display/seccode/POS34-C.+Do+not+call+putenv()+with+a+pointer+to+an+automatic+variable+as+the+argument We moved to malloc since the launcher doesn't know about the value being passed with the native memory f

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

Hi Neil, There is still an issue. Apparently, you can NOT free the buffer for the environment variable. 678 char * pbuf = (char*)JLI_MemAlloc(pbuflen); 679 JLI_Snprintf(pbuf, pbuflen, "%s%d=%s", NMT_Env_Name, JLI_GetPid(), value); 680 retval =

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

On 06/25/2014 06:43 PM, Paul Sandoz wrote: On Jun 19, 2014, at 7:39 PM, Claes Redestad wrote: Hi, an updated webrev with reworked, public methods is available here: http://cr.openjdk.java.net/~redestad/8041972/webrev.8/ Reviews are yet again appreciated! I think "if (s == null)" or "Objects

Re: Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

Zhengyu Earlier creation of the environmental variable. http://cr.openjdk.java.net/~ntoda/8042469/webrev-07/ The new webrev [07] places the new code in the function SetJvmEnvironment() === . JLI_Launch() . InitLauncher() . CreateExecutionEnvironment() . CheckJvmType() . SetJvmEnviro

Re: Character, Byte, Short valueOf instead of new instance

Otavio, I scanner the patches and they mainly look fine to me. Just a minor issue, as per the Long thread. diff -r d02b062bc827 src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java --- a/src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java Fri Jun 13 11:21:30 2014 -0700 ++

Re: Process trees and termination

Hi Paul, Whether an interface or class, it is desirable that Process have the new capabilities of iterating over children and destroying the tree and other possible additions retrieving information about the process like the process name, start time, etc. If Process had a ProcessHandle then th

Re: Process trees and termination

Hi Peter, Thanks for the comments... On 6/26/2014 4:55 AM, Peter Levart wrote: On 06/26/2014 12:05 AM, David M. Lloyd wrote: On 06/25/2014 04:52 PM, roger riggs wrote: Hi, The next step for JEP 102, Process API Updates is to provide an API to enumerate the hierarchy of processes and to be ab

Re: Process trees and termination

Hi David, On 6/25/2014 6:05 PM, David M. Lloyd wrote: On 06/25/2014 04:52 PM, roger riggs wrote: Hi, The next step for JEP 102, Process API Updates is to provide an API to enumerate the hierarchy of processes and to be able to terminate a process tree. This draft javadoc

Re: Long valueOf instead of new Long

On Jun 26, 2014, at 3:29 PM, Andrej Golovnin wrote: > Hi Paul, > > Seems fine to me (pending a full test run). > > Just a syntax niggle in the following, too many brackets: > > +++ new/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java > 2014-06-14 10:16:02.486298421 -03

Re: Process trees and termination

I have a question on the way this is modeled. By introducing a superclass, Process becomes a type of ProcessHandle. That doesn't seem right to me. I expect a Process to have a handle (not be one). Also I think these operations may make more sense as an interface. Cheers, Paul On Wed, Jun 25, 20

Re: Long valueOf instead of new Long

Hi Paul, Seems fine to me (pending a full test run). > > Just a syntax niggle in the following, too many brackets: > > +++ > new/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java > 2014-06-14 10:16:02.486298421 -0300 > @@ -544,7 +544,7 @@ > } > > // co

Re: Long valueOf instead of new Long

On Jun 26, 2014, at 11:58 AM, Chris Hegarty wrote: > Otavio, > > I skimmed over the patches and they look ok to me. I think they would be > suitable for inclusion in jdk9/dev. Seems fine to me (pending a full test run). Just a syntax niggle in the following, too many brackets: +++ new/src/

Re: JDK9 project: XML/JAXP Approachability / Ease of Use

Here are some quick thoughts about the state of XML support in the JDK: 1. XML Parser. The version of Xerces in the JDK has long been buggy, and no-one has been fixing the bugs. It needs to be replaced with a more recent version of Apache Xerces if that hasn't already been done. 2. DOM. From a

Re: Long valueOf instead of new Long

Thank you Chris. I don't know if is better, but I did with all wrapper in this path. http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-June/027285.html But if will better, I can split each wrapper as path. On Thu, Jun 26, 2014 at 6:58 AM, Chris Hegarty wrote: > Otavio, > > I skimmed ov

Re: Long valueOf instead of new Long

Otavio, I skimmed over the patches and they look ok to me. I think they would be suitable for inclusion in jdk9/dev. -Chris. P.S. I do not currently have time to sponsor this, but I cc’ed Pavel who may be able to help get his in. On 14 Jun 2014, at 14:46, Otávio Gonçalves de Santana wrote:

Re: Process trees and termination

On 06/26/2014 12:05 AM, David M. Lloyd wrote: On 06/25/2014 04:52 PM, roger riggs wrote: Hi, The next step for JEP 102, Process API Updates is to provide an API to enumerate the hierarchy of processes and to be able to terminate a process tree. This draft javadoc