Re: RFR 8048840: File.createTempFile has uninformative failure message

2014-07-01 Thread Alan Bateman
On 01/07/2014 02:21, Jeremy Manson wrote: Oops - forgot to run jtreg. Make that: diff --git a/src/share/classes/java/io/File.java b/src/share/classes/java/io/File.java --- a/src/share/classes/java/io/File.java +++ b/src/share/classes/java/io/File.java @@ -1998,7 +1998,8 @@ throws

Re: RFR: 8048020 - Regression on java.util.logging.FileHandler

2014-07-01 Thread Daniel Fuchs
On 6/25/14 2:34 PM, Jason Mehrens wrote: Daniel, FileChannel.open(WRITE,APPEND) could throw NoSuchFileException during a startup and shutdown race between two VMs. That case needs to either perform a bounded retry or continue and rotate. Hi Jason, Alan, Here is an updated version of the

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-01 Thread Coleen Phillimore
Thank you! Coleen On 7/1/14, 12:51 AM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore coleen.phillim...@oracle.com wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for

Re: RFR : 7095856: OutputStreamHook doesn't handle null values

2014-07-01 Thread Mark Sheppard
Hi Sean, fix looks good .. surprised to see that GF has been modified to use HashMap and not the JDK wasn't!! In anycase this should solve a few other interop issues WRT the test, I wonder if it is more appropriate to use the javax.rmi.CORBA.Util class to obtain the ValueHandler rather

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Andrej Golovnin
Hi Pavel, I'm sorry I have totally forgotten to mention it. But I think that changes to the classes in the package jdk.internal.org.objectweb.asm should be done directly in the ASM library. In other case you may have conflicts when a new version of the ASM library is integrated into JDK next

RE: RFR: 8048020 - Regression on java.util.logging.FileHandler

2014-07-01 Thread Jason Mehrens
Daniel, Looks bullet proof to me. Jason Date: Tue, 1 Jul 2014 11:25:33 +0200 From: daniel.fu...@oracle.com To: jason_mehr...@hotmail.com; core-libs-dev@openjdk.java.net CC: alan.bate...@oracle.com Subject: Re: RFR: 8048020 - Regression on

Re: RFR : 7095856: OutputStreamHook doesn't handle null values

2014-07-01 Thread Seán Coffey
Hey Mark, thanks for the review. Yes - that's a better way to obtain the valueHandler - will make the change and push shortly. regards, Sean. On 01/07/14 12:41, Mark Sheppard wrote: Hi Sean, fix looks good .. surprised to see that GF has been modified to use HashMap and not the JDK

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Pavel Rappo
Andrej, Thanks a lot! I've separated out all the changes from the 'jdk.internal.org.objectweb.asm' package. So I'll update both threads with new webrevs. http://cr.openjdk.java.net/~prappo/8048874/webrev.02 -Pavel On 1 Jul 2014, at 13:57, Andrej Golovnin andrej.golov...@gmail.com wrote: Hi

Re: Long valueOf instead of new Long

2014-07-01 Thread Pavel Rappo
As per [1] I'm updating this thread with yet another webrev: http://cr.openjdk.java.net/~prappo/8048267/webrev.05 --- [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027487.html -Pavel On 30 Jun 2014, at

RFR JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime (+more)

2014-07-01 Thread Peter Levart
Hi, I propose a patch for this issue: https://bugs.openjdk.java.net/browse/JDK-7186258 The motivation to re-design caching of InetAddress-es was not this issue though, but a desire to attack synchronization bottlenecks in methods like URL.equals and URL.hashCode which use host name to IP

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Andrej Golovnin
Hi Pavel, Thanks a lot! I've separated out all the changes from the 'jdk.internal.org.objectweb.asm' package. So I'll update both threads with new webrevs. http://cr.openjdk.java.net/~prappo/8048874/webrev.02 Looks good to me. @Otávio: Could you please submit the ASM related changes to

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Otávio Gonçalves de Santana
Thank you Remi. The long[1] also was included? [1]https://bugs.openjdk.java.net/browse/JDK-8048267 On Tue, Jul 1, 2014 at 7:28 PM, Remi Forax fo...@univ-mlv.fr wrote: On 07/01/2014 11:01 PM, Andrej Golovnin wrote: Hi Pavel, Thanks a lot! I've separated out all the changes from the

Re: RFR 8048840: File.createTempFile has uninformative failure message

2014-07-01 Thread Stuart Marks
On 7/1/14 1:34 AM, Alan Bateman wrote: On 01/07/2014 02:21, Jeremy Manson wrote: diff --git a/src/share/classes/java/io/File.java b/src/share/classes/java/io/File.java --- a/src/share/classes/java/io/File.java +++ b/src/share/classes/java/io/File.java @@ -1998,7 +1998,8 @@ throws

Re: RFR: 8047722: @since tag cleanup in corba

2014-07-01 Thread Stuart Marks
On 6/30/14 8:17 AM, Henry Jen wrote: On 06/30/2014 12:18 AM, Alan Bateman wrote: On 30/06/2014 02:30, Henry Jen wrote: On 06/20/2014 02:28 PM, Henry Jen wrote: Please review a trivial webrev for jdk9/corba that do the same @since tag normalization as in jdk9/jdk.

RFR(XS): JDK-8048989 small errors in Collectors examples

2014-07-01 Thread Stuart Marks
Please review this small patch to fix some errors in the examples in the docs for java.util.stream.Collectors. Thanks to Raoul Urma for pointing these out. s'marks # HG changeset patch # User smarks # Date 1404256293 25200 # Tue Jul 01 16:11:33 2014 -0700 # Node ID

Re: RFR(XS): JDK-8048989 small errors in Collectors examples

2014-07-01 Thread Joe Darcy
Looks fine Stuart, -Joe On 07/01/2014 05:34 PM, Stuart Marks wrote: Please review this small patch to fix some errors in the examples in the docs for java.util.stream.Collectors. Thanks to Raoul Urma for pointing these out. s'marks # HG changeset patch # User smarks # Date 1404256293 25200