Looks good to me too; thanks Stuart,
-Joe
On 07/11/2014 07:05 PM, Mike Duigou wrote:
Looks fine.
On Jul 11 2014, at 18:11 , Stuart Marks wrote:
Hi all,
Please review this small patch to fix one of the old RMI tests that has started
failing. This simply removes a couple test cases that use
Looks fine.
On Jul 11 2014, at 18:11 , Stuart Marks wrote:
> Hi all,
>
> Please review this small patch to fix one of the old RMI tests that has
> started failing. This simply removes a couple test cases that use the
> (hidden, unsupported) -Xnew option of rmic, which relies on support for ol
+1
On Jul 11, 2014, at 9:11 PM, Stuart Marks wrote:
> Hi all,
>
> Please review this small patch to fix one of the old RMI tests that has
> started failing. This simply removes a couple test cases that use the
> (hidden, unsupported) -Xnew option of rmic, which relies on support for old
> -so
Hi all,
Please review this small patch to fix one of the old RMI tests that has started
failing. This simply removes a couple test cases that use the (hidden,
unsupported) -Xnew option of rmic, which relies on support for old -source and
-target values that were recently removed from javac by
Thank you for looking at this, Mike!
New webrev: http://cr.openjdk.java.net/~redestad/8041972/webrev.12
On 2014-07-12 00:55, Mike Duigou wrote:
Some comments:
- The NumberFormatException.forInputString for some CharSequence is probably
misleading since it doesn't consider the begin-end range
Some comments:
- The NumberFormatException.forInputString for some CharSequence is probably
misleading since it doesn't consider the begin-end range which was in effect
for the parsing. Rather than extracting the substring just for the error
message perhaps include the index at which the error
On 11/07/2014 21:01, Joe Darcy wrote:
Hello,
The purge of old -source and -target values in the JDK regression
tests missed a few items. Please review the patch below which fixes
two of them.
Thanks,
-Joe
This seems fine.
-Alan
Hello,
The purge of old -source and -target values in the JDK regression tests
missed a few items. Please review the patch below which fixes two of them.
Thanks,
-Joe
diff -r d5404a4e4fac test/java/lang/Class/forName/NonJavaNames.sh
--- a/test/java/lang/Class/forName/NonJavaNames.shFri J
On 11.07.2014 23:07, Martin Buchholz wrote:
Ivan, feel free to submit your latest webrev. We have consensus that
changes being made are progress.
Yes, I was going to do that during the weekend after control rebuild.
What is the right way to form the commit message here?
Would it be ok if t
I've been content to just observe Martin and Peter's nice efforts
on this, but one note:
On 07/11/2014 03:00 PM, Martin Buchholz wrote:
On Wed, Jul 9, 2014 at 3:17 PM, Peter Levart wrote:
IMH resizing is arranged so that the table is always 33% ... 66% full (if
nothing is ever removed from
On 07/11/2014 08:16 PM, Paul Sandoz wrote:
On Jul 11, 2014, at 7:56 PM, Remi Forax wrote:
On 07/11/2014 06:18 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00
https://bugs.openjdk.java.net/browse/JDK-8050052
I've found myself writing the very same code as
Me
On Jul 11, 2014, at 7:56 PM, Remi Forax wrote:
> On 07/11/2014 06:18 PM, Vladimir Ivanov wrote:
>> http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00
>> https://bugs.openjdk.java.net/browse/JDK-8050052
>
> I've found myself writing the very same code as
> MethodHandleStatics.uncaughException
On 07/11/2014 06:18 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00
https://bugs.openjdk.java.net/browse/JDK-8050052
I've found myself writing the very same code as
MethodHandleStatics.uncaughException several times
and I wonder if it should not be an instan
http://cr.openjdk.java.net/~vlivanov/8050053/webrev.00
https://bugs.openjdk.java.net/browse/JDK-8050053
Improve sharing of different invokers: basic, generic & exact invokers,
uninitialized call site invoker and NamedFunction invoker are changed.
Testing: jdk/java/lang/invoke, nashorn, octane
On 07/02/2014 01:07 AM, Otávio Gonçalves de Santana wrote:
Thank you Remi.
The long[1] also was included?
[1]https://bugs.openjdk.java.net/browse/JDK-8048267
yes, I've included all the patches (I hope)
http://websvn.ow2.org/revision.php?repname=asm&path=%2Ftrunk%2F&rev=1759
There were just on
http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00
https://bugs.openjdk.java.net/browse/JDK-8050052
Numerous small code cleanups in java.lang.invoke package.
Testing: jtreg, nashorn, octane w/ "-ea -esa" and COMPILE_THRESHOLD={0,30}.
Reviewed-by: vlivanov, ?
Contributed-by: john.r.r...@orac
Hi,
java.net.URL is supposed to behave as an immutable object, so URL
instances can be shared among threads and among parts of code without
fear that they will be modified. URL class has an unusual way to achieve
this (or at least it tries to). Partly because of the design which uses:
- URL
This change looks fine Pavel and eliminates another intermittent test failure.
Thanks.
On 11 Jul 2014, at 14:59, Pavel Rappo wrote:
> Hi everyone,
>
> Could you please review my change for JDK-8049884?
>
> http://cr.openjdk.java.net/~prappo/8049884/webrev.00/
>
> Thanks
> -Pavel
Hi everyone,
Could you please review my change for JDK-8049884?
http://cr.openjdk.java.net/~prappo/8049884/webrev.00/
Thanks
-Pavel
On Jul 11, 2014, at 2:21 PM, Vladimir Ivanov
wrote:
> Igor, thanks for the hint!
Yes, much better.
> Updated version:
> http://cr.openjdk.java.net/~vlivanov/8049555/webrev.01/
>
+1
Paul.
Igor, thanks for the hint!
Updated version:
http://cr.openjdk.java.net/~vlivanov/8049555/webrev.01/
Best regards,
Vladimir Ivanov
On 7/11/14 3:56 PM, Igor Ignatyev wrote:
Vladimir,
instead of the trick w/ 'ClassFileInstaller', you can use
'bootclasspath' option[1] which adds all paths to the b
Vladimir,
instead of the trick w/ 'ClassFileInstaller', you can use
'bootclasspath' option[1] which adds all paths to the bootclasspath:
* @run main/bootclasspath java.lang.invoke.VarargsArrayTest
* @run main/bootclasspath
* -DVarargsArrayTest.MAX_ARITY=255 -DVarargsArrayTest.S
>> http://cr.openjdk.java.net/~vlivanov/8049555/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8049555
Code cleanup:
- moved varargsArray(Class,int) & varargsArray(int) from
sun.invoke.util.ValueConversions to java.lang.invoke.MethodHandleImpl;
- removed unused varargsList(int);
MethodHa
Hi Otavio,
Other than things already spotted by Andrej, the change looks good to me. Thank
you for doing this.
-Pavel
On 11 Jul 2014, at 02:36, Otávio Gonçalves de Santana
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8049892
> http://cr.openjdk.java.net/~prr/8049892/
>
> --
> Cheers!.
24 matches
Mail list logo